linux-stable.git/drivers/i2c/busses, branch linux-3.7.y

i2c: mxs: Fix type of error code

2013-01-28T04:49:02+00:00

commit 0f40cbc4f85e13b1a42ae2f41231645a14965872 upstream.

cmd_err is used to handle error code, so it should not be unsigned.

This fixes the following warning when building with W=1 option:

drivers/i2c/busses/i2c-mxs.c: In function 'mxs_i2c_xfer_msg':
drivers/i2c/busses/i2c-mxs.c:331:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by: Fabio Estevam 
Acked-by: Marek Vasut 
Signed-off-by: Wolfram Sang 
Signed-off-by: Greg Kroah-Hartman

i2c: mxs: Handle i2c DMA failure properly

2012-11-22T22:03:34+00:00

Properly terminate the DMA transfer in case the DMA PIO transfer
or setup fails for any reason.

Signed-off-by: Marek Vasut 
Signed-off-by: Wolfram Sang

i2c: s3c2410: Fix code to free gpios

2012-11-19T10:55:39+00:00

Store the requested gpios so that they can be freed on error/removal.

Signed-off-by: Abhilash Kesavan 
Signed-off-by: Wolfram Sang

i2c: omap: ensure writes to dev->buf_len are ordered

2012-11-14T16:43:03+00:00

if we allow compiler reorder our writes, we could
fall into a situation where dev->buf_len is reset
for no apparent reason.

This bug was found with a simple script which would
transfer data to an i2c client from 1 to 1024 bytes
(a simple for loop), when we got to transfer sizes
bigger than the fifo size, dev->buf_len was reset
to zero before we had an oportunity to handle XDR
Interrupt. Because dev->buf_len was zero, we entered
omap_i2c_transmit_data() to transfer zero bytes,
which would mean we would just silently exit
omap_i2c_transmit_data() without actually writing
anything to DATA register. That would cause XDR
IRQ to trigger forever and we would never transfer
the remaining bytes.

After adding the memory barrier, we also drop resetting
dev->buf_len to zero in omap_i2c_xfer_msg() because
both omap_i2c_transmit_data() and omap_i2c_receive_data()
will act until dev->buf_len reaches zero, rendering the
other write in omap_i2c_xfer_msg() redundant.

This patch has been tested with pandaboard for a few
iterations of the script mentioned above.

Signed-off-by: Felipe Balbi 
Signed-off-by: Wolfram Sang

Revert "ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints"

2012-11-14T10:54:41+00:00

This reverts commit 3db11feffc1ad2ab9dea27789e6b5b3032827adc
(ARM: OMAP: convert I2C driver to PM QoS for MPU latency constraints).
This commit causes I2C timeouts to appear on several OMAP3430/3530-based
boards:

  http://marc.info/?l=linux-arm-kernel&m=135071372426971&w=2
  http://marc.info/?l=linux-arm-kernel&m=135067558415214&w=2
  http://marc.info/?l=linux-arm-kernel&m=135216013608196&w=2

and appears to have been sent for merging before one of its prerequisites
was merged:

  http://marc.info/?l=linux-arm-kernel&m=135219411617621&w=2

Signed-off-by: Paul Walmsley 
Acked-by: Jean Pihet 
Signed-off-by: Wolfram Sang

i2c: at91: fix SMBus quick command

2012-11-14T09:33:21+00:00

The driver claims to support SMBus quick command but it was not the
case. This patch fixes this issue. Without it, i2cdetect finds imaginary
devices. And with some IP versions, trying to send 0 byte can cause
issue when writing data to an EEPROM.

Signed-off-by: Ludovic Desroches 
Acked-by: Jean-Christophe PLAGNIOL-VILLARD 

[wsa: improved the commit message]

Signed-off-by: Wolfram Sang

Merge branch 'i2c-embedded/for-current' of git://git.pengutronix.de/git/wsa/linux

2012-11-03T22:14:54+00:00

Pull i2c embedded fixes from Wolfram Sang:
 "Two patches are usual stuff.

  The bigger patch is needed to correct a wrong decision made in this
  merge window.  We hoped to get the PIOQUEUE mode in the mxs driver
  working with DMA, but it turned out to be too broken (leading to data
  loss), so we now think it is best to remove it entirely and work only
  with DMA now.  The patch should be in 3.7.  IMO, so users never get
  the chance to use both modes in parallel."

* 'i2c-embedded/for-current' of git://git.pengutronix.de/git/wsa/linux:
  i2c: tegra: set irq name as device name
  i2c-nomadik: Fixup clock handling
  i2c: mxs: remove broken PIOQUEUE support

i2c: tegra: set irq name as device name

2012-11-02T09:52:52+00:00

When watching the irqs name of tegra i2c, all instances
irq name shows as tegra_i2c.

Passing the device name properly to have the irq names with
instance like tegra-i2c.0, tegra-i2c.1 etc.

Signed-off-by: Laxman Dewangan 
Acked-by: Jean Delvare 
Signed-off-by: Wolfram Sang

i2c-nomadik: Fixup clock handling

2012-11-02T09:52:52+00:00

Make sure to clk_prepare as well as clk_enable.

Signed-off-by: Philippe Begnic 
Signed-off-by: Ulf Hansson 
Signed-off-by: Linus Walleij 
Signed-off-by: Wolfram Sang

i2c: mxs: remove broken PIOQUEUE support

2012-11-02T09:52:32+00:00

This I2C master can do DMA and PIOQUEUE (PIO with FIFO). Originally,
only PIOQUEUE was supported and it had issues, then DMA support was added
this cycle. The original intention was to keep PIOQUEUE since it has
less overhead what is nice for small transfers. However, runtime
switching between PIOQEUE and DMA depending on the transfer size never
worked despite a lot of trying. Since PIOQUEUE mode itself was flaky
(polling at places where interrupts failed to work) and the
implementation also imposed a size limit for transfers, it is best to
remove the support, so users don't fall over its limitations. It also
makes the driver a lot cleaner and more robust. If somebody really wants
less overhead, plain PIO mode could still be implemented with the
addidtional advantage that this mode is also available on MX23, too.

Signed-off-by: Wolfram Sang 
Reviewed-by: Marek Vasut