linux-stable.git/drivers/hwmon, branch v3.12

hwmon: (applesmc) Always read until end of data

2013-10-09T16:48:55+00:00

The crash reported and investigated in commit 5f4513 turned out to be
caused by a change to the read interface on newer (2012) SMCs.

Tests by Chris show that simply reading the data valid line is enough
for the problem to go away. Additional tests show that the newer SMCs
no longer wait for the number of requested bytes, but start sending
data right away.  Apparently the number of bytes to read is no longer
specified as before, but instead found out by reading until end of
data. Failure to read until end of data confuses the state machine,
which eventually causes the crash.

As a remedy, assuming bit0 is the read valid line, make sure there is
nothing more to read before leaving the read function.

Tested to resolve the original problem, and runtested on MBA3,1,
MBP4,1, MBP8,2, MBP10,1, MBP10,2. The patch seems to have no effect on
machines before 2012.

Tested-by: Chris Murphy 
Cc: stable@vger.kernel.org
Signed-off-by: Henrik Rydberg 
Signed-off-by: Guenter Roeck

hwmon: (applesmc) Check key count before proceeding

2013-09-26T10:48:43+00:00

After reports from Chris and Josh Boyer of a rare crash in applesmc,
Guenter pointed at the initialization problem fixed below. The patch
has not been verified to fix the crash, but should be applied
regardless.

Reported-by: 
Suggested-by: Guenter Roeck 
Signed-off-by: Henrik Rydberg 
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck

hwmon: (k10temp) remove unnecessary pci_set_drvdata()

2013-09-12T15:17:40+00:00

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han 
Acked-by: Clemens Ladisch 
Signed-off-by: Guenter Roeck

hwmon: (tmp421) Fix return value

2013-09-11T20:01:41+00:00

Propagate return value obtained from i2c_smbus_read_byte_data()
instead of hardcoding.

Signed-off-by: Sachin Kamat 
Cc: Andre Prendel 
Signed-off-by: Guenter Roeck

hwmon: (amc6821) Remove redundant break

2013-09-11T20:01:40+00:00

'break' after return or goto has no effect. Remove it.

Signed-off-by: Sachin Kamat 
Cc: T. Mertelj 
Signed-off-by: Guenter Roeck

hwmon: (amc6821) Fix return value

2013-09-11T20:01:40+00:00

Propagate return value obtained from i2c_smbus_read_byte_data()
instead of hardcoding.

Signed-off-by: Sachin Kamat 
Cc: T. Mertelj 
Signed-off-by: Guenter Roeck

hwmon: (ibmaem) Fix return value

2013-09-11T20:01:32+00:00

Propagate appropriate error code obtained from ipmi_create_user()
instead of hardcoding.

Signed-off-by: Sachin Kamat 
Cc: Darrick J. Wong 
Acked-by: Darrick J. Wong 
Signed-off-by: Guenter Roeck

hwmon: (emc2103) Fix return value

2013-09-11T20:01:31+00:00

kstrtol() returns appropriate error values. Use those instead of
hardcoding. Silences several sparse messages of following type:
"why not propagate 'result' from kstrtol() instead of (-22)?"

Signed-off-by: Sachin Kamat 
Cc: Steve Glendinning 
Signed-off-by: Guenter Roeck

hwmon: (ina2xx) Remove casting the return value which is a void pointer

2013-09-10T13:28:31+00:00

Casting the return value which is a void pointer is redundant.
The conversion from void pointer to any other pointer type is
guaranteed by the C programming language.

Signed-off-by: Jingoo Han 
Acked-by: Jean Delvare 
Signed-off-by: Guenter Roeck

hwmon: (hwmon-vid) Add __maybe_unused attribute to dummy variable

2013-09-10T13:28:17+00:00

This gets rid of this warning:

drivers/hwmon/hwmon-vid.c: In function 'get_via_model_d_vrm':
drivers/hwmon/hwmon-vid.c:249:27: warning: variable 'dummy' set but not used
[-Wunused-but-set-variable]

Signed-off-by: Guenter Roeck 
Reviewed-by: Jean Delvare