linux-stable.git/drivers/hv, branch v3.2.99

drivers: hv: Turn off write permission on the hypercall page

2017-06-05T20:13:48+00:00

commit 372b1e91343e657a7cc5e2e2bcecd5140ac28119 upstream.

The hypercall page only needs to be executable but currently it is setup to
be writable as well. Fix the issue.

Signed-off-by: K. Y. Srinivasan 
Acked-by: Kees Cook 
Reported-by: Stephen Hemminger 
Tested-by: Stephen Hemminger 
Signed-off-by: Greg Kroah-Hartman 
[bwh: Backported to 3.2: adjust filename, context]
Signed-off-by: Ben Hutchings

hv: do not lose pending heartbeat vmbus packets

2017-02-23T03:50:55+00:00

commit 407a3aee6ee2d2cb46d9ba3fc380bc29f35d020c upstream.

The host keeps sending heartbeat packets independent of the
guest responding to them.  Even though we respond to the heartbeat messages at
interrupt level, we can have situations where there maybe multiple heartbeat
messages pending that have not been responded to. For instance this occurs when the
VM is paused and the host continues to send the heartbeat messages.
Address this issue by draining and responding to all
the heartbeat messages that maybe pending.

Signed-off-by: Long Li 
Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

Drivers: hv: vmbus: Don't wait after requesting offers

2015-08-06T23:32:01+00:00

commit 73cffdb65e679b98893f484063462c045adcf212 upstream.

Don't wait after sending request for offers to the host. This wait is
unnecessary and simply adds 5 seconds to the boot time.

Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman 
[bwh: Backported to 3.2: deleted variable t was declared as int]
Signed-off-by: Ben Hutchings

Drivers: hv: vmbus: Fix a bug in the error path in vmbus_open()

2015-08-06T23:31:59+00:00

commit 40384e4bbeb9f2651fe9bffc0062d9f31ef625bf upstream.

Correctly rollback state if the failure occurs after we have handed over
the ownership of the buffer to the host.

Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

Drivers: hv: vmbus: incorrect device name is printed when child device is unregistered

2015-03-06T00:39:19+00:00

commit 84672369ffb98a51d4ddf74c20a23636da3ad615 upstream.

Whenever a device is unregistered in vmbus_device_unregister (drivers/hv/vmbus_drv.c), the device name in the log message may contain garbage as the memory has already been freed by the time pr_info is called. Log example:
 [ 3149.170475] hv_vmbus: child device àõsèè0_5 unregistered

By logging the message just before calling device_unregister, the correct device name is printed:
[ 3145.034652] hv_vmbus: child device vmbus_0_5 unregistered

Also changing register & unregister messages to debug to avoid unnecessarily cluttering the kernel log.

Signed-off-by: Fernando M Soto 
Signed-off-by: K. Y. Srinivasan 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

Drivers: hv: vmbus: Cleanup hv_post_message()

2014-12-14T16:23:44+00:00

commit b29ef3546aecb253a5552b198cef23750d56e1e4 upstream.

Minimize failures in this function by pre-allocating the buffer
for posting messages. The hypercall for posting the message can fail
for a number of reasons:

        1. Transient resource related issues
        2. Buffer alignment
        3. Buffer cannot span a page boundry

We address issues 2 and 3 by preallocating a per-cpu page for the buffer.
Transient resource related failures are handled by retrying by the callers
of this function.

This patch is based on the investigation
done by Dexuan Cui .

I would like to thank Sitsofe Wheeler 
for reporting the issue and helping in debuggging.

Signed-off-by: K. Y. Srinivasan 
Reported-by: Sitsofe Wheeler 
Tested-by: Sitsofe Wheeler 
Signed-off-by: Greg Kroah-Hartman 
[bwh: Backported to 3.2:
 - s/NR_CPUS/MAX_NUM_CPUS/
 - Adjust context, indentation
 - Also free the page in hv_synic_init() error path]
Signed-off-by: Ben Hutchings

Drivers: hv: vmbus: Cleanup vmbus_close_internal()

2014-12-14T16:23:44+00:00

commit 98d731bb064a9d1817a6ca9bf8b97051334a7cfe upstream.

Eliminate calls to BUG_ON() in vmbus_close_internal().
We have chosen to potentially leak memory, than crash the guest
in case of failures.

In this version of the patch I have addressed comments from
Dan Carpenter (dan.carpenter@oracle.com).

Signed-off-by: K. Y. Srinivasan 
Tested-by: Sitsofe Wheeler 
Signed-off-by: Greg Kroah-Hartman 
[bwh: Backported to 3.2: function is extern; don't change the return
 type to int as callers will ignore the value]
Signed-off-by: Ben Hutchings

Drivers: hv: vmbus: Fix a bug in vmbus_open()

2014-12-14T16:23:43+00:00

commit 45d727cee9e200f5b351528b9fb063b69cf702c8 upstream.

Fix a bug in vmbus_open() and properly propagate the error. I would
like to thank Dexuan Cui  for identifying the
issue.

Signed-off-by: K. Y. Srinivasan 
Tested-by: Sitsofe Wheeler 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

Drivers: hv: vmbus: Cleanup vmbus_establish_gpadl()

2014-12-14T16:23:43+00:00

commit 72c6b71c245dac8f371167d97ef471b367d0b66b upstream.

Eliminate the call to BUG_ON() by waiting for the host to respond. We are
trying to reclaim the ownership of memory that was given to the host and so
we will have to wait until the host responds.

Signed-off-by: K. Y. Srinivasan 
Tested-by: Sitsofe Wheeler 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings

Drivers: hv: vmbus: Cleanup vmbus_teardown_gpadl()

2014-12-14T16:23:43+00:00

commit 66be653083057358724d56d817e870e53fb81ca7 upstream.

Eliminate calls to BUG_ON() by properly handling errors. In cases where
rollback is possible, we will return the appropriate error to have the
calling code decide how to rollback state. In the case where we are
transferring ownership of the guest physical pages to the host,
we will wait for the host to respond.

Signed-off-by: K. Y. Srinivasan 
Tested-by: Sitsofe Wheeler 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Ben Hutchings