linux-stable.git/drivers/hsi/controllers, branch v6.5.2

HSI: omap_ssi_port: Drop error checking for debugfs_create_dir

2023-05-27T16:50:27+00:00

This patch fixes the error checking in omap_ssi_port.c. The DebugFS
kernel API is developed in a way that the caller can safely ignore the
errors that occur during the creation of DebugFS nodes.

Signed-off-by: Osama Muhammad 
Signed-off-by: Sebastian Reichel

HSI: fix ssi_waketest() declaration

2023-05-20T17:20:30+00:00

The ssi_waketest() function definition causes a 'make W=1' warning
because the declaration is hidden away in ssi_protocol.c:

drivers/hsi/controllers/omap_ssi_core.c:147:6: error: no previous prototype for 'ssi_waketest'

Move it into a header file instead.

Fixes: dc7bf5d71868 ("HSI: Introduce driver for SSI Protocol")
Signed-off-by: Arnd Bergmann 
Reviewed-by: Kees Cook 
Signed-off-by: Sebastian Reichel

HSI: omap_ssi_core: Fix error handling in ssi_init()

2022-11-25T00:04:21+00:00

The ssi_init() returns the platform_driver_register() directly without
checking its return value, if platform_driver_register() failed, the
ssi_pdriver is not unregistered.
Fix by unregister ssi_pdriver when the last platform_driver_register()
failed.

Fixes: 0fae198988b8 ("HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module")
Signed-off-by: Yuan Can 
Signed-off-by: Sebastian Reichel

HSI: omap_ssi_core: fix possible memory leak in ssi_probe()

2022-11-17T21:49:39+00:00

If ssi_add_controller() returns error, it should call hsi_put_controller()
to give up the reference that was set in hsi_alloc_controller(), so that
it can call hsi_controller_release() to free controller and ports that
allocated in hsi_alloc_controller().

Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Yang Yingliang 
Signed-off-by: Sebastian Reichel

HSI: omap_ssi_core: fix unbalanced pm_runtime_disable()

2022-11-14T20:45:13+00:00

In error label 'out1' path in ssi_probe(), the pm_runtime_enable()
has not been called yet, so pm_runtime_disable() is not needed.

Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Yang Yingliang 
Signed-off-by: Sebastian Reichel

HSI: omap_ssi_port: Fix dma_map_sg error check

2022-08-29T16:08:48+00:00

dma_map_sg return 0 on error, in case of error return -EIO
to caller.

Cc: Sebastian Reichel 
Cc: linux-kernel@vger.kernel.org (open list)
Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Jack Wang 
Signed-off-by: Sebastian Reichel

HSI: omap_ssi: Fix refcount leak in ssi_probe

2022-08-29T16:08:48+00:00

When returning or breaking early from a
for_each_available_child_of_node() loop, we need to explicitly call
of_node_put() on the child node to possibly release the node.

Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Miaoqian Lin 
Signed-off-by: Sebastian Reichel

HSI: Fix PM usage counter unbalance in ssi_hw_init

2020-12-29T22:57:06+00:00

pm_runtime_get_sync will increment pm usage counter
even it failed. Forgetting to putting operation will
result in reference leak here. We fix it by replacing
it with pm_runtime_resume_and_get to keep usage counter
balanced.

Fixes: b209e047bc743 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Zhang Qilong 
Signed-off-by: Sebastian Reichel

HSI: omap_ssi: Don't jump to free ID in ssi_add_controller()

2020-11-28T23:39:29+00:00

In current code, it jumps to ida_simple_remove() when ida_simple_get()
failes to allocate an ID. Just return to fix it.

Fixes: 0fae198988b8 ("HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module")
Signed-off-by: Jing Xiangfeng 
Signed-off-by: Sebastian Reichel

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva