linux-stable.git/drivers/hsi/controllers, branch v4.19.321

HSI: omap_ssi_core: Fix error handling in ssi_init()

2023-01-18T10:30:30+00:00

[ Upstream commit 3ffa9f713c39a213a08d9ff13ab983a8aa5d8b5d ]

The ssi_init() returns the platform_driver_register() directly without
checking its return value, if platform_driver_register() failed, the
ssi_pdriver is not unregistered.
Fix by unregister ssi_pdriver when the last platform_driver_register()
failed.

Fixes: 0fae198988b8 ("HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module")
Signed-off-by: Yuan Can 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

HSI: omap_ssi_core: fix possible memory leak in ssi_probe()

2023-01-18T10:30:29+00:00

[ Upstream commit 1aff514e1d2bd47854dbbdf867970b9d463d4c57 ]

If ssi_add_controller() returns error, it should call hsi_put_controller()
to give up the reference that was set in hsi_alloc_controller(), so that
it can call hsi_controller_release() to free controller and ports that
allocated in hsi_alloc_controller().

Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Yang Yingliang 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

HSI: omap_ssi_core: fix unbalanced pm_runtime_disable()

2023-01-18T10:30:29+00:00

[ Upstream commit f5181c35ed7ba0ceb6e42872aad1334d994b0175 ]

In error label 'out1' path in ssi_probe(), the pm_runtime_enable()
has not been called yet, so pm_runtime_disable() is not needed.

Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Yang Yingliang 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

HSI: omap_ssi_port: Fix dma_map_sg error check

2022-10-26T11:19:30+00:00

[ Upstream commit 551e325bbd3fb8b5a686ac1e6cf76e5641461cf2 ]

dma_map_sg return 0 on error, in case of error return -EIO
to caller.

Cc: Sebastian Reichel 
Cc: linux-kernel@vger.kernel.org (open list)
Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Jack Wang 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

HSI: omap_ssi: Fix refcount leak in ssi_probe

2022-10-26T11:19:30+00:00

[ Upstream commit 9a2ea132df860177b33c9fd421b26c4e9a0a9396 ]

When returning or breaking early from a
for_each_available_child_of_node() loop, we need to explicitly call
of_node_put() on the child node to possibly release the node.

Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
Signed-off-by: Miaoqian Lin 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

HSI: omap_ssi: Don't jump to free ID in ssi_add_controller()

2020-12-30T10:25:57+00:00

[ Upstream commit 41fff6e19bc8d6d8bca79ea388427c426e72e097 ]

In current code, it jumps to ida_simple_remove() when ida_simple_get()
failes to allocate an ID. Just return to fix it.

Fixes: 0fae198988b8 ("HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module")
Signed-off-by: Jing Xiangfeng 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

headers: separate linux/mod_devicetable.h from linux/platform_device.h

2018-07-07T15:52:26+00:00

At over 4000 #includes,  is the 9th most
#included header file in the Linux kernel.  It does not need
, so drop that header and explicitly add
 to source files that need it.

   4146 #include 

After this patch, there are 225 files that use ,
for a reduction of around 3900 times that 
does not have to be read & parsed.

    225 #include 

This patch was build-tested on 20 different arch-es.

It also makes these drivers SubmitChecklist#1 compliant.

Signed-off-by: Randy Dunlap 
Reported-by: kbuild test robot  # drivers/media/platform/vimc/
Reported-by: kbuild test robot  # drivers/pinctrl/pinctrl-u300.c
Signed-off-by: Greg Kroah-Hartman

HSI: omap_ssi_core: fix kilo to be "k" not "K"

2017-10-01T15:19:50+00:00

Kilo should be "k" not "K", fix it it comments and messages.

Signed-off-by: Pavel Machek 

index 88e48b3..41a09f5 100644

Signed-off-by: Sebastian Reichel

HSI: omap_ssi: Delete an error message for a failed memory allocation in ssi_add_controller()

2017-06-08T11:21:43+00:00

The script "checkpatch.pl" pointed information out like the following.

WARNING: Possible unnecessary 'out of memory' message

Thus remove such a statement here.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring 
Signed-off-by: Sebastian Reichel

HSI: omap_ssi: Fix a typo in a comment line

2017-06-08T11:21:43+00:00

Add a missing character in this description for a function call.

Signed-off-by: Markus Elfring 
Signed-off-by: Sebastian Reichel