linux-stable.git/drivers/hsi/controllers, branch linux-3.17.y

HSI: omap_ssi: Fix return value check in ssi_debug_add_ctrl()

2014-07-30T22:20:33+00:00

In case of error, the function debugfs_create_*() returns NULL
pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test
in the return value check should be replaced with NULL test.

Signed-off-by: Wei Yongjun 
Signed-off-by: Sebastian Reichel

HSI: omap_ssi_port: Fix return value check in ssi_debug_add_port()

2014-07-30T22:20:21+00:00

In case of error, the function debugfs_create_*() returns NULL
pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test
in the return value check should be replaced with NULL test.

Signed-off-by: Wei Yongjun 
Signed-off-by: Sebastian Reichel

drivers/hsi/controllers/omap_ssi{,_port}.c: fix failure checks

2014-07-17T20:45:28+00:00

1.

[linux-3.16-rc5/drivers/hsi/controllers/omap_ssi.c:357]: (style) Checking if
unsigned variable 'gdd_irq' is less than zero.

Source code is

    omap_ssi->gdd_irq = platform_get_irq_byname(pd, "gdd_mpu");
    if (omap_ssi->gdd_irq < 0) {

2.

[linux-3.16-rc5/drivers/hsi/controllers/omap_ssi_port.c:1017]: (style) Checking
if unsigned variable 'irq' is less than zero.

Source code is

    omap_port->irq = platform_get_irq(pd, 0);
    if (omap_port->irq < 0) {

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80441
Reported-by: David Binderman 
Signed-off-by: Andrey Utkin 
Signed-off-by: Sebastian Reichel

hsi: omap_ssi_port: use normal module refcounting

2014-06-04T22:59:05+00:00

The ref_module() function is used for internal housekeeping of the
module code, it's not normally used by subsystems or device drivers,
and the use of ref_module in the omap_ssi_port driver causes a link
build error when modules are disabled:

hsi/controllers/omap_ssi_port.c: In function 'ssi_port_probe':
hsi/controllers/omap_ssi_port.c:1119:2: error: implicit declaration of function 'ref_module' [-Werror=implicit-function-declaration]

This changes the omap_ssi_port driver to use try_module_get()
and module_put() instead, which is the normal way to ensure that
the driver providing a device used in another module does not
go away.

Signed-off-by: Arnd Bergmann 
Cc: Sebastian Reichel 
Cc: Carlos Chinea 
Cc: Ivaylo Dimitrov 
Signed-off-by: Sebastian Reichel

HSI: Introduce OMAP SSI driver

2014-05-15T22:54:51+00:00

Add OMAP SSI driver to the HSI subsystem.

The Synchronous Serial Interface (SSI) is a legacy version
of HSI. As in the case of HSI, it is mainly used to connect
Application engines (APE) with cellular modem engines (CMT)
in cellular handsets.

It provides a multichannel, full-duplex, multi-core communication
with no reference clock. The OMAP SSI block is capable of reaching
speeds of 110 Mbit/s.

Signed-off-by: Carlos Chinea 
Signed-off-by: Sebastian Reichel 
Tested-By: Ivaylo Dimitrov