linux-stable.git/drivers/hid/hidraw.c, branch linux-3.7.y

HID: hidraw: put old deallocation mechanism in place

2012-11-01T10:33:26+00:00

This basically reverts commit 4fe9f8e203fda. It causes multiple problems,
namely:

- after rmmod/modprobe cycle of bus driver, the input is not claimed any
  more. This is likely because of misplaced hid_hw_close()
- it causes memory corruption on hidraw_list

As original patch author is not responding to requests to fix his patch,
and the original deallocation mechanism is not exposing any problems, I
am reverting back to it.

Signed-off-by: Jiri Kosina

Merge branch 'upstream' into for-linus

2012-10-01T12:37:51+00:00

Conflicts:
	drivers/hid/usbhid/hid-quirks.c

HID: hidraw: don't deallocate memory when it is in use

2012-10-01T08:27:36+00:00

When a device is unplugged, wait for all processes that have opened the device
to close before deallocating the device.

Signed-off-by: Ratan Nalumasu 
Signed-off-by: Jiri Kosina

HID: hidraw: improve error handling in hidraw_init()

2012-08-15T19:37:09+00:00

Several improvements in error handling:
- do not report success if alloc_chrdev_region() failed
- check for error code of cdev_add()
- use unregister_chrdev_region() instead of unregister_chrdev()
  if class_create() failed

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Jiri Kosina

HID: hidraw: fix list->buffer memleak

2012-07-20T08:02:23+00:00

If we don't read fast enough hidraw device, hidraw_report_event
will cycle and we will leak list->buffer.
Also list->buffer are not free on release.
After this patch, kmemleak report nothing.

Signed-off-by: Matthieu CASTET 
Signed-off-by: Jiri Kosina

HID: hidraw: add proper error handling to raw event reporting

2012-04-27T18:10:09+00:00

If kmemdup() in hidraw_report_event() fails, we are not propagating
this fact properly.

Let hidraw_report_event() and hid_report_raw_event() return an error
value to the caller.

Reported-by: Oliver Neukum 
Signed-off-by: Jiri Kosina

Merge branch 'upstream' into for-linus

2011-10-25T07:59:04+00:00

Conflicts:
	drivers/hid/hid-core.c
	drivers/hid/hid-ids.h

HID: hidraw: open count should not increase if error

2011-09-27T16:42:22+00:00

In hidraw_open, if hid_hw_power returns with error, hidraw device open count
should not increase.

Signed-off-by: Amit Nagal 
Signed-off-by: Jiri Kosina

HID: hidraw: protect hidraw_disconnect() better

2011-09-20T13:23:46+00:00

The function hidraw_disconnect() only acquires the hidraw minors_lock
when clearing the entry in hidraw_table. However the device_destroy()
call can cause a userland read/write to return with an error. It may
cause the program to release the file descripter before the disconnect
is finished. hidraw_disconnect() has already set hidraw->exist to 0,
which makes hidraw_release() kfree the hidraw structure, which
hidraw_disconnect() continues to access and even tries to kfree again.
Similarly if a hidraw_release() occurs after setting hidraw->exist to 0,
the same thing can happen.

This is fixed by expanding the mutex critical section to cover the whole
function from setting hidraw->exist to 0 to freeing the hidraw
structure, preventing a hidraw_release() from interfering.

Signed-off-by: James Hogan 
Tested-by: David Herrmann 
Signed-off-by: Jiri Kosina

HID: hidraw: free list for all error in hidraw_open

2011-09-07T11:48:47+00:00

In function hidraw_open struct hidraw_list *list should be freed for
all error conditions.

Signed-off-by: Amit Nagal 
Signed-off-by: Jiri Kosina