linux-stable.git/drivers/hid/hid-multitouch.c, branch linux-4.13.y

HID: multitouch: do not blindly set EV_KEY or EV_ABS bits

2017-07-13T14:48:29+00:00

Now that input core insists on having dev->absinfo when device claims to
generate EV_ABS in its dev->evbit, we should not be blindly setting that
bit.

The code in question might have been needed before input_set_abs_params()
started setting EV_ABS in device's evbit, but not anymore, and is now
breaking devices such as SMART SPNL-6075 Touchscreen.

Fixes: 6ecfe51b4082 ("Input: refuse to register absolute devices ...")
Reported-by: Matthias Fend 
Tested-by: Matthias Fend 
Cc: stable@vger.kernel.org
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Dmitry Torokhov 
Signed-off-by: Jiri Kosina

HID: multitouch: optimize the sticky fingers timer

2017-06-23T08:16:17+00:00

Instead of unconditionally expiring the timer and calling a long
mt_release_contacts(), we can check if some slots are used when the
timer expires.

We can also remove the timer if we happen to receive all the releases.

The logic behind the MT_IO_FLAGS_PENDING_SLOTS could be implemented by
counting how many slots are active, but using bits feels slightly more
efficient.

Signed-off-by: Benjamin Tissoires 
Tested-by: Arek Burdach 
Signed-off-by: Jiri Kosina

HID: multitouch: fix rare Win 8 cases when the touch up event gets missing

2017-06-23T08:16:16+00:00

Instead of blindly trusting the hardware to send us release, we should
consider some events can get lost and release them when we judge time has
come.

The Windows 8 spec allows to be confident in the fact that the device
will continuously report events when a finger touches the surface.
This has been tested on the HID recording database I have, and all of
those devices behave properly.
Also, Arek tested it on his Lenovo Yoga 910, which exports such bug in
some situations, when the movements are rather slow.

We use an atomic bit here to guard against concurrent accesses to the mt
slots because both mt_process_mt_event() and mt_expired_timeout() are
called in interrupt context.

Signed-off-by: Arek Burdach 
Signed-off-by: Benjamin Tissoires 
Tested-by: Arek Burdach 
Signed-off-by: Jiri Kosina

HID: multitouch: use BIT macro

2017-06-23T08:16:16+00:00

(1 << X) is wrong. We should use BIT(X)

Signed-off-by: Benjamin Tissoires 
Tested-by: Arek Burdach 
Signed-off-by: Jiri Kosina

HID: multitouch: Add support for Google Rose Touchpad

2017-06-21T09:31:23+00:00

Add Google Rose Touchpad USB PID and required quirks.

Signed-off-by: Wei-Ning Huang 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: multitouch: Support PTP Stick and Touchpad device

2017-06-21T09:29:30+00:00

Support PTP Stick and Touchpad device. This Touchpad is Precision Touchpad
(PTP), and Stick Pointer data is the same as Mouse; Stick Pointer works as
Mouse.

[jkosina@suse.cz: changelog deuglification]
Signed-off-by: Masaki Ota 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: multitouch: change for touch height/width

2017-03-06T13:48:32+00:00

Quoting  from Jonathan Clarke in previous thread(2017/01/24):

"This division by 2 was added along with the touch width/height fields 6 years
ago so that those fields 'match the visual scale of the touch' for a specific
device (3M PCT)" "The scaling is also discarding information about touch size
(1 bit for each of width/height) which is useful for any application that wants
to know about it."

Jonathan mentioned just what I thought in a new project recently.  It dosen't
make sense to discard 1 bit width/height in general case according to the spec
in multi-touch-protocol.txt so I would like to make a slight change here.

A quirk MT_QUIRK_TOUCH_SIZE_SCALING was added to service devices like 3M PCT
with a special visual scale and the division by 2 only take effect with devices
like that.

[jkosina@suse.cz: reformat changelog]
Signed-off-by: HungNien Chen 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: multitouch: fix LG Melfas touchscreen

2017-02-03T13:45:57+00:00

The LG Melfas touchscreen has a bad firmware where it declares the Contact ID
field as constant while it shouldn't. This messes up the autodetection and the
reporting of the events by hid-multitouch given that hid-input ignores constant
fields.

The autodetection is simply worked around by manually adding the device to
hid_have_special_driver[].

The processing of the events requires either a report fixup, or some specific
case handling. Given that the report fixup would require to basically rewrite
all the report descriptor, I went for the programatic way of fixing that after
the report descriptors are loaded.

Link: https://bugzilla.redhat.com/show_bug.cgi?id=1416181
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

Merge branches 'for-4.10/asus', 'for-4.10/cp2112', 'for-4.10/i2c-hid-nopower', 'for-4.10/intel-ish', 'for-4.10/mayflash', 'for-4.10/microsoft-surface-3', 'for-4.10/multitouch', 'for-4.10/sony', 'for-4.10/udraw-ps3', 'for-4.10/upstream' and 'for-4.10/wacom/generic' into for-linus

2016-12-14T09:12:26+00:00

HID: multitouch: do not retrieve all reports for all devices

2016-11-28T13:39:58+00:00

We already have in place a quirk for Windows 8 devices, but it looks
like the Surface Cover are not conforming to it.
Given that we are only interested in 3 feature reports (the ones that
the Windows driver retrieves), we should be safe to unconditionally apply
the quirk to everybody.

In case there is an issue with a controller, we can always mark it as such
in the transport driver, and hid-multitouch won't try to retrieve the
feature report.

Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina