linux-stable.git/drivers/hid/hid-hyperv.c, branch linux-6.2.y

Merge branch 'for-6.2/hyperv' into for-linus

2022-12-13T13:32:07+00:00

- functionally equivalent code cleanups for hyperv driver (Paulo Miguel Almeida)

HID: hyperv: fix possible memory leak in mousevsc_probe()

2022-11-02T13:34:56+00:00

If hid_add_device() returns error, it should call hid_destroy_device()
to free hid_dev which is allocated in hid_allocate_device().

Fixes: 74c4fb058083 ("HID: hv_mouse: Properly add the hid device")
Signed-off-by: Yang Yingliang 
Reviewed-by: Wei Liu 
Signed-off-by: Jiri Kosina

HID: hyperv: remove unused struct synthhid_msg

2022-10-24T13:28:35+00:00

struct synthhid_msg was meant to be a generic representation of the
possible protocol messages sent through VMBus. In practice, only the
header is read and depending on the message type, a cast to the actual
type is done. Also, SYNTHHID_MAX_INPUT_REPORT_SIZE constant isn't used
which I suspect is a leftover from the refactoring made while this
driver was at the staging folder.

This patch removes struct synthhid_msg and refactor the code
accordingly.

Signed-off-by: Paulo Miguel Almeida 
Reviewed-by: Michael Kelley 
Signed-off-by: Jiri Kosina

HID: hyperv: Replace one-element array with flexible-array member

2022-10-18T12:55:37+00:00

One-element arrays are deprecated, and we are replacing them with
flexible array members instead. So, replace one-element array with
flexible-array member in structs synthhid_msg, synthhid_input_report,
pipe_prt_msg and refactor the rest of the code accordingly.

This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
routines on memcpy() and help us make progress towards globally
enabling -fstrict-flex-arrays=3 [1].

Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/KSPP/linux/issues/210
Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101836 [1]

Signed-off-by: Paulo Miguel Almeida 
Reviewed-by: Benjamin Tissoires 
Reviewed-by: Michael Kelley 
Signed-off-by: Jiri Kosina

HID: hyperv: Correctly access fields declared as __le16

2022-06-08T12:28:13+00:00

Add the use of le16_to_cpu() for fields declared as __le16. Because
Hyper-V only runs in Little Endian mode, there's no actual bug.
The change is made in the interest of general correctness in
addition to making sparse happy. No functional change.

Reported-by: kernel test robot 
Signed-off-by: Michael Kelley 
Link: https://lore.kernel.org/r/1654660177-115463-1-git-send-email-mikelley@microsoft.com
Signed-off-by: Wei Liu

HID: hyperv: Use VMBUS_RING_SIZE() for ringbuffer sizes

2020-09-28T08:57:28+00:00

For a Hyper-V vmbus, the size of the ringbuffer has two requirements:

1) it has to take one PAGE_SIZE for the header

2) it has to be PAGE_SIZE aligned so that double-mapping can work

VMBUS_RING_SIZE() could calculate a correct ringbuffer size which
fulfills both requirements, therefore use it to make sure vmbus work
when PAGE_SIZE != HV_HYP_PAGE_SIZE (4K).

Note that since the argument for VMBUS_RING_SIZE() is the size of
payload (data part), so it will be minus 4k (the size of header when
PAGE_SIZE = 4k) than the original value to keep the ringbuffer total
size unchanged when PAGE_SIZE = 4k.

Signed-off-by: Boqun Feng 
Cc: Jiri Kosina 
Cc: Michael Kelley 
Reviewed-by: Michael Kelley 
Link: https://lore.kernel.org/r/20200916034817.30282-10-boqun.feng@gmail.com
Signed-off-by: Wei Liu

HID: hyperv: NULL check before some freeing functions is not needed.

2020-03-05T14:17:11+00:00

Fix below warnings reported by coccicheck:
drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is not needed.
drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is not needed.

Signed-off-by: Lucas Tanure 
Reviewed-by: Michael Kelley 
Reviewed-by: Wei Liu 
Acked-by: Benjamin Tissoires 
Signed-off-by: Wei Liu

HID: hyperv: Add the support of hibernation

2019-11-22T01:10:45+00:00

During the suspend process and resume process, if there is any mouse
event, there is a small chance the suspend and the resume process can be
aborted because of mousevsc_on_receive() -> pm_wakeup_hard_event().

This behavior can be avoided by disabling the Hyper-V mouse device as
a wakeup source:

echo disabled > /sys/bus/vmbus/drivers/hid_hyperv/XXX/power/wakeup
(XXX is the device's GUID).

Signed-off-by: Dexuan Cui 
Acked-by: Jiri Kosina 
Signed-off-by: Sasha Levin

HID: hyperv: Use in-place iterator API in the channel callback

2019-10-01T18:49:41+00:00

Simplify the ring buffer handling with the in-place API.

Also avoid the dynamic allocation and the memory leak in the channel
callback function.

Signed-off-by: Dexuan Cui 
Acked-by: Jiri Kosina 
Signed-off-by: Sasha Levin

HID: hv: Remove dependencies on PAGE_SIZE for ring buffer

2019-09-03T00:26:25+00:00

Define the ring buffer size as a constant expression because it should
not depend on the guest page size.

Signed-off-by: Maya Nakamura 
Reviewed-by: Michael Kelley 
Acked-by: Jiri Kosina 
Signed-off-by: Sasha Levin