linux-stable.git/drivers/gpu, branch v5.0.9

drm/amdkfd: use init_mqd function to allocate object for hid_mqd (CI)

2019-04-20T07:17:04+00:00

[ Upstream commit cac734c2dbd2514f14c8c6a17caba1990d83bf1d ]

if use the legacy method to allocate object, when mqd_hiq need to run
uninit code, it will be cause WARNING call trace.

eg: (s3 suspend test)
[   34.918944] Call Trace:
[   34.918948]  [] dump_stack+0x19/0x1b
[   34.918950]  [] __warn+0xd8/0x100
[   34.918951]  [] warn_slowpath_null+0x1d/0x20
[   34.918991]  [] uninit_mqd_hiq_sdma+0x4e/0x50 [amdgpu]
[   34.919028]  [] uninitialize+0x37/0xe0 [amdgpu]
[   34.919064]  [] kernel_queue_uninit+0x16/0x30 [amdgpu]
[   34.919086]  [] pm_uninit+0x12/0x20 [amdgpu]
[   34.919107]  [] stop_nocpsch+0x15/0x20 [amdgpu]
[   34.919129]  [] kgd2kfd_suspend.part.4+0x2e/0x50 [amdgpu]
[   34.919150]  [] kgd2kfd_suspend+0x17/0x20 [amdgpu]
[   34.919171]  [] amdgpu_amdkfd_suspend+0x1a/0x20 [amdgpu]
[   34.919187]  [] amdgpu_device_suspend+0x88/0x3a0 [amdgpu]
[   34.919189]  [] ? enqueue_entity+0x2ef/0xbe0
[   34.919205]  [] amdgpu_pmops_suspend+0x20/0x30 [amdgpu]
[   34.919207]  [] pci_pm_suspend+0x6f/0x150
[   34.919208]  [] ? pci_pm_freeze+0xf0/0xf0
[   34.919210]  [] dpm_run_callback+0x46/0x90
[   34.919212]  [] __device_suspend+0xfb/0x2a0
[   34.919213]  [] async_suspend+0x1f/0xa0
[   34.919214]  [] async_run_entry_fn+0x3f/0x130
[   34.919216]  [] process_one_work+0x17f/0x440
[   34.919217]  [] worker_thread+0x126/0x3c0
[   34.919218]  [] ? manage_workers.isra.25+0x2a0/0x2a0
[   34.919220]  [] kthread+0xd1/0xe0
[   34.919221]  [] ? insert_kthread_work+0x40/0x40
[   34.919222]  [] ret_from_fork_nospec_begin+0x7/0x21
[   34.919224]  [] ? insert_kthread_work+0x40/0x40
[   34.919224] ---[ end trace 38cd9f65c963adad ]---

Signed-off-by: Kevin Wang 
Reviewed-by: Oak Zeng 
Signed-off-by: Alex Deucher 
Signed-off-by: Sasha Levin

drm/nouveau/volt/gf117: fix speedo readout register

2019-04-20T07:17:04+00:00

[ Upstream commit fc782242749fa4235592854fafe1a1297583c1fb ]

GF117 appears to use the same register as GK104 (but still with the
general Fermi readout mechanism).

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108980
Signed-off-by: Ilia Mirkin 
Signed-off-by: Ben Skeggs 
Signed-off-by: Sasha Levin

drm/panel: panel-innolux: set display off in innolux_panel_unprepare

2019-04-20T07:17:03+00:00

[ Upstream commit 46f3ceaffa81e846677bca8668e0ad40e643cffd ]

Move mipi_dsi_dcs_set_display_off() from innolux_panel_disable()
to innolux_panel_unprepare(), so they are consistent with
innolux_panel_enable() and innolux_panel_prepare().

This also fixes some mode check and irq timeout issue in MTK dsi code.

Since some dsi code (e.g. mtk_dsi) have following call trace:
1. drm_panel_disable(), which calls innolux_panel_disable()
2. switch to cmd mode
3. drm_panel_unprepare(), which calls innolux_panel_unprepare()

However, mtk_dsi needs to be in cmd mode to be able to send commands
(e.g. mipi_dsi_dcs_set_display_off() and mipi_dsi_dcs_enter_sleep_mode()),
so we need these functions to be called after the switch to cmd mode happens,
i.e. in innolux_panel_unprepare.

Signed-off-by: Hsin-Yi, Wang 
Signed-off-by: Sean Paul 
Link: https://patchwork.freedesktop.org/patch/msgid/20190109065922.231753-1-hsinyi@chromium.org
Signed-off-by: Sasha Levin

drm/amdgpu: psp_ring_destroy cause psp->km_ring.ring_mem NULL

2019-04-20T07:17:03+00:00

[ Upstream commit 14d20ec7f31ef96a2e7dcf7880b13dde1d473b56 ]

psp_ring_destroy inside psp_load_fw cause psp->km_ring.ring_mem NULL.
Call Trace occurred when psp_cmd_submit.
should be psp_ring_stop instead.

Reviewed-by: Xiangliang Yu 
Signed-off-by: Wentao Lou 
Signed-off-by: Alex Deucher 
Signed-off-by: Sasha Levin

drm/nouveau/debugfs: Fix check of pm_runtime_get_sync failure

2019-04-20T07:17:02+00:00

[ Upstream commit 909e9c9c428376e2a43d178ed4b0a2d5ba9cb7d3 ]

pm_runtime_get_sync returns negative on failure.

Fixes: eaeb9010bb4b ("drm/nouveau/debugfs: Wake up GPU before doing any reclocking")
Signed-off-by: YueHaibing 
Signed-off-by: Ben Skeggs 
Signed-off-by: Sasha Levin

drm/exynos/mixer: fix MIXER shadow registry synchronisation code

2019-04-20T07:16:58+00:00

[ Upstream commit 6a3b45ada960ac475ec2b4103d43e57943b2b8d3 ]

MIXER on Exynos5 SoCs uses different synchronisation method than Exynos4
to update internal state (shadow registers).
Apparently the driver implements it incorrectly. The rule should be
as follows:
- do not request updating registers until previous request was finished,
  ie. MXR_CFG_LAYER_UPDATE_COUNT must be 0.
- before setting registers synchronisation on VSYNC should be turned off,
  ie. MXR_STATUS_SYNC_ENABLE should be reset,
- after finishing MXR_STATUS_SYNC_ENABLE should be set again.
The patch hopefully implements it correctly.
Below sample kernel log from page fault caused by the bug:

[   25.670038] exynos-sysmmu 14650000.sysmmu: 14450000.mixer: PAGE FAULT occurred at 0x2247b800
[   25.677888] ------------[ cut here ]------------
[   25.682164] kernel BUG at ../drivers/iommu/exynos-iommu.c:450!
[   25.687971] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
[   25.693778] Modules linked in:
[   25.696816] CPU: 5 PID: 1553 Comm: fb-release_test Not tainted 5.0.0-rc7-01157-g5f86b1566bdd #136
[   25.705646] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree)
[   25.711710] PC is at exynos_sysmmu_irq+0x1c0/0x264
[   25.716470] LR is at lock_is_held_type+0x44/0x64

v2: added missing MXR_CFG_LAYER_UPDATE bit setting in mixer_enable_sync

Reported-by: Marian Mihailescu 
Signed-off-by: Andrzej Hajda 
Signed-off-by: Inki Dae 
Signed-off-by: Sasha Levin

drm/udl: use drm_gem_object_put_unlocked.

2019-04-20T07:16:46+00:00

[ Upstream commit 8f3b487685b2acf71b42bb30d68fd9271bec8695 ]

When Daniel removed struct_mutex he didn't fix this call to the unlocked
variant which is required since we no longer use struct mutex.

This fixes a bunch of:
WARNING: CPU: 4 PID: 1370 at drivers/gpu/drm/drm_gem.c:931 drm_gem_object_put+0x2b/0x30 [drm]
Modules linked in: udl xt_CHECKSUM ipt_MASQUERADE tun bridge stp llc nf_conntrack_netbios_ns nf_conntrack_broadcast xt_CT ip6t>
CPU: 4 PID: 1370 Comm: Xorg Not tainted 5.0.0+ #2

backtraces when you plug in a udl device.

Fixes: ae358dacd217 (drm/udl: Get rid of dev->struct_mutex usage)
Reviewed-by: Daniel Vetter 
Cc: Sean Paul 
Signed-off-by: Dave Airlie 
Signed-off-by: Sasha Levin

drm/virtio: do NOT reuse resource ids

2019-04-17T06:39:54+00:00

commit 16065fcdd19ddb9e093192914ac863884f308766 upstream.

Bisected guest kernel changes crashing qemu.  Landed at
"6c1cd97bda drm/virtio: fix resource id handling".  Looked again, and
noticed we where not only leaking *some* ids, but *all* ids.  The old
code never ever called virtio_gpu_resource_id_put().

So, commit 6c1cd97bda effectively makes the linux kernel starting
re-using IDs after releasing them, and apparently virglrenderer can't
deal with that.  Oops.

This patch puts a temporary stopgap into place for the 5.0 release.

Signed-off-by: Gerd Hoffmann 
Reviewed-by: Dave Airlie 
Signed-off-by: Dave Airlie 
Link: https://patchwork.freedesktop.org/patch/msgid/20190208140409.15280-1-kraxel@redhat.com
Signed-off-by: Greg Kroah-Hartman

drm/i915/dp: revert back to max link rate and lane count on eDP

2019-04-17T06:39:50+00:00

commit 21635d7311734d2d1b177f8a95e2f9386174b76d upstream.

Commit 7769db588384 ("drm/i915/dp: optimize eDP 1.4+ link config fast
and narrow") started to optize the eDP 1.4+ link config, both per spec
and as preparation for display stream compression support.

Sadly, we again face panels that flat out fail with parameters they
claim to support. Revert, and go back to the drawing board.

v2: Actually revert to max params instead of just wide-and-slow.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109959
Fixes: 7769db588384 ("drm/i915/dp: optimize eDP 1.4+ link config fast and narrow")
Cc: Ville Syrjälä 
Cc: Manasi Navare 
Cc: Rodrigo Vivi 
Cc: Matt Atwood 
Cc: "Lee, Shawn C" 
Cc: Dave Airlie 
Cc: intel-gfx@lists.freedesktop.org
Cc:  # v5.0+
Reviewed-by: Rodrigo Vivi 
Reviewed-by: Manasi Navare 
Tested-by: Albert Astals Cid  # v5.0 backport
Tested-by: Emanuele Panigati  # v5.0 backport
Tested-by: Matteo Iervasi  # v5.0 backport
Signed-off-by: Jani Nikula 
Link: https://patchwork.freedesktop.org/patch/msgid/20190405075220.9815-1-jani.nikula@intel.com
(cherry picked from commit f11cb1c19ad0563b3c1ea5eb16a6bac0e401f428)
Signed-off-by: Rodrigo Vivi 
Signed-off-by: Greg Kroah-Hartman

drm/udl: add a release method and delay modeset teardown

2019-04-17T06:39:48+00:00

commit 9b39b013037fbfa8d4b999345d9e904d8a336fc2 upstream.

If we unplug a udl device, the usb callback with deinit the
mode_config struct, however userspace will still have an open
file descriptor and a framebuffer on that device. When userspace
closes the fd, we'll oops because it'll try and look stuff up
in the object idr which we've destroyed.

This punts destroying the mode objects until release time instead.

Cc: stable@vger.kernel.org
Reviewed-by: Daniel Vetter 
Signed-off-by: Dave Airlie 
Link: https://patchwork.freedesktop.org/patch/msgid/20190405031715.5959-2-airlied@gmail.com
Signed-off-by: Greg Kroah-Hartman