linux-stable.git/drivers/gpu/drm/xe/xe_pcode.c, branch linux-6.10.y

drm/xe: Fix the warning conditions

2024-09-08T05:56:30+00:00

[ Upstream commit 4c0be90e6874b8af30541c37689780fc7c8276c9 ]

The maximum timeout display uses in xe_pcode_request is 3 msec, add the
warning in cases the function is misused with higher timeouts.

Add a warning if pcode_try_request is not passed the timeout parameter
greater than 0.

Cc: Lucas De Marchi 
Cc: Rodrigo Vivi 
Signed-off-by: Himal Prasad Ghimiray 
Reviewed-by: Lucas De Marchi 
Link: https://patchwork.freedesktop.org/patch/msgid/20240508152216.3263109-3-himal.prasad.ghimiray@intel.com
Signed-off-by: Rodrigo Vivi 
Signed-off-by: Sasha Levin

drm/xe: Change pcode timeout to 50msec while polling again

2024-05-28T06:53:24+00:00

Polling is initially attempted with timeout_base_ms enabled for
preemption, and if it exceeds this timeframe, another attempt is made
without preemption, allowing an additional 50 ms before timing out.

v2
- Rebase

v3
- Move warnings to separate patch (Lucas)

Cc: Lucas De Marchi 
Cc: Rodrigo Vivi 
Signed-off-by: Himal Prasad Ghimiray 
Fixes: 7dc9b92dcfef ("drm/xe: Remove i915_utils dependency from xe_pcode.")
Reviewed-by: Lucas De Marchi 
Link: https://patchwork.freedesktop.org/patch/msgid/20240508152216.3263109-2-himal.prasad.ghimiray@intel.com
Signed-off-by: Rodrigo Vivi 
(cherry picked from commit c81858eb52266b3d6ba28ca4f62a198231a10cdc)
Signed-off-by: Thomas Hellström

drm/xe: check pcode init status only on root gt of root tile

2024-04-10T16:32:15+00:00

The root tile indicates the pcode initialization is complete
when all tiles have completed their initialization.
So the mailbox can be polled only on the root tile.
Check pcode init status only on root tile and move it to
device probe early as root tile is initialized there.
Also make similar changes in resume paths.

v2: add lock/unlocked version of pcode_mailbox_rw
    to allow pcode init to be called in device
    early probe (Rodrigo)

v3: add code description about using root tile
    change function names to xe_pcode_probe_early
    and xe_pcode_init (Rodrigo)

Signed-off-by: Riana Tauro 
Reviewed-by: Rodrigo Vivi 
Reviewed-by: Himal Prasad Ghimiray 
Link: https://patchwork.freedesktop.org/patch/msgid/20240410085005.1126343-2-riana.tauro@intel.com
Signed-off-by: Rodrigo Vivi

drm/xe: Use USEC_PER_MSEC rather than the hard coding

2024-03-21T13:00:54+00:00

Use USEC_PER_MSEC rather than the hard coded value of 1000.

Static analyzer Reported "casting either timeout_ms or
1000U to type u64" to avoid overflow-before-widen.
Using USEC_PER_MSEC seems better and will help with static analyzer
report cleanup.

Cc: Rodrigo Vivi 
Signed-off-by: Himal Prasad Ghimiray 
Reviewed-by: Rodrigo Vivi 
Link: https://patchwork.freedesktop.org/patch/msgid/20240320083325.3258720-1-himal.prasad.ghimiray@intel.com
Signed-off-by: Lucas De Marchi

drm/xe: add skip_pcode flag

2023-12-21T16:45:09+00:00

Per device, set this flag to enable access to the PCODE uC or to skip it.

Signed-off-by: Koby Elbaz 
Reviewed-by: Rodrigo Vivi 
Signed-off-by: Rodrigo Vivi

drm/xe: Ensure mutex are destroyed

2023-12-21T16:41:21+00:00

Add missing mutex_destroy calls to fini functions or convert to
drmm_mutex_init where fini function is not available.

Cc: Matthew Brost 
Signed-off-by: Bommithi Sakeena 
Reviewed-by: Niranjana Vishwanathapura 
Signed-off-by: Rodrigo Vivi

drm/xe: Invert mask and val in xe_mmio_wait32.

2023-12-21T16:39:15+00:00

The order: 'offset, mask, val'; is more common in other
drivers and in special in i915, where any dev could copy
a sequence and end up with unexpected behavior.

Done with coccinelle:
@rule1@
expression gt, reg, val, mask, timeout, out, atomic;
@@
- xe_mmio_wait32(gt, reg, val, mask, timeout, out, atomic)
+ xe_mmio_wait32(gt, reg, mask, val, timeout, out, atomic)

spatch -sp_file mmio.cocci *.c *.h compat-i915-headers/intel_uncore.h \
       --in-place

v2: Rebased after changes on xe_guc_mcr usage of xe_mmio_wait32.

Reviewed-by: Matthew Brost 
Signed-off-by: Rodrigo Vivi

drm/xe: Cleanup style warnings

2023-12-21T16:37:31+00:00

Reduce the number of warnings reported by checkpatch.pl from 118 to 48 by
addressing those warnings types:

  LEADING_SPACE
  LINE_SPACING
  BRACES
  TRAILING_SEMICOLON
  CONSTANT_COMPARISON
  BLOCK_COMMENT_STYLE
  RETURN_VOID
  ONE_SEMICOLON
  SUSPECT_CODE_INDENT
  LINE_CONTINUATIONS
  UNNECESSARY_ELSE
  UNSPECIFIED_INT
  UNNECESSARY_INT
  MISORDERED_TYPE

Signed-off-by: Francois Dugast 
Reviewed-by: Matthew Brost 
Signed-off-by: Rodrigo Vivi

drm/xe/mmio: Use struct xe_reg

2023-12-19T23:33:49+00:00

Convert all the callers to deal with xe_mmio_*() using struct xe_reg
instead of plain u32. In a few places there was also a rename
s/reg/reg_val/ when dealing with the value returned so it doesn't get
mixed up with the register address.

Reviewed-by: Rodrigo Vivi 
Link: https://lore.kernel.org/r/20230508225322.2692066-2-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi 
Signed-off-by: Rodrigo Vivi

drm/xe: Only request PCODE_WRITE_MIN_FREQ_TABLE on LLC platforms

2023-12-19T23:31:41+00:00

PCODE_WRITE_MIN_FREQ_TABLE is only applicable to platforms with an LLC.
Change the discrete GPU check to an LLC check instead; this take care of
skipping not only the discrete platforms, but also integrated platforms
like MTL that do not have an LLC.

Fixes MTL dmesg error:

  xe 0000:00:02.0: [drm] *ERROR* PCODE Mailbox failed: 1 Illegal Command

Reviewed-by: Lucas De Marchi 
Link: https://lore.kernel.org/r/20230410183910.2696628-3-matthew.d.roper@intel.com
Signed-off-by: Matt Roper 
Signed-off-by: Rodrigo Vivi