linux-stable.git/drivers/gpu/drm/vkms, branch linux-6.17.y

drm/vkms: convert to use faux_device

2025-07-07T13:24:03+00:00

The vkms driver does not need to create a platform device, as there is
no real platform resources associated it,  it only did so because it was
simple to do that in order to get a device to use for resource
management of drm resources.  Change the driver to use the faux device
instead as this is NOT a real platform device.

Tested-by: Louis Chauvet 
Reviewed-by: Louis Chauvet 
Reviewed-by: Thomas Zimmermann 
Cc: Haneen Mohammed 
Cc: Simona Vetter 
Cc: Melissa Wen 
Cc: Maarten Lankhorst 
Cc: Maxime Ripard 
Cc: David Airlie 
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Lyude Paul 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Thomas Zimmermann 
Link: https://lore.kernel.org/r/2025070147-antics-pleat-edd2@gregkh

drm: Simplify drmm_alloc_ordered_workqueue return

2025-07-03T17:14:56+00:00

Rather than returning ERR_PTR or NULL on failure, replace the NULL
return with ERR_PTR(-ENOMEM). This simplifies error handling at the
caller. While here, add kernel documentation for
drmm_alloc_ordered_workqueue.

Cc: Louis Chauvet 
Signed-off-by: Matthew Brost 
Reviewed-by: Louis Chauvet 
Link: https://lore.kernel.org/r/20250702232831.3271328-2-matthew.brost@intel.com

drm/vkms: Compile all tests with CONFIG_DRM_VKMS_KUNIT_TEST

2025-06-13T17:11:39+00:00

The Kconfig option `CONFIG_DRM_VKMS_KUNIT_TESTS` does not exist. However,
the VKMS format tests use such an option for compilation, meaning that
they are not compiled at all.

Use the Kconfig option `CONFIG_DRM_VKMS_KUNIT_TEST` to compile all VKMS
KUnit tests.

Fixes: 3e897853debd ("drm/vkms: Create KUnit tests for YUV conversions")
Signed-off-by: Maíra Canal 
Reviewed-by: José Expósito 
Link: https://lore.kernel.org/r/20250611205704.334527-1-mcanal@igalia.com
Signed-off-by: Louis Chauvet

drm/vkms: Add support for DRM_FORMAT_R*

2025-05-28T14:19:15+00:00

This add the support for:
- R1/R2/R4/R8

R1 format was tested with [1] and [2].

[1]: https://lore.kernel.org/r/20240313-new_rotation-v2-0-6230fd5cae59@bootlin.com
[2]: https://lore.kernel.org/igt-dev/20240306-b4-kms_tests-v1-0-8fe451efd2ac@bootlin.com/

Reviewed-by: Pekka Paalanen 
Acked-by: Maxime Ripard 
Link: https://lore.kernel.org/r/20250415-yuv-v18-8-f2918f71ec4b@bootlin.com
Signed-off-by: Louis Chauvet

drm/vkms: Create KUnit tests for YUV conversions

2025-05-28T14:19:14+00:00

Create KUnit tests to test the conversion between YUV and RGB. Test each
conversion and range combination with some common colors.

The code used to compute the expected result can be found in comment.

[Louis Chauvet:
- fix minor formating issues (whitespace, double line)
- change expected alpha from 0x0000 to 0xffff
- adapt to the new get_conversion_matrix usage
- apply the changes from Arthur
- move struct pixel_yuv_u8 to the test itself]

Signed-off-by: Arthur Grillo 
Acked-by: Pekka Paalanen 
Acked-by: Maxime Ripard 
Link: https://lore.kernel.org/r/20250415-yuv-v18-6-f2918f71ec4b@bootlin.com
Signed-off-by: Louis Chauvet

drm/vkms: Add range and encoding properties to the plane

2025-05-28T14:19:14+00:00

Now that the driver internally handles these quantization ranges and YUV
encoding matrices, expose the UAPI for setting them.

Signed-off-by: Arthur Grillo 
[Louis Chauvet: retained only relevant parts, updated the commit message]
Acked-by: Pekka Paalanen 
Acked-by: Maxime Ripard 
Link: https://lore.kernel.org/r/20250415-yuv-v18-3-f2918f71ec4b@bootlin.com
Signed-off-by: Louis Chauvet

drm/vkms: Add YUV support

2025-05-28T14:19:13+00:00

Add support to the YUV formats bellow:

- NV12/NV16/NV24
- NV21/NV61/NV42
- YUV420/YUV422/YUV444
- YVU420/YVU422/YVU444

The conversion from yuv to rgb is done with fixed-point arithmetic, using
32.32 fixed-point numbers and the drm_fixed helpers.

To do the conversion, a specific matrix must be used for each color range
(DRM_COLOR_*_RANGE) and encoding (DRM_COLOR_*). This matrix is stored in
the `conversion_matrix` struct, along with the specific y_offset needed.
This matrix is queried only once, in `vkms_plane_atomic_update` and
stored in a `vkms_plane_state`. Those conversion matrices of each
encoding and range were obtained by rounding the values of the original
conversion matrices multiplied by 2^32. This is done to avoid the use of
floating point operations.

The same reading function is used for YUV and YVU formats. As the only
difference between those two category of formats is the order of field, a
simple swap in conversion matrix columns allows using the same function.

[Louis Chauvet:
- Adapted Arthur's work
- Implemented the read_line_t callbacks for yuv
- add struct conversion_matrix
- store the whole conversion_matrix in the plane state
- remove struct pixel_yuv_u8
- update the commit message
- Merge the modifications from Arthur]

Signed-off-by: Arthur Grillo 
Acked-by: Maxime Ripard 
Link: https://lore.kernel.org/r/20250415-yuv-v18-2-f2918f71ec4b@bootlin.com
Signed-off-by: Louis Chauvet

drm/vkms: Document pixel_argb_u16

2025-05-28T14:19:13+00:00

The meaning of each member of the structure was not specified. To clarify
the format used and the reason behind those choices, add some
documentation.

Reviewed-by: Pekka Paalanen 
Link: https://lore.kernel.org/r/20250415-yuv-v18-1-f2918f71ec4b@bootlin.com
Signed-off-by: Louis Chauvet

drm/vkms: Adjust vkms_state->active_planes allocation type

2025-05-06T08:17:00+00:00

In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "struct vkms_plane_state **", but the returned type
will be "struct drm_plane **". These are the same size (pointer size), but
the types don't match. Adjust the allocation type to match the assignment.

Signed-off-by: Kees Cook 
Reviewed-by: Louis Chauvet 
Fixes: 8b1865873651 ("drm/vkms: totally reworked crc data tracking")
Link: https://lore.kernel.org/r/20250426061431.work.304-kees@kernel.org
Signed-off-by: Louis Chauvet

Merge drm/drm-next into drm-misc-next

2025-04-07T12:35:48+00:00

Backmerging to get v6.15-rc1 into drm-misc-next. Also fixes a
build issue when enabling CONFIG_DRM_SCHED_KUNIT_TEST.

Signed-off-by: Thomas Zimmermann