linux-stable.git/drivers/gpu/drm/vc4, branch linux-4.5.y

drm/vc4: Return -EFAULT on copy_from_user() failure

2016-04-12T14:33:40+00:00

commit 585cb132a48190b554aecda2ebc3e2911fcbb665 upstream.

The copy_from_user() function returns the number of bytes not copied but
we want to return a negative error code.

Fixes: 463873d57014 ('drm/vc4: Add an API for creating GPU shaders in GEM BOs.')
Signed-off-by: Dan Carpenter 
Reviewed-by: Eric Anholt 
Signed-off-by: Eric Anholt 
Signed-off-by: Greg Kroah-Hartman

drm/vc4: Use runtime PM to power cycle the device when the GPU hangs.

2016-02-16T20:21:01+00:00

This gets us functional GPU reset again, like we had until a refactor
at merge time.  Tested with a little patch to stuff in a broken binner
job every 100 frames.

Signed-off-by: Eric Anholt

drm/vc4: Enable runtime PM.

2016-02-16T20:21:00+00:00

This may actually get us a feature that the closed driver didn't have:
turning off the GPU in between rendering jobs, while the V3D device is
still opened by the client.

There may be some tuning to be applied here to use autosuspend so that
we don't bounce the device's power so much, but in steady-state
GPU-bound rendering we keep the power on (since we keep multiple jobs
outstanding) and even if we power cycle on every job we can still
manage at least 680 fps.

More importantly, though, runtime PM will allow us to power off the
device to do a GPU reset.

v2: Switch #ifdef to CONFIG_PM not CONFIG_PM_SLEEP (caught by kbuild
    test robot)

Signed-off-by: Eric Anholt

drm/vc4: Fix spurious GPU resets due to BO reuse.

2016-02-16T20:21:00+00:00

We were tracking the "where are the head pointers pointing" globally,
so if another job reused the same BOs and execution was at the same
point as last time we checked, we'd stop and trigger a reset even
though the GPU had made progress.

Signed-off-by: Eric Anholt

drm/vc4: Drop error message on seqno wait timeouts.

2016-02-16T20:20:59+00:00

These ioctls end up getting exposed to fairly directly to GL users,
and having normal user operations print DRM errors is obviously wrong.
The message was originally to give us some idea of what happened when
a hang occurred, but we have a DRM_INFO from reset for that.

Signed-off-by: Eric Anholt

drm/vc4: Fix -ERESTARTSYS error return from BO waits.

2016-02-16T20:20:59+00:00

This caused the wait ioctls to claim that waiting had completed when
we actually got interrupted by a signal before it was done.  Fixes
broken rendering throttling that produced serious lag in X window
dragging.

Signed-off-by: Eric Anholt

drm/vc4: Return an ERR_PTR from BO creation instead of NULL.

2016-02-16T20:20:58+00:00

Fixes igt vc4_create_bo/create-bo-0 by returning -EINVAL from the
ioctl instead of -ENOMEM.

Signed-off-by: Eric Anholt

drm/vc4: Fix the clear color for the first tile rendered.

2016-02-16T20:20:58+00:00

Apparently in hardware (as opposed to simulation), the clear colors
need to be uploaded before the render config, otherwise they won't
take effect.  Fixes igt's vc4_wait_bo/used-bo-* subtests.

Signed-off-by: Eric Anholt

drm/vc4: Validate that WAIT_BO padding is cleared.

2016-02-16T20:20:57+00:00

This is ABI future-proofing if we ever want to extend the pad to mean
something.

Signed-off-by: Eric Anholt

Merge tag 'drm-vc4-fixes-2015-01-19' of http://github.com/anholt/linux into drm-fixes

2016-01-29T00:02:35+00:00

This pull request just includes the !CONFIG_PM_SLEEP build fix for
vc4.

* tag 'drm-vc4-fixes-2015-01-19' of http://github.com/anholt/linux:
  drm/vc4: Remove broken attempt at GPU reset using genpd.