linux-stable.git/drivers/gpu/drm/tilcdc, branch linux-3.17.y

drm/tilcdc: Fix the error path in tilcdc_load()

2014-11-14T18:10:27+00:00

commit b478e336b3e75505707a11e78ef8b964ef0a03af upstream.

The current error path calls tilcdc_unload() in case of an error to release
the resources. However, this is wrong because not all resources have been
allocated by the time an error occurs in tilcdc_load().

To fix it, this commit adds proper labels to bail out at the different
stages in the load function, and release only the resources actually allocated.

Tested-by: Darren Etheridge 
Tested-by: Johannes Pointner 
Signed-off-by: Ezequiel Garcia 
Signed-off-by: Dave Airlie 
Fixes: 3a49012224ca ("drm/tilcdc: panel: fix leak when unloading the module")
Signed-off-by: Matwey V. Kornilov 
Signed-off-by: Greg Kroah-Hartman

drm/tilcdc: Fix build breakage

2014-07-10T02:01:38+00:00

Commit 34ea3d386347 ("drm: add register and unregister functions
for connectors") probably missed out converting the
drm_sysfs_connector_remove instances in the following files.
Without this patch we get the following compilation error:
ERROR: "drm_sysfs_connector_remove" [drivers/gpu/drm/tilcdc/tilcdc.ko] undefined!

Signed-off-by: Sachin Kamat 
CC: Thomas Wood 
CC: David Herrmann 
CC: Daniel Vetter 
Signed-off-by: Dave Airlie

drm/tilcdc: oops a Module.symvers snuck in

2014-07-09T01:05:08+00:00

remove it.

Signed-off-by: Dave Airlie

drm/tilcdc: replace late_initcall with module_init

2014-07-08T01:25:37+00:00

Use module_init instead of late_initcall, as is the norm for modular
drivers.

module_init was used until 6e8de0bd6a51fdeebd5d975c4fcc426f730b339b
("drm/tilcdc: add encoder slave (v2)") changed it to a late_initcall,
but it does not explain why. Tests show it's working properly with
module_init.

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Signed-off-by: Dave Airlie

drm/tilcdc: remove submodule destroy calls

2014-07-08T01:25:32+00:00

The TI tilcdc driver is designed with a notion of submodules. Currently,
at unload time, these submodules are iterated and destroyed.

Now that the tilcdc remove order is fixed, this can be handled perfectly
by the kernel using the device infrastructure, since each submodule
is a kernel driver itself, and they are only destroy()'ed at unload
time. Therefore we move the destroy() functionality to each submodule's
remove().

Also, remove some checks in the unloading process since the new code
guarantees the resources are allocated and need a release.

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Signed-off-by: Dave Airlie

drm/tilcdc: fix double kfree

2014-07-08T01:25:26+00:00

display_timings_release calls kfree on the display_timings object passed
to it. Calling kfree after it is wrong. SLUB debug showed the following
warning:

    =============================================================================
    BUG kmalloc-64 (Tainted: G        W    ): Object already free
    -----------------------------------------------------------------------------

    Disabling lock debugging due to kernel taint
    INFO: Allocated in of_get_display_timings+0x2c/0x214 age=601 cpu=0
    pid=884
     __slab_alloc.constprop.79+0x2e0/0x33c
     kmem_cache_alloc+0xac/0xdc
     of_get_display_timings+0x2c/0x214
     panel_probe+0x7c/0x314 [tilcdc]
     platform_drv_probe+0x18/0x48
     [..snip..]
    INFO: Freed in panel_destroy+0x18/0x3c [tilcdc] age=0 cpu=0 pid=907
     __slab_free+0x34/0x330
     panel_destroy+0x18/0x3c [tilcdc]
     tilcdc_unload+0xd0/0x118 [tilcdc]
     drm_dev_unregister+0x24/0x98
     [..snip..]

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Cc:  #v3.9+
Signed-off-by: Dave Airlie

drm/tilcdc: fix release order on exit

2014-07-08T01:25:21+00:00

Unregister resources in the correct order on tilcdc_drm_fini, which is
the reverse order they were registered during tilcdc_drm_init.

This also means unregistering the driver before releasing its resources.

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Cc:  #v3.9+
Signed-off-by: Dave Airlie

drm/tilcdc: panel: fix leak when unloading the module

2014-07-08T01:25:14+00:00

The driver did not unregister the allocated framebuffer, which caused
memory leaks (and memory manager WARNs) when unloading. Also, the
framebuffer device under /dev still existed after unloading.

Add a call to drm_fbdev_cma_fini when unloading the module to prevent
both issues.

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Cc:  #v3.9+
Signed-off-by: Dave Airlie

drm/tilcdc: tfp410: fix dangling sysfs connector node

2014-07-08T01:25:08+00:00

Add a drm_sysfs_connector_remove call when we destroy the panel to make
sure the connector node in sysfs gets deleted.

This is required for proper unload and re-load of this driver, otherwise
we will get a warning about a duplicate filename in sysfs.

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Cc:  #v3.9+
Signed-off-by: Dave Airlie

drm/tilcdc: slave: fix dangling sysfs connector node

2014-07-08T01:24:57+00:00

Add a drm_sysfs_connector_remove call when we destroy the panel to make
sure the connector node in sysfs gets deleted.

This is required for proper unload and re-load of this driver as a
module. Without this, we would get a warning at re-load time like so:

   tda998x 0-0070: found TDA19988
   ------------[ cut here ]------------
   WARNING: CPU: 0 PID: 825 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x54/0x74()
   sysfs: cannot create duplicate filename '/class/drm/card0-HDMI-A-1'
   Modules linked in: [..]
   CPU: 0 PID: 825 Comm: modprobe Not tainted 3.15.0-rc4-00027-g9dcdef4 #82
   [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
   [] (show_stack) from [] (warn_slowpath_common+0x68/0x88)
   [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40)
   [] (warn_slowpath_fmt) from [] (sysfs_warn_dup+0x54/0x74)
   [] (sysfs_warn_dup) from [] (sysfs_do_create_link_sd.isra.2+0xb0/0xb8)
   [] (sysfs_do_create_link_sd.isra.2) from [] (device_add+0x338/0x520)
   [] (device_add) from [] (device_create_groups_vargs+0xa0/0xc4)
   [] (device_create_groups_vargs) from [] (device_create+0x24/0x2c)
   [] (device_create) from [] (drm_sysfs_connector_add+0x64/0x204)
   [] (drm_sysfs_connector_add) from [] (slave_modeset_init+0x120/0x1bc [tilcdc])
   [] (slave_modeset_init [tilcdc]) from [] (tilcdc_load+0x214/0x4c0 [tilcdc])
   [] (tilcdc_load [tilcdc]) from [] (drm_dev_register+0xa4/0x104)
      [..snip..]
   ---[ end trace 4df8d614936ebdee ]---
   [drm:drm_sysfs_connector_add] *ERROR* failed to register connector device: -17

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Cc:  #v3.9+
Signed-off-by: Dave Airlie