linux-stable.git/drivers/gpu/drm/tilcdc, branch linux-3.14.y

drm/tilcdc: Fix the error path in tilcdc_load()

2014-11-14T16:59:53+00:00

commit b478e336b3e75505707a11e78ef8b964ef0a03af upstream.

The current error path calls tilcdc_unload() in case of an error to release
the resources. However, this is wrong because not all resources have been
allocated by the time an error occurs in tilcdc_load().

To fix it, this commit adds proper labels to bail out at the different
stages in the load function, and release only the resources actually allocated.

Tested-by: Darren Etheridge 
Tested-by: Johannes Pointner 
Signed-off-by: Ezequiel Garcia 
Signed-off-by: Dave Airlie 
Fixes: 3a49012224ca ("drm/tilcdc: panel: fix leak when unloading the module")
Signed-off-by: Matwey V. Kornilov 
Signed-off-by: Greg Kroah-Hartman

drm/tilcdc: fix double kfree

2014-10-05T21:52:09+00:00

commit c9a3ad25eddfdb898114a9d73cdb4c3472d9dfca upstream.

display_timings_release calls kfree on the display_timings object passed
to it. Calling kfree after it is wrong. SLUB debug showed the following
warning:

    =============================================================================
    BUG kmalloc-64 (Tainted: G        W    ): Object already free
    -----------------------------------------------------------------------------

    Disabling lock debugging due to kernel taint
    INFO: Allocated in of_get_display_timings+0x2c/0x214 age=601 cpu=0
    pid=884
     __slab_alloc.constprop.79+0x2e0/0x33c
     kmem_cache_alloc+0xac/0xdc
     of_get_display_timings+0x2c/0x214
     panel_probe+0x7c/0x314 [tilcdc]
     platform_drv_probe+0x18/0x48
     [..snip..]
    INFO: Freed in panel_destroy+0x18/0x3c [tilcdc] age=0 cpu=0 pid=907
     __slab_free+0x34/0x330
     panel_destroy+0x18/0x3c [tilcdc]
     tilcdc_unload+0xd0/0x118 [tilcdc]
     drm_dev_unregister+0x24/0x98
     [..snip..]

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Signed-off-by: Dave Airlie 
Signed-off-by: Greg Kroah-Hartman

drm/tilcdc: fix release order on exit

2014-10-05T21:52:08+00:00

commit eb565a2bbadc6a5030a6dbe58db1aa52453e7edf upstream.

Unregister resources in the correct order on tilcdc_drm_fini, which is
the reverse order they were registered during tilcdc_drm_init.

This also means unregistering the driver before releasing its resources.

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Signed-off-by: Dave Airlie 
Signed-off-by: Greg Kroah-Hartman

drm/tilcdc: panel: fix leak when unloading the module

2014-10-05T21:52:08+00:00

commit 3a49012224ca9016658a831a327ff6a7fe5bb4f9 upstream.

The driver did not unregister the allocated framebuffer, which caused
memory leaks (and memory manager WARNs) when unloading. Also, the
framebuffer device under /dev still existed after unloading.

Add a call to drm_fbdev_cma_fini when unloading the module to prevent
both issues.

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Signed-off-by: Dave Airlie 
Signed-off-by: Greg Kroah-Hartman

drm/tilcdc: tfp410: fix dangling sysfs connector node

2014-10-05T21:52:08+00:00

commit 16dcbdef404f4e87dab985494381939fe0a2d456 upstream.

Add a drm_sysfs_connector_remove call when we destroy the panel to make
sure the connector node in sysfs gets deleted.

This is required for proper unload and re-load of this driver, otherwise
we will get a warning about a duplicate filename in sysfs.

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Signed-off-by: Dave Airlie 
Signed-off-by: Greg Kroah-Hartman

drm/tilcdc: slave: fix dangling sysfs connector node

2014-10-05T21:52:08+00:00

commit daa15b4cd1eee58eb1322062a3320b1dbe5dc96e upstream.

Add a drm_sysfs_connector_remove call when we destroy the panel to make
sure the connector node in sysfs gets deleted.

This is required for proper unload and re-load of this driver as a
module. Without this, we would get a warning at re-load time like so:

   tda998x 0-0070: found TDA19988
   ------------[ cut here ]------------
   WARNING: CPU: 0 PID: 825 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x54/0x74()
   sysfs: cannot create duplicate filename '/class/drm/card0-HDMI-A-1'
   Modules linked in: [..]
   CPU: 0 PID: 825 Comm: modprobe Not tainted 3.15.0-rc4-00027-g9dcdef4 #82
   [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
   [] (show_stack) from [] (warn_slowpath_common+0x68/0x88)
   [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40)
   [] (warn_slowpath_fmt) from [] (sysfs_warn_dup+0x54/0x74)
   [] (sysfs_warn_dup) from [] (sysfs_do_create_link_sd.isra.2+0xb0/0xb8)
   [] (sysfs_do_create_link_sd.isra.2) from [] (device_add+0x338/0x520)
   [] (device_add) from [] (device_create_groups_vargs+0xa0/0xc4)
   [] (device_create_groups_vargs) from [] (device_create+0x24/0x2c)
   [] (device_create) from [] (drm_sysfs_connector_add+0x64/0x204)
   [] (drm_sysfs_connector_add) from [] (slave_modeset_init+0x120/0x1bc [tilcdc])
   [] (slave_modeset_init [tilcdc]) from [] (tilcdc_load+0x214/0x4c0 [tilcdc])
   [] (tilcdc_load [tilcdc]) from [] (drm_dev_register+0xa4/0x104)
      [..snip..]
   ---[ end trace 4df8d614936ebdee ]---
   [drm:drm_sysfs_connector_add] *ERROR* failed to register connector device: -17

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Signed-off-by: Dave Airlie 
Signed-off-by: Greg Kroah-Hartman

drm/tilcdc: panel: fix dangling sysfs connector node

2014-10-05T21:52:08+00:00

commit e396900e649b0af31161634d87fe37076f46c12b upstream.

Add a drm_sysfs_connector_remove call when we destroy the panel to make
sure the connector node in sysfs gets deleted.

This is required for proper unload and re-load of this driver as a
module. Without this, we would get a warning at re-load time like so:

   ------------[ cut here ]------------
   WARNING: CPU: 0 PID: 824 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x54/0x74()
   sysfs: cannot create duplicate filename '/class/drm/card0-LVDS-1'
   Modules linked in: [...]
   CPU: 0 PID: 824 Comm: modprobe Not tainted 3.15.0-rc4-00027-g6484f96-dirty #81
   [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
   [] (show_stack) from [] (warn_slowpath_common+0x68/0x88)
   [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40)
   [] (warn_slowpath_fmt) from [] (sysfs_warn_dup+0x54/0x74)
   [] (sysfs_warn_dup) from [] (sysfs_do_create_link_sd.isra.2+0xb0/0xb8)
   [] (sysfs_do_create_link_sd.isra.2) from [] (device_add+0x338/0x520)
   [] (device_add) from [] (device_create_groups_vargs+0xa0/0xc4)
   [] (device_create_groups_vargs) from [] (device_create+0x24/0x2c)
   [] (device_create) from [] (drm_sysfs_connector_add+0x64/0x204)
   [] (drm_sysfs_connector_add) from [] (panel_modeset_init+0xb8/0x134 [tilcdc])
   [] (panel_modeset_init [tilcdc]) from [] (tilcdc_load+0x214/0x4c0 [tilcdc])
   [] (tilcdc_load [tilcdc]) from [] (drm_dev_register+0xa4/0x104)
      [ .. snip .. ]
   ---[ end trace b2d09cd9578b0497 ]---
   [drm:drm_sysfs_connector_add] *ERROR* failed to register connector device: -17

Signed-off-by: Guido Martínez 
Tested-by: Darren Etheridge 
Signed-off-by: Dave Airlie 
Signed-off-by: Greg Kroah-Hartman

drm: store the gem vma offset manager in a typed pointer

2014-01-14T02:38:32+00:00

This was hidden in a generic void * dev->mm_private. But only ever
used for gem. But thanks to this fake generic pretension no one
noticed that Rob's drm drivers are now all broken.

So just give the offset manager a type pointer and fix up msm, omapdrm
and tilcdc.

v2: Fixup compile fail.

v3: Fixup rebase fail that David spotted.

Cc: David Herrmann 
Cc: Rob Clark 
Signed-off-by: Daniel Vetter 
Signed-off-by: Dave Airlie

drm: Kill DRM_IRQ_ARGS

2013-12-18T01:33:46+00:00

I've killed them a long time ago in drm/i915, let's get rid of this
remnant of shared drm core days for good.

Signed-off-by: Daniel Vetter 
Signed-off-by: Dave Airlie

drm/tilcdc: call drm_put_dev directly from ->remove

2013-12-18T01:05:43+00:00

tilcdc already stores the drm_device in the driver data pointer. So
use that.

Cc: Rob Clark 
Signed-off-by: Daniel Vetter 
Reviewed-by: Rob Clark 
Signed-off-by: Dave Airlie