linux-stable.git/drivers/gpu/drm/sun4i, branch v4.7.2

gpu: drm: sun4i_drv: add missing of_node_put after calling of_parse_phandle

2016-07-05T07:20:29+00:00

of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.

Cc: Maxime Ripard 
Cc: Chen-Yu Tsai 
Signed-off-by: Peter Chen 
Signed-off-by: Maxime Ripard

drm/sun4i: Send vblank event when the CRTC is disabled

2016-06-30T19:55:32+00:00

So far, we were missing to send the vblank event when disabling the CRTC,
making us never report the last vblank event.

This was causing a time out on the page flip, which should be solved now.

Signed-off-by: Maxime Ripard

drm/sun4i: Report proper vblank

2016-06-30T19:55:26+00:00

The sun4i display engine doesn't have any vblank counter. Use the proper
helper for that.

Signed-off-by: Maxime Ripard

drm: sun4i: do cleanup if RGB output init fails

2016-05-30T06:28:33+00:00

sun4i_rgb_init() can fail, which results in TCON failing to bind.
In this case we need to do cleanup, specificly unregistering the
dotclock, which is regmap based, and the regmap is registered as
part of the sun4i_tcon_bind().

Failing to do so results in a NULL pointer reference when the CCF
tries to turn off unused clocks.

Fixes: 29e57fab97fc ("drm: sun4i: Add RGB output")
Signed-off-by: Chen-Yu Tsai 
Signed-off-by: Maxime Ripard

drm/sun4i: Convert to connector register helpers

2016-05-30T06:28:33+00:00

Now that connector register helpers have been created, switch to them.

Signed-off-by: Maxime Ripard

drm/sun4i: remove simplefb at probe

2016-05-30T06:28:33+00:00

If simplefb was setup by our bootloader and enabled in the DT, we will have
a first framebuffer loaded in our system.

However, as soon as our DRM driver will load, it will reset the controller,
initialise it and, if the framebuffer emulation is enabled, register a
second framebuffer device.

This is obviously pretty bad, since the first framebuffer will be some kind
of a black hole, with memory still reserved that we can write to safely,
but not displayed anywhere.

Make sure we remove that framebuffer when we probe so we don't end up in
that situation.

Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
Signed-off-by: Maxime Ripard

drm/sun4i: rgb: panel is an error pointer

2016-05-30T06:28:33+00:00

In case of an error, our pointer to the drm_panel structure attached to our
encoder will hold an error pointer, not a NULL pointer.

Make sure we check the right thing.

Fixes: 29e57fab97fc ("drm: sun4i: Add RGB output")
Signed-off-by: Maxime Ripard

drm/sun4i: defer only if we didn't find our panel

2016-05-30T06:28:33+00:00

Our code currently defers our probe on any error, even if we were not
expecting to have one at all.

Make sure we return -EPROBE_DEFER only when we were supposed to have a
panel, but it's not probed yet.

Also fix a typo while we're at it.

Fixes: 29e57fab97fc ("drm: sun4i: Add RGB output")
Signed-off-by: Maxime Ripard

drm/sun4i: rgb: Validate the clock rate

2016-05-30T06:28:33+00:00

Our pixel clock cannot reach a high enough rate for some rather high while
common resolutions (like 1080p60).

Make sure we filter the resolutions we cannot reach in our mode_valid
function.

Fixes: 29e57fab97fc ("drm: sun4i: Add RGB output")
Signed-off-by: Maxime Ripard

drm/sun4i: request exact rates to our parents

2016-05-30T06:28:33+00:00

Our pixel clock currently only tries to deal with the current parent rate.

While that works when the resolution is the same than the one already
program, or when we can compute directly the rate from the current parent
rate, it cannot work in most situation when we want to change the
frequency, and we end up with an improper pixel clock rate, which obviously
doesn't work as expected.

Ask our parent for all the possible dividers if it can reach that
frequency, and return the best parent rate to the clock framework so that
we can use it.

Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
Signed-off-by: Maxime Ripard