linux-stable.git/drivers/gpu/drm/drm_debugfs_crc.c, branch v5.3

drm: no need to check return value of debugfs_create functions

2019-06-13T14:39:16+00:00

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Because there is no need to check these functions, a number of local
functions can be made to return void to simplify things as nothing can
fail.

Cc: Maarten Lankhorst 
Cc: Maxime Ripard 
Cc: Sean Paul 
Cc: David Airlie 
Cc: Daniel Vetter 
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Daniel Vetter 
Link: https://patchwork.freedesktop.org/patch/msgid/20190613133439.GA6715@kroah.com

drm/crc-debugfs: Also sprinkle irqrestore over early exits

2019-06-07T14:49:12+00:00

I. was. blind.

Caught with vkms, which has some really slow crc computation function.

Fixes: 1882018a70e0 ("drm/crc-debugfs: User irqsafe spinlock in drm_crtc_add_crc_entry")
Cc: Rodrigo Siqueira 
Cc: Tomeu Vizoso 
Cc: Emil Velikov 
Cc: Benjamin Gaignard 
Cc: Ville Syrjälä 
Reviewed-by: Emil Velikov 
Reviewed-by: Benjamin Gaignard 
Signed-off-by: Daniel Vetter 
Link: https://patchwork.freedesktop.org/patch/msgid/20190606211544.5389-1-daniel.vetter@ffwll.ch

drm/crc-debugfs: User irqsafe spinlock in drm_crtc_add_crc_entry

2019-06-06T09:35:14+00:00

We can be called from any context, we need to be prepared.

Noticed this while hacking on vkms, which calls this function from a
normal worker. Which really upsets lockdep.

Cc: Rodrigo Siqueira 
Cc: Tomeu Vizoso 
Cc: Emil Velikov 
Cc: Benjamin Gaignard 
Reviewed-by: Benjamin Gaignard 
Reviewed-by: Ville Syrjälä 
Signed-off-by: Daniel Vetter 
Link: https://patchwork.freedesktop.org/patch/msgid/20190605194556.16744-1-daniel.vetter@ffwll.ch

drm: drop use of drmP.h in drm/*

2019-05-27T16:07:03+00:00

The use of the drmP.h header file is deprecated.
Remove use from all files in drm/*
so people do not look there and follow a bad example.

Build tested allyesconfig,allmodconfig on x86, arm etc.
Including alpha that is as always more challenging than
the rest.

Signed-off-by: Sam Ravnborg 
Acked-by: Daniel Vetter 
Cc: Maarten Lankhorst 
Cc: Maxime Ripard 
Cc: Sean Paul 
Cc: David Airlie 
Link: https://patchwork.freedesktop.org/patch/msgid/20190526173535.32701-8-sam@ravnborg.org

Revert "drm: crc: Wait for a frame before returning from open()"

2018-08-22T16:50:16+00:00

This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680.

Don't wait for first CRC during crtc_crc_open. It avoids one frame wait
during open. If application want to wait after read call, it can use
poll/read blocking read() call.

Suggested-by: Ville Syrjälä 
Signed-off-by: Mahesh Kumar 
Cc: dri-devel@lists.freedesktop.org
Cc: Tomeu Vizoso 
Reviewed-by: Laurent Pinchart 
Reviewed-by: Maarten Lankhorst 
Signed-off-by: Rodrigo Vivi 
Link: https://patchwork.freedesktop.org/patch/msgid/20180821083858.26275-4-mahesh1.kumar@intel.com

drm/crc: Cleanup crtc_crc_open function

2018-08-22T16:47:58+00:00

This patch make changes to allocate crc-entries buffer before
enabling CRC generation.
It moves all the failure check early in the function before setting
the source or memory allocation.
Now set_crc_source takes only two variable inputs, values_cnt we
already gets as part of verify_crc_source.

Changes since V1:
 - refactor code to use single spin lock
Changes since V2:
 - rebase
Changes since V3:
 - rebase on top of VKMS driver

Signed-off-by: Mahesh Kumar 
Cc: dri-devel@lists.freedesktop.org
Cc: Laurent Pinchart 
Cc: Haneen Mohammed 
Reviewed-by: Maarten Lankhorst 
Acked-by: Leo Li  (V2)
Reviewed-by: Laurent Pinchart  (V3)
Signed-off-by: Rodrigo Vivi 
Link: https://patchwork.freedesktop.org/patch/msgid/20180821083858.26275-3-mahesh1.kumar@intel.com

drm: crc: Introduce get_crc_sources callback

2018-08-13T12:00:20+00:00

This patch introduce a callback function "get_crc_sources" which
will be called during read of control node. It is an optional
callback function and if driver implements this callback, driver
should return a constant pointer to an array of crc sources list
and update count according to the number of source in the list.

Changes Since V1: (Daniel)
 - return const pointer to an array of crc sources list
 - do validation of sources in CRC-core
Changes Since V2:
 - update commit message
 - update callback documentation
 - print one source name per line

Signed-off-by: Mahesh Kumar 
Cc: dri-devel@lists.freedesktop.org
Cc: Laurent Pinchart 
Reviewed-by: Maarten Lankhorst 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Maarten Lankhorst 
Link: https://patchwork.freedesktop.org/patch/msgid/20180713135942.25061-3-mahesh1.kumar@intel.com

drm: crc: Introduce verify_crc_source callback

2018-08-13T12:00:20+00:00

This patch adds a new callback function "verify_crc_source" which will
be used during setting the crc source in control node. This will help
in avoiding setting of wrong string for source.

Changes since V1:
 - do not yet verify_crc_source during open.
Changes since V1:
 - improve callback description

Signed-off-by: Mahesh Kumar 
Cc: dri-devel@lists.freedesktop.org
Cc: Laurent Pinchart 
Reviewed-by: Maarten Lankhorst 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Maarten Lankhorst 
Link: https://patchwork.freedesktop.org/patch/msgid/20180713135942.25061-2-mahesh1.kumar@intel.com

drm/crc: Only report a single overflow when a CRC fd is opened

2018-07-06T12:57:03+00:00

This reduces the amount of spam when you debug a CRC reading
program.

Signed-off-by: Maarten Lankhorst 
[mlankhorst: Change bool overflow to was_overflow (Ville)]
Reviewed-by: Ville Syrjälä 
Link: https://patchwork.freedesktop.org/patch/msgid/20180418125121.72081-1-maarten.lankhorst@linux.intel.com

drm/crc: Add support for polling on the data fd.

2018-02-05T12:22:44+00:00

This will make it possible for userspace to know whether reading
will block, without blocking on the fd. This makes it possible to
drain all queued CRC's in blocking mode, without having to reopen
the fd.

Signed-off-by: Maarten Lankhorst 
Link: https://patchwork.freedesktop.org/patch/msgid/20180202142743.68527-1-maarten.lankhorst@linux.intel.com
Reviewed-by: Ville Syrjälä 
[mlankhorst: Use POLLIN|POLLRDNORM, based on Ville's suggestion]