linux-stable.git/drivers/gpu/drm/amd/display/modules/inc, branch linux-5.4.y

drm/amd/display: Fix nanosec stat overflow

2024-04-13T10:51:38+00:00

[ Upstream commit 14d68acfd04b39f34eea7bea65dda652e6db5bf6 ]

[Why]
Nanosec stats can overflow on long running systems potentially causing
statistic logging issues.

[How]
Use 64bit types for nanosec stats to ensure no overflow.

Reviewed-by: Rodrigo Siqueira 
Tested-by: Daniel Wheeler 
Signed-off-by: Aric Cyr 
Signed-off-by: Alex Deucher 
Signed-off-by: Sasha Levin

drm/amd/display: Reinstate LFC optimization

2023-10-10T19:46:38+00:00

[ Upstream commit ded6119e825aaf0bfc7f2a578b549d610da852a7 ]

[why]
We want to streamline the calculations made when entering LFC.
Previously, the optimizations led to screen tearing and were backed out
to unblock development.

[how]
Integrate other calculations parameters, as well as screen tearing,
fixes with the original LFC calculation optimizations.

Signed-off-by: Amanda Liu 
Reviewed-by: Aric Cyr 
Acked-by: Rodrigo Siqueira 
Signed-off-by: Alex Deucher 
Stable-dep-of: 07e388aab042 ("drm/amd/display: prevent potential division by zero errors")
Signed-off-by: Sasha Levin

drm/amd/display: Refactoring VTEM

2019-08-23T16:41:58+00:00

[Why]
Video Timing Extended Metadata packet (VTEM) is not
specific to freesync. So move it out of freesync module

[How]
- Moved VTEM from freesync module to info_packet module
- Created new structure for VTEM parameters that can be used for VRR
and FVA

Signed-off-by: Ahmad Othman 
Reviewed-by: Chris Park 
Acked-by: Ahmad Othman 
Acked-by: Bhawanpreet Lakha 
Signed-off-by: Alex Deucher

drm/amd/display: add missing mod_vmid destructor

2019-06-22T14:34:14+00:00

mod_vmid is missing a destructor.

Signed-off-by: Dmytro Laktyushkin 
Reviewed-by: Charlene Liu 
Acked-by: Bhawanpreet Lakha 
Signed-off-by: Alex Deucher

drm/amd/display: move vmid determination logic to a module

2019-06-22T14:34:14+00:00

Currently vmid is decided internally inside dc. With the introduction
of new asics we are required to coordinate vmid use with external
components.

This change converts vmid logic to a DAL module allowing vmid to be
passed in as a parameter to DC.

Signed-off-by: Dmytro Laktyushkin 
Reviewed-by: Charlene Liu 
Acked-by: Bhawanpreet Lakha 
Signed-off-by: Alex Deucher

drm/amd/display: Integrate color transform3x4 with 3dlut tm

2019-06-22T14:34:12+00:00

[Why & How]
Reuse existent code path (dcn1+) and in order to do that apply de gamma
in 1D blender LUT and re use MPC OGAM.
Follow up is required.

Signed-off-by: Vitaly Prosyak 
Reviewed-by: Aric Cyr 
Acked-by: Bhawanpreet Lakha 
Acked-by: Krunoslav Kovac 
Acked-by: Vitaly Prosyak 
Signed-off-by: Alex Deucher

drm/amd/display: add flags for gamut map library

2019-06-22T14:34:11+00:00

[Why & How]
Gamut map lib provides a wider gamut mapping options
vs BT2390

Signed-off-by: Vitaly Prosyak 
Reviewed-by: Krunoslav Kovac 
Acked-by: Aric Cyr 
Acked-by: Bhawanpreet Lakha 
Acked-by: Vitaly Prosyak 
Signed-off-by: Alex Deucher

drm/amd/display: Add 3dlut control flags

2019-06-22T14:34:09+00:00

[Why & How]
The follow up change
Improve some naming for fields and structs

Signed-off-by: Vitaly Prosyak 
Reviewed-by: Aric Cyr 
Acked-by: Bhawanpreet Lakha 
Acked-by: Vitaly Prosyak 
Signed-off-by: Alex Deucher

drm/amd/display: Add some tm3dlut flags

2019-06-22T14:34:09+00:00

Move flags from color_gamma.h to mod_shared.h
and add more options and setting structures

Signed-off-by: Vitaly Prosyak 
Reviewed-by: Aric Cyr 
Acked-by: Bhawanpreet Lakha 
Acked-by: Vitaly Prosyak 
Signed-off-by: Alex Deucher

drm/amd/display: Pass app_tf by value rather than by reference

2019-02-28T03:23:55+00:00

Clang warns when an expression that equals zero is used as a null
pointer constant (in lieu of NULL):

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4435:3:
warning: expression which evaluates to zero treated as a null pointer
constant of type 'const enum color_transfer_func *'
[-Wnon-literal-null-conversion]
                TRANSFER_FUNC_UNKNOWN,
                ^~~~~~~~~~~~~~~~~~~~~
1 warning generated.

This warning is caused by commit bb47de736661 ("drm/amdgpu: Set FreeSync
state using drm VRR properties") and it could be solved by using NULL
instead of TRANSFER_FUNC_UNKNOWN or casting TRANSFER_FUNC_UNKNOWN as a
pointer. However, after looking into it, there doesn't appear to be a
good reason to pass app_tf by reference as it is never mutated along the
way. This is the only code path in which app_tf is used:

mod_freesync_build_vrr_infopacket ->
    build_vrr_infopacket_v2 ->
        build_vrr_infopacket_fs2_data

Neither mod_freesync_build_vrr_infopacket or build_vrr_infopacket_v2
modify app_tf's value and build_vrr_infopacket_fs2_data expects just
the value so we can avoid dereferencing anything by just passing in
app_tf's value to mod_freesync_build_vrr_infopacket and
build_vrr_infopacket_v2.

There is no functional change because build_vrr_infopacket_fs2_data
doesn't do anything if TRANSFER_FUNC_UNKNOWN is passed to it, the same
as not calling build_vrr_infopacket_fs2_data at all like before this
change when NULL was used for app_tf.

Reviewed-by: Harry Wentland 
Signed-off-by: Nathan Chancellor 
Signed-off-by: Alex Deucher