linux-stable.git/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c, branch v6.0

drm/amd/display: fix signedness bug in execute_synaptics_rc_command()

2022-07-28T20:05:16+00:00

The "ret" variable needs to be signed for the error handling to work.

Fixes: 2ca97adccdc9 ("drm/amd/display: Add Synaptics Fifo Reset Workaround")
Signed-off-by: Dan Carpenter 
Signed-off-by: Alex Deucher

drm/amd/display: Add tags for indicating mst progress status

2022-07-20T20:04:42+00:00

[Why & How]
In order to leverage igt tool to maintain mst feature, expose new
debugfs entry "mst_progress_status".

In our dm flow, record down the result of each phase of mst and user
can examine the mst result by checking whether each phase get completed
successfully.

Tested-by: Daniel Wheeler 
Reviewed-by: Hersen Wu 
Acked-by: Alan Liu 
Signed-off-by: Wayne Lin 
Signed-off-by: Alex Deucher

drm/amd/display: Release remote dc_sink under mst scenario

2022-06-21T22:17:23+00:00

[Why]
Observe that we have several problems while releasing remote dc_sink
under mst cases.

- When unplug mst branch device from the source, we now try to free all
  remote dc_sinks in dm_helpers_dp_mst_stop_top_mgr(). However, there are
  bugs while we're releasing dc_sinks here. First of all,
  link->remote_sinks[] array get shuffled within
  dc_link_remove_remote_sink(). As the result, increasing the array index
  within the releasing loop is wrong. Secondly, it tries to call
  dc_sink_release() to release the dc_sink of the same aconnector every
  time in the loop. Which can't release dc_sink of all aconnector in the
  mst topology.
- There is no code path for us to release remote dc_sink for disconnected
  sst monitor which unplug event is notified by CSN sideband message. Which
  means we'll use stale dc_sink data to represent later on connected
  monitor. Also, has chance to break the maximum remote dc_sink number
  constraint.

[How]
Distinguish unplug event of mst scenario into 2 cases.

* Unplug sst/legacy stream sink off the mst topology
- Release related remote dc_sink in detec_ctx().

* Unplug mst branch device off the mst topology
- Release related remote dc_sink in early_unregister()

Tested-by: Daniel Wheeler 
Reviewed-by: Aurabindo Jayamohanan Pillai 
Acked-by: Rodrigo Siqueira 
Acked-by: Lyude Paul 
Signed-off-by: Wayne Lin 
Signed-off-by: Alex Deucher

drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in amdgpu_dm

2022-05-10T21:53:13+00:00

[Why & How]
CONFIG_DRM_AMD_DC_DCN is used by pass the compilation failures, but DC
code should be OS-agnostic.

This patch fixes it by removing unnecessasry CONFIG_DRM_AMD_DC_DCN
in amdgpu_dm directory.

Reviewed-by: Rodrigo Siqueira 
Acked-by: Stylon Wang 
Signed-off-by: Alex Hung 
Tested-by: Daniel Wheeler 
Signed-off-by: Alex Deucher

drm/amd/display: Fix pointer dereferenced before checking

2022-04-01T03:05:53+00:00

The pointer edid_buf is dereferencing pointer edid before edid is being
 null checked. Fix this by assigning edid->raw_edid to edid_buf only if
edid is not NULL, otherwise just NULL.

Signed-off-by: Haowen Bai 
Signed-off-by: Alex Deucher

drm/amd/display: Add conditional around function

2022-02-24T22:26:16+00:00

When CONFIG_DRM_AMD_DC_DCN is not set, the function
'dm_helpers_enable_periodic_detection' doesn't have its prototype defined,
causing the following warning:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:805:6:
warning: no previous prototype for function 'dm_helpers_enable_periodic_detection' [-Wmissing-prototypes]
   void dm_helpers_enable_periodic_detection(struct dc_context *ctx, bool enable)
        ^
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:805:1:
note: declare 'static' if the function is not intended to be used outside
of this translation unit
   void dm_helpers_enable_periodic_detection(struct dc_context *ctx, bool enable)
   ^
   static
   1 warning generated.

This commit silences this warning by adding a conditional directive
around the mentioned function, and also corrects a small spelling error.

Reviewed-by: Harry Wentland 
Reported-by: kernel test robot 
Signed-off-by: Magali Lemes 
Signed-off-by: Alex Deucher

drm/amd/display: clear remote dc_sink when stop mst

2022-02-23T19:22:03+00:00

[Why]
Currently, we don't have code path to release remote dc_sink when unplug
MST hub from the system. After few times hotplug, we hit the limition of
maximum number of remote dc_sink and can't light up new connected monitor
anymore.

[How]
Releasing all remote dc_sink at dm_helpers_dp_mst_stop_top_mgr() was
removed by previous patch. Restore it.

Reviewed-by: Jerry Zuo 
Acked-by: Solomon Chiu 
Signed-off-by: Wayne Lin 
Tested-by: Daniel Wheeler 
Signed-off-by: Alex Deucher

drm/amd/display: fix spelling mistake: synatpics -> synaptics

2022-02-02T23:26:31+00:00

There are quite a few spelling mistakes in various function names
and error messages. Fix these.

Reviewed-by: Harry Wentland 
Signed-off-by: Colin Ian King 
Signed-off-by: Alex Deucher

drm/amd/display: Add DSC Enable for Synaptics Hub

2022-01-25T23:00:35+00:00

DSC sequence for non virtual dpcd synaptics hub

Tested-by: Daniel Wheeler 
Reviewed-by: Hersen Wu 
Acked-by: Rodrigo Siqueira 
Signed-off-by: Fangzhi Zuo 
Signed-off-by: Alex Deucher

drm/amd/display: Add Synaptics Fifo Reset Workaround

2022-01-25T23:00:35+00:00

Sequence to reset synaptics SDP fifo before enabling first stream

Tested-by: Daniel Wheeler 
Reviewed-by: Hersen Wu 
Acked-by: Rodrigo Siqueira 
Signed-off-by: Fangzhi Zuo 
Signed-off-by: Alex Deucher