linux-stable.git/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c, branch v5.10

drm/amd/display: fix crash/reboot while accessing sysfs files

2020-09-22T16:25:09+00:00

read/writes to aux_dpcd_* sysfs entries leads to system
reboot or hang.
Hence fix the handling of input data and reporting of errors
appropriately to the user space.

Signed-off-by: Shirish S 
Reviewed-by: Harry Wentland 
Signed-off-by: Alex Deucher

drm/amd/display: Create trigger_hotplug entry

2020-09-15T21:52:43+00:00

Add trigger_hotplug debugfs entry.

Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry")
Reviewed-by: Harry Wentland 
Signed-off-by: YueHaibing 
Signed-off-by: Alex Deucher

drm/amd/display: Fix possible memleak in dp_trigger_hotplug()

2020-09-15T21:52:43+00:00

If parse_write_buffer_into_params() fails, we should free
wr_buf before return.

Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry")
Reviewed-by: Harry Wentland 
Signed-off-by: YueHaibing 
Signed-off-by: Alex Deucher

drm/amd/display: Calculate DSC number of slices in debugfs when forced

2020-09-15T21:52:42+00:00

[why]
When comparing current DSC timing settings with enforced through
debugfs we have to calculate number of both vertical and horisontal
slices. So instead of doing that every time we should just
use number of slices rather than setting its dimensions.

[how]
In connector's dsc preferred settings structure change slice height
and slice width parameters to number of slices vertical and horisontal.
Also calculate number of slices in debugfs rather in create_stream_for_sink.

Signed-off-by: Eryk Brol 
Signed-off-by: Mikita Lipski 
Acked-by: Aurabindo Pillai 
Signed-off-by: Alex Deucher

drm/amd/display: Return the number of bytes parsed than allocated

2020-09-15T21:52:42+00:00

[why & how]
Previously we were returning the number of bytes allocated
for a write buffer from debugfs and when manually used it wouldn't
rise any errors, but it wouldn't match the size of the parameters
passed from userspace.

In successful case return the size passed by usermode otherwise
the error code is returned. That simplifies the parser helper
and removes a potential error of returning mismatched input size.

Signed-off-by: Eryk Brol 
Signed-off-by: Mikita Lipski 
Acked-by: Aurabindo Pillai 
Signed-off-by: Alex Deucher

drm/amd/display: Add trigger connector unplug

2020-09-15T21:52:41+00:00

[why]
We need a virtual tool that would emulate a physical
connector unplug to usermode, while connector is
still physically plugged in.

[how]
Added a new option to debugfs entry "trigger_hotplug".
It emulates hotplug irq handling scenario by clearing
DC and DM connector states.
It can be triggered with the following command:

	echo 0 > /sys/kernel/debug/dri/0/DP-X/trigger_hotplug

Signed-off-by: Eryk Brol 
Signed-off-by: Mikita Lipski 
Acked-by: Aurabindo Pillai 
Signed-off-by: Alex Deucher

drm/amd/display: Add DSC force disable to dsc_clock_en debugfs entry

2020-09-15T21:52:41+00:00

[why]
For debug purposes we want not to enable DSC on certain connectors
even if algorithm deesires to do so, instead it should enable DSC
on other capable connectors or fail the atomic check.

[how]
Adding the third option to connector's debugfs entry dsc_clock_en.

Accepted inputs:
     0x0 - connector is using default DSC enablement policy
     0x1 - force enable DSC on the connector, if it supports DSC
     0x2 - force disable DSC on the connector, if DSC is supported

Ex. # echo 0x2 > /sys/kernel/debug/dri/0/DP-1/dsc_clock_en

Signed-off-by: Eryk Brol 
Signed-off-by: Mikita Lipski 
Acked-by: Aurabindo Pillai 
Signed-off-by: Alex Deucher

drm/amd/display: Add connector HPD trigger debugfs entry

2020-08-26T20:40:18+00:00

[why]
Need a tool to retrigger a virtual hotplug for testing purposes with
force redetection in both DC and DM.

[how]
Emulate handle_hpd_irq for connector as if usermode would trigger
a hotplug. Perform DC link discovery, DM connector update, and
DM force atomic commit.

In order to trigger HPD on the connector user needs to echo 1 into
"trigger_hotplug" debugfs entry on its respective connector.

Signed-off-by: Eryk Brol 
Signed-off-by: Mikita Lipski 
Reviewed-by: Mikita Lipski 
Acked-by: Eryk Brol 
Signed-off-by: Alex Deucher

drm/amd/display: Add debugfs for connector's FEC & DSC capabilities

2020-08-26T20:40:18+00:00

[why & how]
Useful entry to understand if link has DSC or FEC capabilities,
implemented to read DPCD caps stored on the link. Better than
manually reading the registers with aux dpcd helper.

Signed-off-by: Eryk Brol 
Signed-off-by: Mikita Lipski 
Reviewed-by: Mikita Lipski 
Acked-by: Eryk Brol 
Signed-off-by: Alex Deucher

drm/amdgpu: Get DRM dev from adev by inline-f

2020-08-24T17:06:06+00:00

Add a static inline adev_to_drm() to obtain
the DRM device pointer from an amdgpu_device pointer.

Signed-off-by: Luben Tuikov 
Reviewed-by: Alex Deucher 
Signed-off-by: Alex Deucher