linux-stable.git/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c, branch linux-4.9.y Linux kernel stable tree drm/amdgpu: potential NULL dereference in debugfs code 2016-10-13T22:25:50+00:00 Dan Carpenter dan.carpenter@oracle.com 2016-10-12T06:17:30+00:00 eeb2fa0c97ba661f8b7fb210a1de10928b67a47b debugfs_create_file() returns NULL on error, it only returns error pointers if debugfs isn't enabled in the config and we checked for that earlier so it can't happen. Fixes: 4f4824b55650 ('drm/amd/amdgpu: Convert ring debugfs entries to binary') Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 
debugfs_create_file() returns NULL on error, it only returns error
pointers if debugfs isn't enabled in the config and we checked for that
earlier so it can't happen.

Fixes: 4f4824b55650 ('drm/amd/amdgpu: Convert ring debugfs entries to binary')
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: clear ring pointer in amdgpu_device on teardown 2016-09-27T17:00:51+00:00 Grazvydas Ignotas notasas@gmail.com 2016-09-25T20:34:47+00:00 d8907643cc6b00e96aeb1555f0e0c2930f69c18b This is in symmetry to setup done in amdgpu_ring_init. Signed-off-by: Grazvydas Ignotas <notasas@gmail.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 
This is in symmetry to setup done in amdgpu_ring_init.

Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: free the BO in kernel by helper amdgpu_bo_free_kernel() 2016-09-14T19:10:27+00:00 Junwei Zhang Jerry.Zhang@amd.com 2016-09-07T09:14:46+00:00 8640faed5a8a8f55d6decd2d9c9f35ae687b1e4c Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 
Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: use amdgpu_bo_create_kernel in amdgpu_ring.c 2016-08-08T15:32:21+00:00 Christian König christian.koenig@amd.com 2016-07-26T07:58:45+00:00 37ac235bf8c8a44c6c5aa8b03ab3d5ad23f64cef Saves us quite a bunch of code. Signed-off-by: Christian König <christian.koenig@amd.com> Reviewed-by: Chunming Zhou <david1.zhou@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 
Saves us quite a bunch of code.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: add begin/end_use ring callbacks 2016-07-29T18:37:02+00:00 Christian König christian.koenig@amd.com 2016-07-20T11:49:34+00:00 f06505b8d27119202d76aeb1b80b2ca352c9567e For manual UVD/VCE power and clock gating. Signed-off-by: Christian König <christian.koenig@amd.com> Reviewed-by: Edward O'Callaghan <funfunctor@folklore1984.net> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 
For manual UVD/VCE power and clock gating.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Edward O'Callaghan <funfunctor@folklore1984.net>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: remove fence_lock 2016-07-29T18:37:01+00:00 Christian König christian.koenig@amd.com 2016-07-19T12:44:39+00:00 7c23ace2db5217cfbe066a21d98b761321c67efd Was never used as far as I can see. Signed-off-by: Christian König <christian.koenig@amd.com> Reviewed-by: Chunming Zhou <david1.zhou@amd.com> Reviewed-by: Edward O'Callaghan <funfunctor@folklore1984.net> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 
Was never used as far as I can see.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
Reviewed-by: Edward O'Callaghan <funfunctor@folklore1984.net>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: remove more of the ring backup code 2016-07-07T19:06:19+00:00 Alex Deucher alexander.deucher@amd.com 2016-07-06T16:40:16+00:00 33b7ed0122e4da0d92d50cc226cd9db659834eaa Not used anymore. Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 
Not used anymore.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: clean up ring_backup code, no need more 2016-07-07T19:06:18+00:00 Chunming Zhou David1.Zhou@amd.com 2016-06-29T08:01:49+00:00 40019dc4a32a1083f54954a533c19534880dd3a8 Signed-off-by: Chunming Zhou <David1.Zhou@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 
Signed-off-by: Chunming Zhou <David1.Zhou@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amdgpu: fix ring debugfs bug 2016-07-07T18:51:12+00:00 Monk Liu Monk.Liu@amd.com 2016-06-14T16:02:21+00:00 a909c6bd9f9223e91b40b1c56c2c81ae504295b3 debugfs file added but not released after driver unloaded Signed-off-by: Monk Liu <Monk.Liu@amd.com> Reviewed-by: Chunming Zhou <david1.zhou@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 
debugfs file added but not released after driver unloaded

Signed-off-by: Monk Liu <Monk.Liu@amd.com>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/amdgpu: ring debugfs is read in increments of 4 bytes 2016-07-07T18:51:11+00:00 Tom St Denis tom.stdenis@amd.com 2016-05-02T12:35:35+00:00 c71dbd93eb0039838de920ae1712ff65fd648290 If a user tries to read a non-multiple of 4 bytes it would have read until the end of the ring potentially crashing the user task. Signed-off-by: Tom St Denis <tom.stdenis@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> 
If a user tries to read a non-multiple of 4 bytes it would have
read until the end of the ring potentially crashing the user
task.

Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>