linux-stable.git/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c, branch linux-5.12.y

amdgpu: fix GEM obj leak in amdgpu_display_user_framebuffer_create

2021-06-10T11:41:41+00:00

[ Upstream commit e0c16eb4b3610298a74ae5504c7f6939b12be991 ]

This error code-path is missing a drm_gem_object_put call. Other
error code-paths are fine.

Signed-off-by: Simon Ser 
Fixes: 1769152ac64b ("drm/amdgpu: Fail fb creation from imported dma-bufs. (v2)")
Cc: Alex Deucher 
Cc: Harry Wentland 
Cc: Nicholas Kazlauskas 
Cc: Bas Nieuwenhuizen 
Reviewed-by: Christian König 
Signed-off-by: Alex Deucher 
Cc: stable@vger.kernel.org
Signed-off-by: Sasha Levin

drm/amdgpu: fix r initial values

2021-05-14T08:52:09+00:00

commit 4b12ee6f426e5e36396501a58f3a1af5b92a7e06 upstream.

Sriov gets suspend of IP block  failed as return
value was not initialized.

v2: return 0 directly to align original code semantic before this
was broken out into a separate helper function instead of setting
initial values

Signed-off-by: Victor Zhao 
Reviewed-by: Alex Deucher 
Signed-off-by: Alex Deucher 
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman

drm/amdgpu: clean up non-DC suspend/resume handling

2021-03-22T19:24:23+00:00

Move the non-DC specific code into the DCE IP blocks similar
to how we handle DC.  This cleans up the common suspend
and resume pathes.

Reviewed-by: Evan Quan 
Signed-off-by: Alex Deucher

drm/amdgpu: enable freesync for A+A configs

2021-02-02T22:36:33+00:00

Some newer APUs can scanout directly from GTT, that saves us from
allocating another bounce buffer in VRAM and enables freesync in such
configurations.

Without this patch creating a framebuffer from the imported BO will
fail and userspace will fall back to a copy.

Signed-off-by: Christian König 
Reviewed-by: Shashank Sharma 
Signed-off-by: Alex Deucher

drm/amd/display: add S/G support for Vangogh

2020-12-09T04:05:54+00:00

[Why]
Scatter/gather feature is supported on Vangogh.

[How]
Add GTT domain support for Vangogh to enable
display buffers in system memory.

Signed-off-by: Roman Li 
Reviewed-by: Nicholas Kazlauskas 
Signed-off-by: Alex Deucher

drm/amd: print error on convert_tiling_flags_to_modifier failure

2020-12-09T04:02:24+00:00

If this function fails, it means the tiling flags didn't make sense.
This likely indicates a user-space bug. Log the error alongside with the
provided tiling flags to make debugging easier.

Signed-off-by: Simon Ser 
Cc: Alex Deucher 
Cc: Harry Wentland 
Cc: Nicholas Kazlauskas 
Cc: Bas Nieuwenhuizen 
Cc: Michel Dänzer 
Signed-off-by: Alex Deucher

drm/amd: use drm_dbg_kms to log addfb2 failures

2020-12-09T04:02:21+00:00

Avoid printing an error with dev_err, because user-space can trigger
these at will by issuing an ioctl.

Convert a DRM_DEBUG_KMS call to the more modern drm_dbg_kms macro.

Signed-off-by: Simon Ser 
Cc: Alex Deucher 
Cc: Harry Wentland 
Cc: Nicholas Kazlauskas 
Cc: Michel Dänzer 
Signed-off-by: Alex Deucher

drm/amd/display: Extract 3rd plane from metadata

2020-11-13T22:29:47+00:00

Now that we actually expose the right number of planes we get
problems with modifier aware libva if we use an unsupported modifier.

So this ensures that we as much as possible use a modifier that
radeonsi can actually render to without going to extreme difficulty
to synchronize an extra DCC metadata plane with implicit sync.

Looking into the opaque metadata isn't ideal but this converts to
something mainly for the purpose of the userspace driver and falls
back properly if it isn't what we expect.

Reviewed-by: Alex Deucher 
Signed-off-by: Bas Nieuwenhuizen 
Signed-off-by: Alex Deucher

drm/amd/display: Set new format info for converted metadata.

2020-11-13T22:29:47+00:00

If we use DCC modifiers this can increase the number of planes from
the initial 1 plane with metadata, so that we get a valid modifier
from getfb2.

Since the code didn't update the format_info getfb2 would only ever
return 1 plane with a modifier for which userspace expects > 1.

This moves the format lookup to amdgpu_display.c so we do not have
issues when DC is not compiled.

Reviewed-by: Alex Deucher 
Signed-off-by: Bas Nieuwenhuizen 
Signed-off-by: Alex Deucher

drm/amd/display: Store gem objects for planes 1-3

2020-11-13T22:29:47+00:00

Also do the proper validation which was missed.

Besides the missing validation, not storing the objects in the
framebuffer led to wrong results in the getfb2 ioctl.

Note that this should really have been done for multi-plane
formats like NV12 already before modifiers landed.

Reviewed-by: Alex Deucher 
Signed-off-by: Bas Nieuwenhuizen 
Signed-off-by: Alex Deucher