linux-stable.git/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c, branch linux-4.8.y

drm/amdgpu: fix check for port PM availability

2016-12-08T06:16:19+00:00

commit 7ac33e47d5769632010e537964c7e45498f8dc26 upstream.

The ATPX method does not always exist on the dGPU, it may be located at
the iGPU. The parent device of the iGPU is the root port for which
bridge_d3 is false. This accidentally enables the legacy PM method which
conflicts with port PM and prevented the dGPU from powering on.

Fixes: 1db4496f167b ("drm/amdgpu: fix power state when port pm is unavailable")

Reported-and-tested-by: Mike Lothian 
Signed-off-by: Peter Wu 
Signed-off-by: Alex Deucher 
Signed-off-by: Greg Kroah-Hartman

drm/amdgpu: fix power state when port pm is unavailable

2016-12-08T06:16:19+00:00

commit 1db4496f167bcc7c6541d449355ade2e7d339d52 upstream.

When PCIe port PM is not enabled (system BIOS is pre-2015 or the
pcie_port_pm=off parameter is set), legacy ATPX PM should still be
marked as supported. Otherwise the GPU can fail to power on after
runtime suspend. This affected a Dell Inspiron 5548.

Ideally the BIOS date in the PCI core is lowered to 2013 (the first year
where hybrid graphics platforms using power resources was introduced),
but that seems more risky at this point and would not solve the
pcie_port_pm=off issue.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98505
Reported-and-tested-by: Nayan Deshmukh 
Signed-off-by: Peter Wu 
Signed-off-by: Alex Deucher 
Acked-by: Christian König 
Reviewed-by: Alex Deucher 
Signed-off-by: Greg Kroah-Hartman

Revert "drm/amdgpu: work around lack of upstream ACPI support for D3cold"

2016-08-09T04:20:28+00:00

This reverts commit c63695cc5e5f685e924e25a8f9555f6e846f1fc6.

Now that d3cold support is upstream, there is no more need for this
workaround.

bug:
https://bugs.freedesktop.org/show_bug.cgi?id=97248

drm/amdgpu: init atpx at switcheroo register time (v2)

2016-07-29T18:36:32+00:00

If we do it at enable time, it's too late for the feature
checks.

v2: drop .init setting as per Peter's comments

Reviewed-by: Peter Wu 
Signed-off-by: Alex Deucher 
Cc: Peter Wu

drm/amdgpu: work around lack of upstream ACPI support for D3cold

2016-07-07T18:51:13+00:00

Until Dave's patch to support the new hybrid gfx ACPI method goes
upstream, we can fallback to the old ATPX method which seems to
still work.

Signed-off-by: Alex Deucher

drm/amdgpu/atpx: track whether if this is a hybrid graphics platform

2016-07-07T18:51:07+00:00

hybrid graphics in this case refers to systems which use the new
platform d3 cold ACPI methods as opposed to ATPX for dGPU power
control.

Reviewed-by: Hawking Zhang 
Acked-by: Christian König 
Signed-off-by: Alex Deucher

drm/amdgpu/atpx: drop forcing of dGPU power control

2016-07-07T18:51:02+00:00

Now that we handle this correctly, there is no need to force
it.

Reviewed-by: Hawking Zhang 
Acked-by: Christian König 
Signed-off-by: Alex Deucher

drm/amdgpu/atpx: add a query for ATPX dGPU power control

2016-07-07T18:51:01+00:00

The runtime pm sequence is different depending on whether or
not the platform supports ATPX dGPU power control.

Reviewed-by: Hawking Zhang 
Acked-by: Christian König 
Signed-off-by: Alex Deucher

drm/amdgpu: add a delay after ATPX dGPU power off

2016-07-07T18:51:01+00:00

ATPX dGPU power control requires a 200ms delay between
power off and on.  This should fix dGPU failures on
resume from power off.

Reviewed-by: Hawking Zhang 
Acked-by: Christian König 
Signed-off-by: Alex Deucher 
Cc: stable@vger.kernel.org

drm/amdgpu: clean up atpx power control handling

2016-07-07T18:51:00+00:00

The presence of the power control method should be determined
via the presence of the method in function 0.  However, some
sbioses only set the appropriate bits in function 1 so use
then to override a missing power control function.

Reviewed-by: Hawking Zhang 
Acked-by: Christian König 
Signed-off-by: Alex Deucher