linux-stable.git/drivers/fpga, branch v5.18.2

fpga: dfl: pci: Remove usage of the deprecated "pci-dma-compat.h" API

2022-01-25T19:25:50+00:00

In [1], Christoph Hellwig has proposed to remove the wrappers in
include/linux/pci-dma-compat.h.

Some reasons why this API should be removed have been given by Julia
Lawall in [2].

A coccinelle script has been used to perform the needed transformation.
It can be found in [3].

It has been hand modified to use 'dma_set_mask_and_coherent()' instead of
'pci_set_dma_mask()/pci_set_consistent_dma_mask()' when applicable.
This is less verbose.

The explicit 'ret = -EIO;' has been removed because
'dma_set_mask_and_coherent()' returns 0 or -EIO, so its return code can be
used directly.

[1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/
[2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/
[3]: https://lore.kernel.org/kernel-janitors/20200716192821.321233-1-christophe.jaillet@wanadoo.fr/

Reviewed-by: Xu Yilun 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Arnd Bergmann 
Signed-off-by: Christophe JAILLET 
Signed-off-by: Moritz Fischer

fpga: region: fix kernel-doc

2021-12-10T04:06:54+00:00

Fix function name in of-fpga-region.c kernel-doc comment
to remove a warning found by running scripts/kernel-doc,
which is caused by using 'make W=1'.

drivers/fpga/of-fpga-region.c:451: warning: expecting prototype for
fpga_region_init(). Prototype was for of_fpga_region_init() instead.

Reported-by: Abaci Robot 
Signed-off-by: Yang Li 
Acked-by: Randy Dunlap 
Signed-off-by: Moritz Fischer

fpga: stratix10-soc: Do not use ret uninitialized in s10_probe()

2021-12-03T04:07:17+00:00

Clang warns:

drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
        return ret;
               ^~~

ret is only assigned in an error path now so just return 0 directly.

Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1517
Reviewed-by: Russ Weight 
Reviewed-by: Tom Rix 
Acked-by: Xu Yilun 
Signed-off-by: Nathan Chancellor 
Signed-off-by: Moritz Fischer

fpga: region: Use standard dev_release for class driver

2021-11-28T22:02:41+00:00

The FPGA region class driver data structure is being treated as a
managed resource instead of using the standard dev_release call-back
function to release the class data structure. This change removes the
managed resource code and combines the create() and register()
functions into a single register() or register_full() function.

The register_full() function accepts an info data structure to provide
flexibility in passing optional parameters. The register() function
supports the current parameter list for users that don't require the
use of optional parameters.

Signed-off-by: Russ Weight 
Reviewed-by: Xu Yilun 
Acked-by: Xu Yilun 
Signed-off-by: Moritz Fischer

fpga: bridge: Use standard dev_release for class driver

2021-11-28T22:02:13+00:00

The FPGA bridge class driver data structure is being treated as a
managed resource instead of using the standard dev_release call-back
function to release the class data structure. This change removes
the managed resource code and combines the create() and register()
functions into a single register() function.

Signed-off-by: Russ Weight 
Reviewed-by: Xu Yilun 
Acked-by: Xu Yilun 
Signed-off-by: Moritz Fischer

fpga: mgr: Use standard dev_release for class driver

2021-11-28T21:59:13+00:00

The FPGA manager class driver data structure is being treated as a
managed resource instead of using the standard dev_release call-back
function to release the class data structure. This change removes
the managed resource code for the freeing of the class data structure
and combines the create() and register() functions into a single
register() or register_full() function.

The register_full() function accepts an info data structure to provide
flexibility in passing optional parameters. The register() function
supports the current parameter list for users that don't require the
use of optional parameters.

The devm_fpga_mgr_register() function is retained, and the
devm_fpga_mgr_register_full() function is added.

Signed-off-by: Russ Weight 
Reviewed-by: Xu Yilun 
Acked-by: Xu Yilun 
Signed-off-by: Moritz Fischer

fpga: ice40-spi: Add SPI device ID table

2021-09-27T21:00:41+00:00

Currently autoloading for SPI devices does not use the DT ID table, it uses
SPI modalises. Supporting OF modalises is going to be difficult if not
impractical, an attempt was made but has been reverted, so ensure that
module autoloading works for this driver by adding a SPI ID table.

Fixes: 96c8395e2166 ("spi: Revert modalias changes")
Signed-off-by: Mark Brown 
Signed-off-by: Moritz Fischer

fpga: dfl: Avoid reads to AFU CSRs during enumeration

2021-09-16T22:20:55+00:00

CSR address space for Accelerator Functional Units (AFU) is not available
during the early Device Feature List (DFL) enumeration. Early access
to this space results in invalid data and port errors. This change adds
a condition to prevent an early read from the AFU CSR space.

Fixes: 1604986c3e6b ("fpga: dfl: expose feature revision from struct dfl_device")
Cc: stable@vger.kernel.org
Signed-off-by: Russ Weight 
Signed-off-by: Moritz Fischer

fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()

2021-09-15T21:01:24+00:00

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.

Eliminate the follow smatch warning:

drivers/fpga/machxo2-spi.c:341 machxo2_write_complete()
  warn: missing error code 'ret'.

[mdf@kernel.org: Reworded commit message]
Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
Signed-off-by: Moritz Fischer

fpga: machxo2-spi: Return an error on failure

2021-09-15T21:01:17+00:00

Earlier successes leave 'ret' in a non error state, so these errors are
not reported. Set ret to -EINVAL before going to the error handler.

This addresses two issues reported by smatch:
drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
  warn: missing error code 'ret'

drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
  warn: missing error code 'ret'

[mdf@kernel.org: Reworded commit message]
Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Dan Carpenter 
Signed-off-by: Tom Rix 
Signed-off-by: Moritz Fischer