linux-stable.git/drivers/fpga, branch v5.10.239

fpga: altera-cvp: Increase credit timeout

2025-06-04T12:37:02+00:00

[ Upstream commit 0f05886a40fdc55016ba4d9ae0a9c41f8312f15b ]

Increase the timeout for SDM (Secure device manager) data credits from
20ms to 40ms. Internal stress tests running at 500 loops failed with the
current timeout of 20ms. At the start of a FPGA configuration, the CVP
host driver reads the transmit credits from SDM. It then sends bitstream
FPGA data to SDM based on the total credits. Each credit allows the
CVP host driver to send 4kBytes of data. There are situations whereby,
the SDM did not respond in time during testing.

Signed-off-by: Ang Tien Sung 
Signed-off-by: Kuhanh Murugasen Krishnan 
Acked-by: Xu Yilun 
Link: https://lore.kernel.org/r/20250212221249.2715929-1-tien.sung.ang@intel.com
Signed-off-by: Xu Yilun 
Signed-off-by: Sasha Levin

fpga: region: add owner module and take its refcount

2024-06-16T11:32:19+00:00

[ Upstream commit b7c0e1ecee403a43abc89eb3e75672b01ff2ece9 ]

The current implementation of the fpga region assumes that the low-level
module registers a driver for the parent device and uses its owner pointer
to take the module's refcount. This approach is problematic since it can
lead to a null pointer dereference while attempting to get the region
during programming if the parent device does not have a driver.

To address this problem, add a module owner pointer to the fpga_region
struct and use it to take the module's refcount. Modify the functions for
registering a region to take an additional owner module parameter and
rename them to avoid conflicts. Use the old function names for helper
macros that automatically set the module that registers the region as the
owner. This ensures compatibility with existing low-level control modules
and reduces the chances of registering a region without setting the owner.

Also, update the documentation to keep it consistent with the new interface
for registering an fpga region.

Fixes: 0fa20cdfcc1f ("fpga: fpga-region: device tree control for FPGA")
Suggested-by: Greg Kroah-Hartman 
Suggested-by: Xu Yilun 
Reviewed-by: Russ Weight 
Signed-off-by: Marco Pagani 
Acked-by: Xu Yilun 
Link: https://lore.kernel.org/r/20240419083601.77403-1-marpagan@redhat.com
Signed-off-by: Xu Yilun 
Signed-off-by: Sasha Levin

fpga: region: Use standard dev_release for class driver

2024-06-16T11:32:19+00:00

[ Upstream commit 8886a579744fbfa53e69aa453ed10ae3b1f9abac ]

The FPGA region class driver data structure is being treated as a
managed resource instead of using the standard dev_release call-back
function to release the class data structure. This change removes the
managed resource code and combines the create() and register()
functions into a single register() or register_full() function.

The register_full() function accepts an info data structure to provide
flexibility in passing optional parameters. The register() function
supports the current parameter list for users that don't require the
use of optional parameters.

Signed-off-by: Russ Weight 
Reviewed-by: Xu Yilun 
Acked-by: Xu Yilun 
Signed-off-by: Moritz Fischer 
Stable-dep-of: b7c0e1ecee40 ("fpga: region: add owner module and take its refcount")
Signed-off-by: Sasha Levin

fpga: region: Rename dev to parent for parent device

2024-06-16T11:32:19+00:00

[ Upstream commit 5e77886d0aa9a882424f6a4ccb3eca4dca43b4a0 ]

Rename variable "dev" to "parent" in cases where it represents the parent
device.

Signed-off-by: Russ Weight 
Reviewed-by: Xu Yilun 
Signed-off-by: Moritz Fischer 
Link: https://lore.kernel.org/r/20210614170909.232415-6-mdf@kernel.org
Signed-off-by: Greg Kroah-Hartman 
Stable-dep-of: b7c0e1ecee40 ("fpga: region: add owner module and take its refcount")
Signed-off-by: Sasha Levin

fpga: region: change FPGA indirect article to an

2024-06-16T11:32:19+00:00

[ Upstream commit 011c49e3703854e52c0fb88f22cf38aca1d4d514 ]

Change use of 'a fpga' to 'an fpga'

Signed-off-by: Tom Rix 
Link: https://lore.kernel.org/r/20210608212350.3029742-10-trix@redhat.com
Signed-off-by: Greg Kroah-Hartman 
Stable-dep-of: b7c0e1ecee40 ("fpga: region: add owner module and take its refcount")
Signed-off-by: Sasha Levin

fpga: bridge: fix kernel-doc parameter description

2023-05-17T09:47:55+00:00

[ Upstream commit 7ef1a2c1c9dffa177ecc3ea50b7f5ee63a621137 ]

Fix the kernel-doc description for the "struct fpga_image_info *info"
parameter of the fpga_bridge_get() function.

Fixes: 060ac5c8fa7b ("fpga: bridge: kernel-doc fixes")
Signed-off-by: Marco Pagani 
Reviewed-by: Tom Rix 
Acked-by: Xu Yilun 
Link: https://lore.kernel.org/r/20230301140309.512578-1-marpagan@redhat.com
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Sasha Levin

fpga: stratix10-soc: Fix return value check in s10_ops_write_init()

2023-02-15T16:22:19+00:00

commit 65ea840afd508194b0ee903256162aa87e46ec30 upstream.

In case of error, the function stratix10_svc_allocate_memory()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().

Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")
Signed-off-by: Zheng Yongjun 
Reviewed-by: Russ Weight 
Cc: stable@vger.kernel.org
Acked-by: Xu Yilun 
Link: https://lore.kernel.org/r/20221126071430.19540-1-zhengyongjun3@huawei.com
Signed-off-by: Xu Yilun 
Signed-off-by: Greg Kroah-Hartman

fpga: prevent integer overflow in dfl_feature_ioctl_set_irq()

2022-10-26T11:25:33+00:00

[ Upstream commit 939bc5453b8cbdde9f1e5110ce8309aedb1b501a ]

The "hdr.count * sizeof(s32)" multiplication can overflow on 32 bit
systems leading to memory corruption.  Use array_size() to fix that.

Fixes: 322b598be4d9 ("fpga: dfl: introduce interrupt trigger setting API")
Signed-off-by: Dan Carpenter 
Acked-by: Xu Yilun 
Link: https://lore.kernel.org/r/YxBAtYCM38dM7yzI@kili
Signed-off-by: Xu Yilun 
Signed-off-by: Sasha Levin

fpga: altera-pr-ip: fix unsigned comparison with less than zero

2022-08-21T13:15:53+00:00

[ Upstream commit 2df84a757d87fd62869fc401119d429735377ec5 ]

Fix the "comparison with less than zero" warning reported by
cppcheck for the unsigned (size_t) parameter count of the
alt_pr_fpga_write() function.

Fixes: d201cc17a8a3 ("fpga pr ip: Core driver support for Altera Partial Reconfiguration IP")
Reviewed-by: Tom Rix 
Acked-by: Xu Yilun 
Signed-off-by: Marco Pagani 
Link: https://lore.kernel.org/r/20220609140520.42662-1-marpagan@redhat.com
Signed-off-by: Xu Yilun 
Signed-off-by: Sasha Levin

fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()

2021-09-30T08:11:04+00:00

[ Upstream commit a1e4470823d99e75b596748086e120dea169ed3c ]

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.

Eliminate the follow smatch warning:

drivers/fpga/machxo2-spi.c:341 machxo2_write_complete()
  warn: missing error code 'ret'.

[mdf@kernel.org: Reworded commit message]
Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
Signed-off-by: Moritz Fischer 
Signed-off-by: Sasha Levin