linux-stable.git/drivers/firmware/psci, branch linux-5.7.y

drivers/firmware/psci: Fix memory leakage in alloc_init_cpu_groups()

2020-07-29T08:19:37+00:00

[ Upstream commit c377e67c6271954969384f9be1b1b71de13eba30 ]

The CPU mask (@tmp) should be released on failing to allocate
@cpu_groups or any of its elements. Otherwise, it leads to memory
leakage because the CPU mask variable is dynamically allocated
when CONFIG_CPUMASK_OFFSTACK is enabled.

Signed-off-by: Gavin Shan 
Reviewed-by: Sudeep Holla 
Link: https://lore.kernel.org/r/20200630075227.199624-1-gshan@redhat.com
Signed-off-by: Will Deacon 
Signed-off-by: Sasha Levin

firmware: psci: Replace cpu_up/down() with add/remove_cpu()

2020-03-25T11:59:37+00:00

The core device API performs extra housekeeping bits that are missing
from directly calling cpu_up/down().

See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and
serialization during LPM") for an example description of what might go
wrong.

This also prepares to make cpu_up/down a private interface of the CPU subsystem.

Signed-off-by: Qais Yousef 
Signed-off-by: Thomas Gleixner 
Cc: Lorenzo Pieralisi 
Link: https://lkml.kernel.org/r/20200323135110.30522-15-qais.yousef@arm.com

firmware: psci: Export functions to manage the OSI mode

2020-01-02T15:49:59+00:00

To allow subsequent changes to implement support for OSI mode through the
cpuidle-psci driver, export the existing psci_has_osi_support(). Export
also a new function, psci_set_osi_mode(), that allows its caller to enable
the OS-initiated CPU-suspend mode in the PSCI FW.

To deal with backwards compatibility for a kernel started through a kexec
call, default to set the CPU-suspend mode to the Platform Coordinated mode
during boot.

Signed-off-by: Ulf Hansson 
Reviewed-by: Sudeep Holla

firmware/psci: use common SMCCC_CONDUIT_*

2019-10-14T09:55:14+00:00

Now that we have common SMCCC_CONDUIT_* definitions, migrate the PSCI
code over to them, and kill off the old PSCI_CONDUIT_* definitions.

There should be no functional change as a result of this patch.

Signed-off-by: Mark Rutland 
Acked-by: Lorenzo Pieralisi 
Acked-by: Will Deacon 
Signed-off-by: Catalin Marinas

arm/arm64: smccc/psci: add arm_smccc_1_1_get_conduit()

2019-10-14T09:55:13+00:00

SMCCC callers are currently amassing a collection of enums for the SMCCC
conduit, and are having to dig into the PSCI driver's internals in order
to figure out what to do.

Let's clean this up, with common SMCCC_CONDUIT_* definitions, and an
arm_smccc_1_1_get_conduit() helper that abstracts the PSCI driver's
internal state.

We can kill off the PSCI_CONDUIT_* definitions once we've migrated users
over to the new interface.

Signed-off-by: Mark Rutland 
Acked-by: Lorenzo Pieralisi 
Acked-by: Will Deacon 
Signed-off-by: Catalin Marinas

PSCI: cpuidle: Refactor CPU suspend power_state parameter handling

2019-08-09T16:51:39+00:00

Current PSCI code handles idle state entry through the
psci_cpu_suspend_enter() API, that takes an idle state index as a
parameter and convert the index into a previously initialized
power_state parameter before calling the PSCI.CPU_SUSPEND() with it.

This is unwieldly, since it forces the PSCI firmware layer to keep track
of power_state parameter for every idle state so that the
index->power_state conversion can be made in the PSCI firmware layer
instead of the CPUidle driver implementations.

Move the power_state handling out of drivers/firmware/psci
into the respective ACPI/DT PSCI CPUidle backends and convert
the psci_cpu_suspend_enter() API to get the power_state
parameter as input, which makes it closer to its firmware
interface PSCI.CPU_SUSPEND() API.

A notable side effect is that the PSCI ACPI/DT CPUidle backends
now can directly handle (and if needed update) power_state
parameters before handing them over to the PSCI firmware
interface to trigger PSCI.CPU_SUSPEND() calls.

Signed-off-by: Lorenzo Pieralisi 
Acked-by: Daniel Lezcano 
Reviewed-by: Ulf Hansson 
Reviewed-by: Sudeep Holla 
Cc: Will Deacon 
Cc: Ulf Hansson 
Cc: Sudeep Holla 
Cc: Daniel Lezcano 
Cc: Catalin Marinas 
Cc: Mark Rutland 
Cc: "Rafael J. Wysocki" 
Signed-off-by: Will Deacon

ARM: psci: cpuidle: Enable PSCI CPUidle driver

2019-08-09T16:51:39+00:00

Allow selection of the PSCI CPUidle in the kernel by updating
the respective Kconfig entry.

Remove PSCI callbacks from ARM/ARM64 generic CPU ops
to prevent the PSCI idle driver from clashing with the generic
ARM CPUidle driver initialization, that relies on CPU ops
to initialize and enter idle states.

Signed-off-by: Lorenzo Pieralisi 
Reviewed-by: Ulf Hansson 
Cc: Will Deacon 
Cc: Ulf Hansson 
Cc: Sudeep Holla 
Cc: Daniel Lezcano 
Cc: Catalin Marinas 
Cc: Mark Rutland 
Cc: "Rafael J. Wysocki" 
Signed-off-by: Will Deacon

drivers: firmware: psci: Decouple checker from generic ARM CPUidle

2019-08-09T16:51:39+00:00

The PSCI checker currently relies on the generic ARM CPUidle
infrastructure to enter an idle state, which in turn creates
a dependency that is not really needed.

The PSCI checker code to test PSCI CPU suspend is built on
top of the CPUidle framework and can easily reuse the
struct cpuidle_state.enter() function (previously initialized
by an idle driver, with a PSCI back-end) to trigger an entry
into an idle state, decoupling the PSCI checker from the
generic ARM CPUidle infrastructure and simplyfing the code
in the process.

Convert the PSCI checker suspend entry function to use
the struct cpuidle_state.enter() function callback.

Signed-off-by: Lorenzo Pieralisi 
Acked-by: Daniel Lezcano 
Reviewed-by: Ulf Hansson 
Reviewed-by: Sudeep Holla 
Cc: Sudeep Holla 
Cc: Mark Rutland 
Signed-off-by: Will Deacon

firmware/psci: psci_checker: Park kthreads before stopping them

2019-06-17T11:50:21+00:00

Since commit 85f1abe0019f ("kthread, sched/wait: Fix kthread_parkme()
completion issue"), kthreads that are bound to a CPU must be parked
before being stopped. At the moment the PSCI checker calls
kthread_stop() directly on the suspend kthread, which triggers the
following warning:

[    6.068288] WARNING: CPU: 1 PID: 1 at kernel/kthread.c:398 __kthread_bind_mask+0x20/0x78
               ...
[    6.190151] Call trace:
[    6.192566]  __kthread_bind_mask+0x20/0x78
[    6.196615]  kthread_unpark+0x74/0x80
[    6.200235]  kthread_stop+0x44/0x1d8
[    6.203769]  psci_checker+0x3bc/0x484
[    6.207389]  do_one_initcall+0x48/0x260
[    6.211180]  kernel_init_freeable+0x2c8/0x368
[    6.215488]  kernel_init+0x10/0x100
[    6.218935]  ret_from_fork+0x10/0x1c
[    6.222467] ---[ end trace e05e22863d043cd3 ]---

kthread_unpark() tries to bind the thread to its CPU and aborts with a
WARN() if the thread wasn't in TASK_PARKED state. Park the kthreads
before stopping them.

Fixes: 85f1abe0019f ("kthread, sched/wait: Fix kthread_parkme() completion issue")
Signed-off-by: Jean-Philippe Brucker 
Reviewed-by: Sudeep Holla 
Acked-by: Lorenzo Pieralisi 
Signed-off-by: Olof Johansson

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174

2019-05-30T18:26:41+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation this program is
  distributed in the hope that it will be useful but without any
  warranty without even the implied warranty of merchantability or
  fitness for a particular purpose see the gnu general public license
  for more details

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 655 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Reviewed-by: Kate Stewart 
Reviewed-by: Richard Fontana 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070034.575739538@linutronix.de
Signed-off-by: Greg Kroah-Hartman