linux-stable.git/drivers/extcon, branch linux-5.17.y

extcon: Modify extcon device to be created after driver data is set

2022-06-14T16:41:35+00:00

[ Upstream commit 5dcc2afe716d69f5112ce035cb14f007461ff189 ]

Currently, someone can invoke the sysfs such as state_show()
intermittently before dev_set_drvdata() is done.
And it can be a cause of kernel Oops because of edev is Null at that time.
So modified the driver registration to after setting drviver data.

- Oops's backtrace.

Backtrace:
[] (state_show) from [] (dev_attr_show)
[] (dev_attr_show) from [] (sysfs_kf_seq_show)
[] (sysfs_kf_seq_show) from [] (kernfs_seq_show)
[] (kernfs_seq_show) from [] (seq_read)
[] (seq_read) from [] (kernfs_fop_read)
[] (kernfs_fop_read) from [] (__vfs_read)
[] (__vfs_read) from [] (vfs_read)
[] (vfs_read) from [] (ksys_read)
[] (ksys_read) from [] (sys_read)
[] (sys_read) from [] (__sys_trace_return)

Signed-off-by: bumwoo lee 
Signed-off-by: Chanwoo Choi 
Signed-off-by: Sasha Levin

extcon: Fix extcon_get_extcon_dev() error handling

2022-06-14T16:41:35+00:00

[ Upstream commit 58e4a2d27d3255e4e8c507fdc13734dccc9fc4c7 ]

The extcon_get_extcon_dev() function returns error pointers on error,
NULL when it's a -EPROBE_DEFER defer situation, and ERR_PTR(-ENODEV)
when the CONFIG_EXTCON option is disabled.  This is very complicated for
the callers to handle and a number of them had bugs that would lead to
an Oops.

In real life, there are two things which prevented crashes.  First,
error pointers would only be returned if there was bug in the caller
where they passed a NULL "extcon_name" and none of them do that.
Second, only two out of the eight drivers will build when CONFIG_EXTCON
is disabled.

The normal way to write this would be to return -EPROBE_DEFER directly
when appropriate and return NULL when CONFIG_EXTCON is disabled.  Then
the error handling is simple and just looks like:

	dev->edev = extcon_get_extcon_dev(acpi_dev_name(adev));
	if (IS_ERR(dev->edev))
		return PTR_ERR(dev->edev);

For the two drivers which can build with CONFIG_EXTCON disabled, then
extcon_get_extcon_dev() will now return NULL which is not treated as an
error and the probe will continue successfully.  Those two drivers are
"typec_fusb302" and "max8997-battery".  In the original code, the
typec_fusb302 driver had an 800ms hang in tcpm_get_current_limit() but
now that function is a no-op.  For the max8997-battery driver everything
should continue working as is.

Signed-off-by: Dan Carpenter 
Reviewed-by: Hans de Goede 
Reviewed-by: Heikki Krogerus 
Reviewed-by: Guenter Roeck 
Acked-by: Sebastian Reichel 
Signed-off-by: Chanwoo Choi 
Signed-off-by: Sasha Levin

extcon: ptn5150: Add queue work sync before driver release

2022-06-14T16:41:17+00:00

[ Upstream commit 782cd939cbe0f569197cd1c9b0477ee213167f04 ]

Add device managed action to sync pending queue work, otherwise
the queued work may run after the work is destroyed.

Fixes: 4ed754de2d66 ("extcon: Add support for ptn5150 extcon driver")
Reviewed-by: Krzysztof Kozlowski 
Signed-off-by: Li Jun 
Signed-off-by: Chanwoo Choi 
Signed-off-by: Sasha Levin

extcon: Deduplicate code in extcon_set_state_sync()

2021-12-24T06:27:52+00:00

Finding the cable index and checking for changed status is also done
in extcon_set_state(). So calling extcon_set_state_sync() will do these
checks twice. Remove them and use these checks from extcon_set_state().

Signed-off-by: Alexander Stein 
Signed-off-by: Chanwoo Choi

extcon: usb-gpio: fix a non-kernel-doc comment

2021-12-24T06:27:52+00:00

Do not use "/**" to begin a non-kernel-doc comment.
Fixes this build warning:

drivers/extcon/extcon-usb-gpio.c:23:
	warning: expecting prototype for drivers/extcon/extcon-usb-gpio.c().

Signed-off-by: Randy Dunlap 
Reported-by: kernel test robot 
Signed-off-by: Chanwoo Choi

extcon: usbc-tusb320: Add support for TUSB320L

2021-10-27T05:13:39+00:00

TUSB320L is a newer chip with additional features, and it has additional steps
in its mode changing sequence:
 - Disable CC state machine,
 - Write to mode register,
 - Wait for 5 ms,
 - Re-enable CC state machine.
It also has an additional register that a revision number can be read from.

Add support for the mode changing sequence, and read the revision number during
probe and print it as info.

Signed-off-by: Yassine Oudjana 
Signed-off-by: Chanwoo Choi

extcon: usbc-tusb320: Add support for mode setting and reset

2021-10-27T05:13:38+00:00

Reset the chip and set its mode to default (maintain mode set by PORT pin)
during probe to make sure it comes up in the default state.

Signed-off-by: Yassine Oudjana 
Signed-off-by: Chanwoo Choi

extcon: extcon-axp288: Use P-Unit semaphore lock for register accesses

2021-10-27T05:13:38+00:00

use low level P-Unit semaphore lock for axp288 register
accesses directly and for more than one access a time,
to reduce the number of times this semaphore is locked
and released which is an expensive operation.

i2c-bus to the XPower is shared between the kernel and the
SoCs P-Unit. The P-Unit has a semaphore wich the kernel must
lock for axp288 register accesses. When the P-Unit semaphore
is locked CPU and GPU power states cannot change or the system
will freeze.

The P-Unit semaphore lock is already managed inside the regmap
access logic, but for each access the semaphore is locked and
released. So use directly iosf_mbi_(un)block_punit_i2c_access(),
we are safe in doing so because nested calls to the same
semaphore are turned to nops.

Suggested-by: Hans de Goede 
Reviewed-by: Hans de Goede 
Tested-by: Hans de Goede 
Signed-off-by: Fabio Aiuto 
Signed-off-by: Chanwoo Choi

extcon: max3355: Drop unused include

2021-10-27T05:13:37+00:00

This driver includes the legacy  header but
does not use it. Drop this include.

Cc: Sergei Shtylyov 
Signed-off-by: Linus Walleij 
Signed-off-by: Chanwoo Choi

extcon: usb-gpio: Use the right includes

2021-10-27T05:13:36+00:00

The USB GPIO extcon driver does not use any of the legacy
includes  or  but
exploits the fact that this brings in .
Fix this up by using the right includes.

Signed-off-by: Linus Walleij 
Signed-off-by: Chanwoo Choi