linux-stable.git/drivers/edac/edac_module.c, branch v3.7

edac: create top-level debugfs directory

2012-06-12T15:15:49+00:00

Create a single, top-level "edac" directory for debugfs. An "mc[0-N]"
directory is then created for each memory controller. Individual drivers
can create additional entries such as h/w error injection control.

Signed-off-by: Rob Herring 
Signed-off-by: Mauro Carvalho Chehab

edac: Increase version to 3.0.0

2012-06-11T16:23:50+00:00

There were lots of changes introduced to justify renaming it to
3.0.0:

  - EDAC core were redesigned to represent all types of
    memory controllers;

  - EDAC API were redesigned to properly represent the memory
    controller hierarchy;

  - a tracepoint-based API were added to report memory errors.

Signed-off-by: Mauro Carvalho Chehab

edac: Convert debugfX to edac_dbg(X,

2012-06-11T16:23:49+00:00

Use a more common debugging style.

Remove __FILE__ uses, add missing newlines,
coalesce formats and align arguments.

Signed-off-by: Joe Perches 
Signed-off-by: Mauro Carvalho Chehab

edac: Don't add func or FILE for debugf[0-9] msgs

2012-06-11T16:23:47+00:00

The debug macro already adds that. Most of the work here was
made by this small script:

$f .=$_ while (<>);

$f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*": /\1"/g;
$f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*/\1/g;
$f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*"MC: /\1"/g;

$f =~ s/(debugf[0-9]\s*\(\")\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+)__func__\s*\,\s*/\1\2/g;
$f =~ s/(debugf[0-9]\s*\(\")\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+),\s*__func__\s*\)/\1\2)/g;
$f =~ s/(debugf[0-9]\s*\(\"MC\:\s*)\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+)__func__\s*\,\s*/\1\2/g;
$f =~ s/(debugf[0-9]\s*\(\"MC\:\s*)\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+),\s*__func__\s*\)/\1\2)/g;

$f =~ s/\"MC\: \\n\"/"MC:\\n"/g;

print $f;

After running the script, manual cleanups were done to fix it the remaining
places.

While here, removed the __LINE__ on most places, as it doesn't actually give
useful info on most places.

Signed-off-by: Mauro Carvalho Chehab

edac: rewrite the sysfs code to use struct device

2012-06-11T16:23:30+00:00

The EDAC subsystem uses the old struct sysdev approach,
creating all nodes using the raw sysfs API. This is bad,
as the API is deprecated.

As we'll be changing the EDAC API, let's first port the existing
code to struct device.

There's one drawback on this patch: driver-specific sysfs
nodes, used by mpc85xx_edac, amd64_edac and i7core_edac
 won't be created anymore. While it would be possible to
also port the device-specific code, that would mix kobj with
struct device, with is not recommended. Also, it is easier and nicer
to move the code to the drivers, instead, as the core can get rid
of some complex logic that just emulates what the device_add()
and device_create_file() already does.

The next patches will convert the driver-specific code to use
the device-specific calls. Then, the remaining bits of the old
sysfs API will be removed.

NOTE: a per-MC bus is required, otherwise devices with more than
one memory controller will hit a bug like the one below:

[  819.094946] EDAC DEBUG: find_mci_by_dev: find_mci_by_dev()
[  819.094948] EDAC DEBUG: edac_create_sysfs_mci_device: edac_create_sysfs_mci_device() idx=1
[  819.094952] EDAC DEBUG: edac_create_sysfs_mci_device: edac_create_sysfs_mci_device(): creating device mc1
[  819.094967] EDAC DEBUG: edac_create_sysfs_mci_device: edac_create_sysfs_mci_device creating dimm0, located at channel 0 slot 0
[  819.094984] ------------[ cut here ]------------
[  819.100142] WARNING: at fs/sysfs/dir.c:481 sysfs_add_one+0xc1/0xf0()
[  819.107282] Hardware name: S2600CP
[  819.111078] sysfs: cannot create duplicate filename '/bus/edac/devices/dimm0'
[  819.119062] Modules linked in: sb_edac(+) edac_core ip6table_filter ip6_tables ebtable_nat ebtables ipt_MASQUERADE iptable_nat nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_state nf_conntrack ipt_REJECT xt_CHECKSUM iptable_mangle iptable_filter ip_tables bridge stp llc sunrpc binfmt_misc dm_mirror dm_region_hash dm_log vhost_net macvtap macvlan tun kvm microcode pcspkr iTCO_wdt iTCO_vendor_support igb i2c_i801 i2c_core sg ioatdma dca sr_mod cdrom sd_mod crc_t10dif ahci libahci isci libsas libata scsi_transport_sas scsi_mod wmi dm_mod [last unloaded: scsi_wait_scan]
[  819.175748] Pid: 10902, comm: modprobe Not tainted 3.3.0-0.11.el7.v12.2.x86_64 #1
[  819.184113] Call Trace:
[  819.186868]  [] warn_slowpath_common+0x7f/0xc0
[  819.193573]  [] warn_slowpath_fmt+0x46/0x50
[  819.200000]  [] sysfs_add_one+0xc1/0xf0
[  819.206025]  [] sysfs_do_create_link+0x135/0x220
[  819.212944]  [] ? sysfs_create_group+0x13/0x20
[  819.219656]  [] sysfs_create_link+0x13/0x20
[  819.226109]  [] bus_add_device+0xe6/0x1b0
[  819.232350]  [] device_add+0x2db/0x460
[  819.238300]  [] edac_create_dimm_object+0x84/0xf0 [edac_core]
[  819.246460]  [] edac_create_sysfs_mci_device+0xe8/0x290 [edac_core]
[  819.255215]  [] edac_mc_add_mc+0x5a/0x2c0 [edac_core]
[  819.262611]  [] sbridge_register_mci+0x1bc/0x279 [sb_edac]
[  819.270493]  [] sbridge_probe+0xef/0x175 [sb_edac]
[  819.277630]  [] ? pm_runtime_enable+0x58/0x90
[  819.284268]  [] local_pci_probe+0x5c/0xd0
[  819.290508]  [] __pci_device_probe+0xf1/0x100
[  819.297117]  [] pci_device_probe+0x3a/0x60
[  819.303457]  [] really_probe+0x73/0x270
[  819.309496]  [] driver_probe_device+0x4e/0xb0
[  819.316104]  [] __driver_attach+0xab/0xb0
[  819.322337]  [] ? driver_probe_device+0xb0/0xb0
[  819.329151]  [] bus_for_each_dev+0x56/0x90
[  819.335489]  [] driver_attach+0x1e/0x20
[  819.341534]  [] bus_add_driver+0x1b0/0x2a0
[  819.347884]  [] ? 0xffffffffa0346fff
[  819.353641]  [] driver_register+0x76/0x140
[  819.359980]  [] ? printk+0x51/0x53
[  819.365524]  [] ? 0xffffffffa0346fff
[  819.371291]  [] __pci_register_driver+0x56/0xd0
[  819.378096]  [] sbridge_init+0x54/0x1000 [sb_edac]
[  819.385231]  [] do_one_initcall+0x3f/0x170
[  819.391577]  [] sys_init_module+0xbe/0x230
[  819.397926]  [] system_call_fastpath+0x16/0x1b
[  819.404633] ---[ end trace 1654fdd39556689f ]---

This happens because the bus is not being properly initialized.
Instead of putting the memory sub-devices inside the memory controller,
it is putting everything under the same directory:

$ tree /sys/bus/edac/
/sys/bus/edac/
├── devices
│   ├── all_channel_counts -> ../../../devices/system/edac/mc/mc0/all_channel_counts
│   ├── csrow0 -> ../../../devices/system/edac/mc/mc0/csrow0
│   ├── csrow1 -> ../../../devices/system/edac/mc/mc0/csrow1
│   ├── csrow2 -> ../../../devices/system/edac/mc/mc0/csrow2
│   ├── dimm0 -> ../../../devices/system/edac/mc/mc0/dimm0
│   ├── dimm1 -> ../../../devices/system/edac/mc/mc0/dimm1
│   ├── dimm3 -> ../../../devices/system/edac/mc/mc0/dimm3
│   ├── dimm6 -> ../../../devices/system/edac/mc/mc0/dimm6
│   ├── inject_addrmatch -> ../../../devices/system/edac/mc/mc0/inject_addrmatch
│   ├── mc -> ../../../devices/system/edac/mc
│   └── mc0 -> ../../../devices/system/edac/mc/mc0
├── drivers
├── drivers_autoprobe
├── drivers_probe
└── uevent

On a multi-memory controller system, the names "csrow%d" and "dimm%d"
should be under "mc%d", and not at the main hierarchy level.

So, we need to create a per-MC bus, in order to have its own namespace.

Reviewed-by: Aristeu Rozanski 
Cc: Doug Thompson 
Cc: Greg K H 
Signed-off-by: Mauro Carvalho Chehab

edac: Drop DATE usage

2011-04-18T22:23:22+00:00

The kernel already prints its build timestamp during boot, no need to
repeat it in random drivers and produce different object files each
time.

Cc: Doug Thompson 
Cc: bluesmoke-devel@lists.sourceforge.net
Cc: linux-edac@vger.kernel.org
Acked-by: Mauro Carvalho Chehab 
Signed-off-by: Michal Marek

EDAC: Export edac sysfs class to users.

2010-10-21T12:47:59+00:00

Move toplevel sysfs class to the stub and make it available to
non-modularized code too. Add proper refcounting of its users and move
the registration functionality into the reference counting routines.

Signed-off-by: Borislav Petkov

Driver core: change sysdev classes to use dynamic kobject names

2008-01-25T04:40:40+00:00

All kobjects require a dynamically allocated name now. We no longer
need to keep track if the name is statically assigned, we can just
unconditionally free() all kobject names on cleanup.

Signed-off-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

drivers/edac: code tidying on export-gpl

2007-07-19T17:04:57+00:00

Change EXPORT_SYMBOLs to EXPORT_SYMBOLS_GPL
Tidy changes: blank lines, inline removal, add comment

Signed-off-by: Doug Thompson 
Cc: Greg KH 
Cc: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/edac: fix edac_mc sysfs completion code