linux-stable.git/drivers/dma, branch linux-3.9.y

drivers/dma/pl330.c: fix locking in pl330_free_chan_resources()

2013-07-21T00:16:08+00:00

commit da331ba8e9c5de72a27e50f71105395bba6eebe0 upstream.

tasklet_kill() may sleep so call it before taking pch->lock.

Fixes following lockup:

  BUG: scheduling while atomic: cat/2383/0x00000002
  Modules linked in:
    unwind_backtrace+0x0/0xfc
    __schedule_bug+0x4c/0x58
    __schedule+0x690/0x6e0
    sys_sched_yield+0x70/0x78
    tasklet_kill+0x34/0x8c
    pl330_free_chan_resources+0x24/0x88
    dma_chan_put+0x4c/0x50
  [...]
  BUG: spinlock lockup suspected on CPU#0, swapper/0/0
   lock: 0xe52aa04c, .magic: dead4ead, .owner: cat/2383, .owner_cpu: 1
    unwind_backtrace+0x0/0xfc
    do_raw_spin_lock+0x194/0x204
    _raw_spin_lock_irqsave+0x20/0x28
    pl330_tasklet+0x2c/0x5a8
    tasklet_action+0xfc/0x114
    __do_softirq+0xe4/0x19c
    irq_exit+0x98/0x9c
    handle_IPI+0x124/0x16c
    gic_handle_irq+0x64/0x68
    __irq_svc+0x40/0x70
    cpuidle_wrap_enter+0x4c/0xa0
    cpuidle_enter_state+0x18/0x68
    cpuidle_idle_call+0xac/0xe0
    cpu_idle+0xac/0xf0

Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Kyungmin Park 
Acked-by: Jassi Brar 
Cc: Vinod Koul 
Cc: Tomasz Figa 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

dmaengine: ste_dma40: fix pm runtime ref counting

2013-06-13T17:49:28+00:00

commit 9ecb41bd8cf002fd8f3e063db4df81647ddd623c upstream.

The pm runtime reference counting of the driver is broken for the case
when there is more than one transfer queued, leading to the device being
runtime suspend while active.  Fix it.

Signed-off-by: Rabin Vincent 
Acked-by: Linus Walleij 
Signed-off-by: Vinod Koul 
Signed-off-by: Greg Kroah-Hartman

pch_dma: Use GFP_ATOMIC because called from interrupt context

2013-05-19T18:38:40+00:00

commit 5c1ef59168c485318e40ba485c1eba57d81d0faa upstream.

pdc_desc_get() is called from pd_prep_slave_sg, and the function is
called from interrupt context(e.g. Uart driver "pch_uart.c").
In fact, I saw kernel error message.
So, GFP_ATOMIC must be used not GFP_NOIO.

Signed-off-by: Tomoya MORINAGA 
Signed-off-by: Vinod Koul 
Signed-off-by: Greg Kroah-Hartman

DMA: OF: Check properties value before running be32_to_cpup() on it

2013-05-19T18:38:15+00:00

commit 9a188eb126aa7bf27077ee46fcb914898d6fc281 upstream.

In of_dma_controller_register() routine we are calling of_get_property() as an
parameter to be32_to_cpup(). In case the property doesn't exist we will get a
crash.

This patch changes this code to check if we got a valid property first and then
runs be32_to_cpup() on it.

Signed-off-by: Viresh Kumar 
Signed-off-by: Vinod Koul 
Signed-off-by: Robert Richter 
Signed-off-by: Greg Kroah-Hartman

dmaengine: at_hdmac: fix race condition in atc_advance_work()

2013-04-18T15:54:22+00:00

The BUG_ON() directive is triggered probably due to a latency
modification following inclusion of commit c10d73671ad3 ("softirq:
reduce latencies").  This condition has not been met before 3.9-rc1 and
doesn't trigger without this patch.

We now make sure that DMA channel is idle before calling
atc_complete_all() which makes the BUG_ON() "protection" useless.

Signed-off-by: Ludovic Desroches 
Signed-off-by: Nicolas Ferre 
Acked-by: Vinod Koul 
Signed-off-by: Linus Torvalds

Merge branch 'fixes' of git://git.infradead.org/users/vkoul/slave-dma

2013-04-12T03:35:11+00:00

Pull slave-dmaengine fixes from Vinod Koul:
 "The first one fixes issue in pl330 to check for DT compatible and
  the second one fixes omap-dma to start without delay"

* 'fixes' of git://git.infradead.org/users/vkoul/slave-dma:
  dmaengine: omap-dma: Start DMA without delay for cyclic channels
  DMA: PL330: Add check if device tree compatible

dmaengine: omap-dma: Start DMA without delay for cyclic channels

2013-04-10T05:03:30+00:00

cyclic DMA is only used by audio which needs DMA to be started without a
delay.
If the DMA for audio is started using the tasklet we experience random
channel switch (to be more precise: channel shift).

Reported-by: Peter Meerwald 
CC: stable@vger.kernel.org  # v3.7+
Signed-off-by: Peter Ujfalusi 
Acked-by: Santosh Shilimkar 
Acked-by: Russell King 
Signed-off-by: Vinod Koul

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux

2013-04-03T17:48:22+00:00

Pull s390 fixes from Martin Schwidefsky:
 "Just a bunch of bugfixes"

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux:
  s390/mm: provide emtpy check_pgt_cache() function
  s390/uaccess: fix page table walk
  s390/3270: fix minor_start issue
  s390/uaccess: fix clear_user_pt()
  s390/scm_blk: fix error return code in scm_blk_init()
  s390/scm_block: fix printk format string
  drivers/Kconfig: add several missing GENERIC_HARDIRQS dependencies

DMA: PL330: Add check if device tree compatible

2013-04-02T17:41:04+00:00

This patch register the dma controller with generic dma helpers only
in DT case. This also adds some extra error handling in the driver.

Signed-off-by: Padmavathi Venna 
Reported-by: Sachin Kamat 
Signed-off-by: Vinod Koul

dw_dmac: adjust slave_id accordingly to request line base

2013-03-29T23:04:07+00:00

On some hardware configurations we have got the request line with the offset.
The patch introduces convert_slave_id() helper for that cases. The request line
base is came from the driver data provided by the platform_device_id table.

Signed-off-by: Mika Westerberg 
Signed-off-by: Andy Shevchenko 
Cc: Viresh Kumar 
Acked-by: Viresh Kumar 
Signed-off-by: Vinod Koul