linux-stable.git/drivers/dma, branch linux-2.6.32.y

dmaengine: fix missing 'cnt' in ?: in dmatest

2015-09-18T11:52:19+00:00

commit d07a74a546981a09ba490936645fbf0d1340b96c upstream.

Hi,
  On the latest tree my compiler has started giving the warning:

drivers/dma/dmatest.c:575:28: warning: the omitted middle operand in ?: will always be ?true?, suggest explicit middle operand [-Wparentheses]

The following patch fixes the missing middle clause with the same
fix that Nicolas Ferre used in the similar clauses.
(There seems to have been a race between him fixing that and
the extra clause going in a little later).

I don't actually know the dmatest code/structures, nor do I own
any hardware to test it on (assuming it needs a DMA engine);
 but this patch builds, the existing code is almost certainly
wrong and the fix is the same as the corresponding lines above it.

(WTH is x=y?:z legal C anyway?)

Signed-off-by: Dr. David Alan Gilbert 
Reported-by: Dan Carpenter 
Reported-by: Paul Gortmaker 
Acked-by: Nicolas Ferre 
Signed-off-by: Dan Williams 
Signed-off-by: Willy Tarreau

dmaengine: mv_xor: bug fix for racing condition in descriptors cleanup

2015-09-18T11:52:10+00:00

commit 9136291f1dbc1d4d1cacd2840fb35f4f3ce16c46 upstream.

This patch fixes a bug in the XOR driver where the cleanup function can be
called and free descriptors that never been processed by the engine (which
result in data errors).

The cleanup function will free descriptors based on the ownership bit in
the descriptors.

Fixes: ff7b04796d98 ("dmaengine: DMA engine driver for Marvell XOR engine")
Signed-off-by: Lior Amsalem 
Signed-off-by: Maxime Ripard 
Reviewed-by: Ofer Heifetz 
Signed-off-by: Vinod Koul 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings 
(cherry picked from commit 26aa1c6949dfef77d3aa77e4cb504ccfd8394ce9)

Signed-off-by: Willy Tarreau

ioat2: kill pending flag

2012-10-07T21:37:11+00:00

commit 281befa5592b0c5f9a3856b5666c62ac66d3d9ee upstream.

The pending == 2 case no longer exists in the driver so, we can use
ioat2_ring_pending() outside the lock to determine if there might be any
descriptors in the ring that the hardware has not seen.

Signed-off-by: Dan Williams 
Backported-by: Mike Galbraith 
Signed-off-by: Willy Tarreau

mv_xor: fix race in tasklet function

2011-01-07T22:43:17+00:00

commit 8333f65ef094e47020cd01452b4637e7daf5a77f upstream.

use mv_xor_slot_cleanup() instead of __mv_xor_slot_cleanup() as the former function
aquires the spin lock that needed to protect the drivers data.

Signed-off-by: Saeed Bishara 
Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

dmaengine: fix interrupt clearing for mv_xor

2010-10-29T04:44:01+00:00

commit cc60f8878eab892c03d06b10f389232b9b66bd83 upstream.

When using simultaneously the two DMA channels on a same engine, some
transfers are never completed. For example, an endless lock can occur
while writing heavily on a RAID5 array (with async-tx offload support
enabled).

Note that this issue can also be reproduced by using the DMA test
client.

On a same engine, the interrupt cause register is shared between two
DMA channels. This patch make sure that the cause bit is only cleared
for the requested channel.

Signed-off-by: Simon Guinot 
Tested-by: Luc Saillard 
Acked-by: saeed bishara 
Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

ioat: fix infinite timeout checking in ioat2_quiesce

2010-02-23T15:37:49+00:00

commit 7e55a70c5b9a57c12f49c44b0847c9343d4f54e4 upstream.

Fix typo in ioat2_quiesce. check 'tmo' is zero, not 'end'.  Also applies
to 2.6.32.3

Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

ioat2,3: put channel hardware in known state at init

2010-01-06T23:03:59+00:00

commit a6d52d70677e99bdb89b6921c265d0a58c22e597 upstream.

Put the ioat2 and ioat3 state machines in the halted state with all
errors cleared.

The ioat1 init path is not disturbed for stability, there are no
reported ioat1 initiaization issues.

Reported-by: Roland Dreier 
Tested-by: Roland Dreier 
Acked-by: Simon Horman 
Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

ioat3: fix p-disabled q-continuation

2010-01-06T23:03:58+00:00

commit cd78809f6191485a90ea6c92c2b58900ab5c156f upstream.

When continuing a pq calculation the driver needs 3 extra sources.  The
driver can perform a 3 source calculation with a single descriptor, but
needs an extended descriptor to process up to 8 sources in one
operation.  However, in the p-disabled case only one extra source is
needed.  When continuing a p-disabled operation there are occasions
(i.e. 0 < src_cnt % 8 < 3) where the tail operation does not need an
extended descriptor.  Properly account for this fact otherwise invalid
'dmacount' values will be written to hardware usually causing the
channel to halt with 'invalid descriptor' errors.

Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

dma: at_hdmac: correct incompatible type for argument 1 of 'spin_lock_bh'

2010-01-06T23:03:51+00:00

commit 4297a462f455e38f08976df7b16c849614a287da upstream.

Correct a typo error in locking calls.

Signed-off-by: Nicolas Ferre 
Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

shdma: fix initialization error handling

2009-11-22T19:10:10+00:00

1/ Error handling code following a kzalloc should free the allocated data.
2/ Report an error when no platform data is detected

Both problems fixed by moving the platform data check before the allocation,
and allows a goto to be killed.

Reported-by: Julia Lawall 
Acked-by: Julia Lawall 
Signed-off-by: Dan Williams