linux-stable.git/drivers/dma/sh, branch v5.3

dmaengine: rcar-dmac: Fix DMACHCLR handling if iommu is mapped

2019-09-04T06:05:58+00:00

The commit 20c169aceb45 ("dmaengine: rcar-dmac: clear pertinence
number of channels") forgets to clear the last channel by
DMACHCLR in rcar_dmac_init() (and doesn't need to clear the first
channel) if iommu is mapped to the device. So, this patch fixes it
by using "channels_mask" bitfield.

Note that the hardware and driver don't support more than 32 bits
in DMACHCLR register anyway, so this patch should reject more than
32 channels in rcar_dmac_parse_of().

Fixes: 20c169aceb459575 ("dmaengine: rcar-dmac: clear pertinence number of channels")
Signed-off-by: Yoshihiro Shimoda 
Reviewed-by: Simon Horman 
Reviewed-by: Geert Uytterhoeven 
Link: https://lore.kernel.org/r/1567424643-26629-1-git-send-email-yoshihiro.shimoda.uh@renesas.com
Signed-off-by: Vinod Koul

dmaengine: rcar-dmac: Reject zero-length slave DMA requests

2019-06-25T04:38:22+00:00

While the .device_prep_slave_sg() callback rejects empty scatterlists,
it still accepts single-entry scatterlists with a zero-length segment.
These may happen if a driver calls dmaengine_prep_slave_single() with a
zero len parameter.  The corresponding DMA request will never complete,
leading to messages like:

    rcar-dmac e7300000.dma-controller: Channel Address Error happen

and DMA timeouts.

Although requesting a zero-length DMA request is a driver bug, rejecting
it early eases debugging.  Note that the .device_prep_dma_memcpy()
callback already rejects requests to copy zero bytes.

Reported-by: Eugeniu Rosca 
Analyzed-by: Yoshihiro Shimoda 
Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Vinod Koul

dmaengine: sh: usb-dmac: Use [] to denote a flexible array member

2019-06-25T04:27:42+00:00

Flexible array members should be denoted using [] instead of [0], else
gcc will not warn when they are no longer at the end of the structure.

Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Simon Horman 
Signed-off-by: Vinod Koul

dmaengine: sh: usb-dmac: Let the core do the device node validation

2019-05-27T05:53:53+00:00

Let the DMA engine core do the device node validation instead of drivers.

Signed-off-by: Baolin Wang 
Signed-off-by: Vinod Koul

dmaengine: sh: rcar-dmac: Let the core do the device node validation

2019-05-27T05:53:53+00:00

Let the DMA engine core do the device node validation instead of drivers.

Signed-off-by: Baolin Wang 
Signed-off-by: Vinod Koul

dmaengine: sudmac: remove unused driver

2019-05-21T04:22:50+00:00

SUDMAC driver was introduced in v3.10 but was never integrated for use
by any platform. As it is unused remove it.

Signed-off-by: Simon Horman 
Acked-by: Yoshihiro Shimoda 
Signed-off-by: Vinod Koul

Merge tag 'dmaengine-5.2-rc1' of git://git.infradead.org/users/vkoul/slave-dma

2019-05-09T15:51:45+00:00

Pull dmaengine updates from Vinod Koul:

 - Updates to stm32 dma residue calculations

 - Interleave dma capability to axi-dmac and support for ZynqMP arch

 - Rework of channel assignment for rcar dma

 - Debugfs for pl330 driver

 - Support for Tegra186/Tegra194, refactoring for new chips and support
   for pause/resume

 - Updates to axi-dmac, bcm2835, fsl-edma, idma64, imx-sdma, rcar-dmac,
   stm32-dma etc

 - dev_get_drvdata() updates on few drivers

* tag 'dmaengine-5.2-rc1' of git://git.infradead.org/users/vkoul/slave-dma: (34 commits)
  dmaengine: tegra210-adma: restore channel status
  dmaengine: tegra210-dma: free dma controller in remove()
  dmaengine: tegra210-adma: add pause/resume support
  dmaengine: tegra210-adma: add support for Tegra186/Tegra194
  Documentation: DT: Add compatibility binding for Tegra186
  dmaengine: tegra210-adma: prepare for supporting newer Tegra chips
  dmaengine: at_xdmac: remove a stray bottom half unlock
  dmaengine: fsl-edma: Adjust indentation
  dmaengine: fsl-edma: Fix typo in Vybrid name
  dmaengine: stm32-dma: fix residue calculation in stm32-dma
  dmaengine: nbpfaxi: Use dev_get_drvdata()
  dmaengine: bcm-sba-raid: Use dev_get_drvdata()
  dmaengine: stm32-dma: Fix unsigned variable compared with zero
  dmaengine: stm32-dma: use platform_get_irq()
  dmaengine: rcar-dmac: Update copyright information
  dmaengine: imx-sdma: Only check ratio on parts that support 1:1
  dmaengine: xgene-dma: fix spelling mistake "descripto" -> "descriptor"
  dmaengine: idma64: Move driver name to the header
  dmaengine: bcm2835: Drop duplicate capability setting.
  dmaengine: pl330: _stop: clear interrupt status
  ...

dmaengine: rcar-dmac: Update copyright information

2019-04-26T11:54:26+00:00

Update copyright and string for Gen3.

Signed-off-by: Hiroyuki Yokoyama 
Signed-off-by: Niklas Söderlund 
Reviewed-by: Simon Horman 
Signed-off-by: Vinod Koul

dmaengine: sh: rcar-dmac: Fix glitch in dmaengine_tx_status

2019-04-23T05:15:34+00:00

The tx_status poll in the rcar_dmac driver reads the status register
which indicates which chunk is busy (DMACHCRB). Afterwards the point
inside the chunk is read from DMATCRB. It is possible that the chunk
has changed between the two reads. The result is a non-monotonous
increase of the residue. Fix this by introducing a 'safe read' logic.

Fixes: 73a47bd0da66 ("dmaengine: rcar-dmac: use TCRB instead of TCR for residue")
Signed-off-by: Achim Dahlhoff 
Signed-off-by: Dirk Behme 
Reviewed-by: Yoshihiro Shimoda 
Cc:  # v4.16+
Signed-off-by: Vinod Koul

dmaengine: sh: rcar-dmac: With cyclic DMA residue 0 is valid

2019-04-23T05:15:26+00:00

Having a cyclic DMA, a residue 0 is not an indication of a completed
DMA. In case of cyclic DMA make sure that dma_set_residue() is called
and with this a residue of 0 is forwarded correctly to the caller.

Fixes: 3544d2878817 ("dmaengine: rcar-dmac: use result of updated get_residue in tx_status")
Signed-off-by: Dirk Behme 
Signed-off-by: Achim Dahlhoff 
Signed-off-by: Hiroyuki Yokoyama 
Signed-off-by: Yao Lihua 
Reviewed-by: Yoshihiro Shimoda 
Reviewed-by: Laurent Pinchart 
Cc:  # v4.8+
Signed-off-by: Vinod Koul