linux-stable.git/drivers/dma/dmatest.c, branch linux-3.9.y

dmaengine/dmatest: terminate transfers only in case of errors

2013-01-08T06:05:07+00:00

dmatest erroneously terminated transfers in normal cases also leading to
test failures for multiple threads over a channel. Fix this and
terminate transfers only in case of errors.

Signed-off-by: Shiraz Hashim 
Signed-off-by: Deepak Sikri 
Signed-off-by: Vinod Koul

dmatest: Fix NULL pointer dereference on ioat

2013-01-08T06:05:05+00:00

device_control is an optional and not implemented in all DMA drivers.
Any calls to these will result in a NULL pointer dereference.  dmatest
makes two of these calls when completing the kernel thread and removing
the module.  These are corrected by calling the dmaengine_device_control
wrapper and checking for a non-existant device_control function pointer
there.

Signed-off-by: Jon Mason 
CC: Vinod Koul 
CC: Dan Williams 
Reviewed-by: Viresh Kumar 
Signed-off-by: Vinod Koul

dmatest: adjust invalid module parameters for number of source buffers

2013-01-08T06:04:55+00:00

DMA Engine test module has module parameters to set the number of source
buffers for xor and pq operations.  We can set these values larger than the
maximum number of sources that the device can support.  These values are
not adjusted and the unsupported number of source buffers are passed to the
device.  But most drivers don't check it, so unexpected results will happen.

This makes an appropriate adjustment for these module parameters before use.

Signed-off-by: Akinobu Mita 
Cc: Vinod Koul 
Cc: Dan Williams 
Signed-off-by: Vinod Koul

dmatest: check for dma mapping error

2012-12-18T01:15:13+00:00

The kernel emits a warning if CONFIG_DMA_API_DEBUG=y:

  WARNING: at lib/dma-debug.c:933 check_unmap+0x5d6/0x6ac()
  dw_dmac dw_dmac.0: DMA-API: device driver failed to check map error[device address=0x0000000035698305] [size=14365 bytes] [mapped as single]

Fix this by adding the required checking of the dma_map_single() return
value.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Viresh Kumar 
Cc: Vinod Koul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dmatest: implement two helpers to unmap dma memory

2012-12-18T01:15:13+00:00

The unmap_src() and unmap_dst() will be used later as well.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Viresh Kumar 
Cc: Vinod Koul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dmaengine: fix missing 'cnt' in ?: in dmatest

2012-01-23T19:43:18+00:00

Hi,
  On the latest tree my compiler has started giving the warning:

drivers/dma/dmatest.c:575:28: warning: the omitted middle operand in ?: will always be ?true?, suggest explicit middle operand [-Wparentheses]

The following patch fixes the missing middle clause with the same
fix that Nicolas Ferre used in the similar clauses.
(There seems to have been a race between him fixing that and
the extra clause going in a little later).

I don't actually know the dmatest code/structures, nor do I own
any hardware to test it on (assuming it needs a DMA engine);
 but this patch builds, the existing code is almost certainly
wrong and the fix is the same as the corresponding lines above it.

(WTH is x=y?:z legal C anyway?)

Signed-off-by: Dr. David Alan Gilbert 
Reported-by: Dan Carpenter 
Reported-by: Paul Gortmaker 
Acked-by: Nicolas Ferre 
Signed-off-by: Dan Williams

dmatest: don't use set_freezable_with_signal()

2011-11-23T17:28:16+00:00

Commit 981ed70d8e (dmatest: make dmatest threads freezable) made
dmatest kthread use set_freezable_with_signal(); however, the
interface is scheduled to be removed in the next merge window.

The problem is that unlike userland tasks there's no default place
which handles signal pending state and it isn't clear who owns and/or
is responsible for clearing TIF_SIGPENDING.  For example, in the
current code, try_to_freeze() clears TIF_SIGPENDING but it isn't sure
whether it actually owns the TIF_SIGPENDING nor is it race-free -
ie. the task may continue to run with TIF_SIGPENDING set after the
freezable section.

Unfortunately, we don't have wait_for_completion_freezable_timeout().
This patch open codes it and uses wait_event_freezable_timeout()
instead and removes timeout reloading - wait_event_freezable_timeout()
won't return across freezing events (currently racy but fix scheduled)
and timer doesn't decrement while the task is in freezer.  Although
this does lose timer-reset-over-freezing, given that timeout is
supposed to be long enough and failure to finish inside is considered
irrecoverable, I don't think this is worth the complexity.

While at it, move completion to outer scope and explain that we're
ignoring dangling pointer problem after timeout.  This should give
slightly better chance at avoiding oops after timeout.

Signed-off-by: Tejun Heo 
Acked-by: Dan Williams 
Cc: Guennadi Liakhovetski 
Cc: Nicolas Ferre

dmatest: make dmatest threads freezable

2011-08-29T12:31:27+00:00

Making dmatest threads freezable allows its use for system PM testing.

Signed-off-by: Guennadi Liakhovetski 
Acked-by: Dan Williams 
Signed-off-by: Vinod Koul

dmaengine/dmatest: Terminate transfers on all channels in case of error or exit

2011-08-08T14:02:01+00:00

In case, some error occurs while doing memcpy transfers, we must terminate all
transfers physically too. This is achieved by calling device_control() routine
with TERMINATE_ALL as parameter.

This is also required to be done in case module is removed while we are in
middle of some transfers.

Signed-off-by: Viresh Kumar 
Signed-off-by: Vinod Koul

net: remove mm.h inclusion from netdevice.h

2011-06-22T02:17:20+00:00

Remove linux/mm.h inclusion from netdevice.h -- it's unused (I've checked manually).

To prevent mm.h inclusion via other channels also extract "enum dma_data_direction"
definition into separate header. This tiny piece is what gluing netdevice.h with mm.h
via "netdevice.h => dmaengine.h => dma-mapping.h => scatterlist.h => mm.h".
Removal of mm.h from scatterlist.h was tried and was found not feasible
on most archs, so the link was cutoff earlier.

Hope people are OK with tiny include file.

Note, that mm_types.h is still dragged in, but it is a separate story.

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller