linux-stable.git/drivers/devfreq/devfreq.c, branch v5.15.136

PM / devfreq: Fix leak in devfreq_dev_release()

2023-09-19T10:22:50+00:00

commit 5693d077595de721f9ddbf9d37f40e5409707dfe upstream.

srcu_init_notifier_head() allocates resources that need to be released
with a srcu_cleanup_notifier_head() call.

Reported by kmemleak.

Fixes: 0fe3a66410a3 ("PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER notifier")
Cc: 
Signed-off-by: Boris Brezillon 
Reviewed-by: Dhruva Gole 
Signed-off-by: Chanwoo Choi 
Signed-off-by: Greg Kroah-Hartman

PM/devfreq: governor: Add a private governor_data for governor

2023-01-12T10:58:51+00:00

commit 5fdded8448924e3631d466eea499b11606c43640 upstream.

The member void *data in the structure devfreq can be overwrite
by governor_userspace. For example:
1. The device driver assigned the devfreq governor to simple_ondemand
by the function devfreq_add_device() and init the devfreq member
void *data to a pointer of a static structure devfreq_simple_ondemand_data
by the function devfreq_add_device().
2. The user changed the devfreq governor to userspace by the command
"echo userspace > /sys/class/devfreq/.../governor".
3. The governor userspace alloced a dynamic memory for the struct
userspace_data and assigend the member void *data of devfreq to
this memory by the function userspace_init().
4. The user changed the devfreq governor back to simple_ondemand
by the command "echo simple_ondemand > /sys/class/devfreq/.../governor".
5. The governor userspace exited and assigned the member void *data
in the structure devfreq to NULL by the function userspace_exit().
6. The governor simple_ondemand fetched the static information of
devfreq_simple_ondemand_data in the function
devfreq_simple_ondemand_func() but the member void *data of devfreq was
assigned to NULL by the function userspace_exit().
7. The information of upthreshold and downdifferential is lost
and the governor simple_ondemand can't work correctly.

The member void *data in the structure devfreq is designed for
a static pointer used in a governor and inited by the function
devfreq_add_device(). This patch add an element named governor_data
in the devfreq structure which can be used by a governor(E.g userspace)
who want to assign a private data to do some private things.

Fixes: ce26c5bb9569 ("PM / devfreq: Add basic governors")
Cc: stable@vger.kernel.org # 5.10+
Reviewed-by: Chanwoo Choi 
Acked-by: MyungJoo Ham 
Signed-off-by: Kant Fan 
Signed-off-by: Chanwoo Choi 
Signed-off-by: Greg Kroah-Hartman

devfreq: use HZ macros

2021-09-08T18:50:26+00:00

HZ unit conversion macros are available in units.h, use them and remove
the duplicate definition.

The new macro has an unsigned long type.

All the code is dealing with unsigned long and the code using the macro is
doing a coercitive cast to unsigned long.

Link: https://lkml.kernel.org/r/20210816114732.1834145-5-daniel.lezcano@linaro.org
Signed-off-by: Daniel Lezcano 
Reviewed-by: Christian Eggers 
Reviewed-by: Andy Shevchenko 
Acked-by: Chanwoo Choi 
Cc: Guenter Roeck 
Cc: Jonathan Cameron 
Cc: Jonathan Cameron 
Cc: Kyungmin Park 
Cc: Lars-Peter Clausen 
Cc: Lukasz Luba 
Cc: Maxime Coquelin 
Cc: Miquel Raynal 
Cc: MyungJoo Ham 
Cc: Peter Meerwald 
Cc: "Rafael J. Wysocki" 
Cc: Zhang Rui 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

PM / devfreq: Add missing error code in devfreq_add_device()

2021-05-20T03:16:41+00:00

Set err code in the error path before jumping to the end of the function.

Fixes: 4dc3bab8687f ("PM / devfreq: Add support delayed timer for polling mode")
Signed-off-by: YueHaibing 
Signed-off-by: Chanwoo Choi

PM / devfreq: Use more accurate returned new_freq as resume_freq

2021-04-08T04:14:45+00:00

Use the more accurate returned new_freq as resume_freq.
It's the same as how devfreq->previous_freq was updated.

Fixes: 83f8ca45afbf0 ("PM / devfreq: add support for suspend/resume of a devfreq device")
Signed-off-by: Dong Aisheng 
Signed-off-by: Chanwoo Choi

PM / devfreq: Unlock mutex and free devfreq struct in error path

2021-04-08T04:14:45+00:00

The devfreq->lock is held for time of setup. Release the lock in the
error path, before jumping to the end of the function.

Change the goto destination which frees the allocated memory.

Cc: v5.9+  # v5.9+
Fixes: 4dc3bab8687f ("PM / devfreq: Add support delayed timer for polling mode")
Signed-off-by: Lukasz Luba 
Signed-off-by: Chanwoo Choi

PM / devfreq: Register devfreq as a cooling device on demand

2021-03-09T06:40:16+00:00

Currently the default behavior is to manually having the devfreq
backend to register themselves as a devfreq cooling device.

Instead of adding the code in the drivers for the thermal cooling
device registering, let's provide a flag in the devfreq's profile to
tell the common devfreq code to register the newly created devfreq as
a cooling device.

Suggested-by: Chanwoo Choi 
Signed-off-by: Daniel Lezcano 
Reviewed-by: Steven Price 
Reviewed-by: Lukasz Luba 
Signed-off-by: Chanwoo Choi

Merge branches 'pm-devfreq' and 'pm-tools'

2021-02-15T16:02:04+00:00

* pm-devfreq:
  PM / devfreq: rk3399_dmc: Remove unneeded semicolon
  PM / devfreq: Replace devfreq->dev.parent as dev in devfreq_add_device
  PM / devfreq: Correct spelling in a comment

* pm-tools:
  cpupower: Add cpuid cap flag for MSR_AMD_HWCR support
  cpupower: Remove family arg to decode_pstates()
  cpupower: Condense pstate enabled bit checks in decode_pstates()
  cpupower: Update family checks when decoding HW pstates
  cpupower: Remove unused pscur variable.
  cpupower: Add CPUPOWER_CAP_AMD_HW_PSTATE cpuid caps flag
  cpupower: Correct macro name for CPB caps flag
  cpupower: Update msr_pstate union struct naming
  cpupower: add Makefile dependencies for install targets

PM / devfreq: Cache OPP table reference in devfreq

2021-02-04T11:06:28+00:00

The OPP table can be used often in devfreq. Trying to get it each time can
be expensive, so cache it in the devfreq struct.

Signed-off-by: Saravana Kannan 
Acked-by: MyungJoo Ham 
Acked-by: Chanwoo Choi 
Signed-off-by: Hsin-Yi Wang 
[ Viresh: Added a blank line ]
Signed-off-by: Viresh Kumar

PM / devfreq: Replace devfreq->dev.parent as dev in devfreq_add_device

2021-01-05T01:05:41+00:00

In devfreq_add_device, replace devfreq->dev.parent
as dev to keep code simple.

Signed-off-by: pierre Kuo 
Signed-off-by: Chanwoo Choi