linux-stable.git/drivers/crypto/inside-secure, branch linux-4.15.y

crypto: inside-secure - fix clock management

2018-04-08T12:27:38+00:00

commit f962eb46e7a9b98a58d2483f5eb216e738fec732 upstream.

In this driver the clock is got but never put when the driver is removed
or if there is an error in the probe.

Using the managed version of clk_get() allows to let the kernel take care
of it.

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto
engine driver")
cc: stable@vger.kernel.org
Signed-off-by: Gregory CLEMENT 
Signed-off-by: Herbert Xu 
Signed-off-by: Greg Kroah-Hartman

crypto: inside-secure - avoid unmapping DMA memory that was not mapped

2018-02-03T16:58:33+00:00

commit c957f8b3e2e54b29f53ef69decc87bbc858c9b58 upstream.

This patch adds a parameter in the SafeXcel ahash request structure to
keep track of the number of SG entries mapped. This allows not to call
dma_unmap_sg() when dma_map_sg() wasn't called in the first place. This
also removes a warning when the debugging of the DMA-API is enabled in
the kernel configuration: "DMA-API: device driver tries to free DMA
memory it has not allocated".

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu 
Signed-off-by: Greg Kroah-Hartman

crypto: inside-secure - fix hash when length is a multiple of a block

2018-02-03T16:58:32+00:00

commit 809778e02cd45d0625439fee67688f655627bb3c upstream.

This patch fixes the hash support in the SafeXcel driver when the update
size is a multiple of a block size, and when a final call is made just
after with a size of 0. In such cases the driver should cache the last
block from the update to avoid handling 0 length data on the final call
(that's a hardware limitation).

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu 
Signed-off-by: Greg Kroah-Hartman

crypto: inside-secure - do not use areq->result for partial results

2017-12-22T08:48:01+00:00

This patches update the SafeXcel driver to stop using the crypto
ahash_request result field for partial results (i.e. on updates).
Instead the driver local safexcel_ahash_req state field is used, and
only on final operations the ahash_request result buffer is updated.

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - fix request allocations in invalidation path

2017-12-22T08:48:00+00:00

This patch makes use of the SKCIPHER_REQUEST_ON_STACK and
AHASH_REQUEST_ON_STACK helpers to allocate enough memory to contain both
the crypto request structures and their embedded context (__ctx).

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Suggested-by: Ofer Heifetz 
Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - free requests even if their handling failed

2017-12-22T08:48:00+00:00

This patch frees the request private data even if its handling failed,
as it would never be freed otherwise.

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Suggested-by: Ofer Heifetz 
Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - per request invalidation

2017-12-22T08:47:59+00:00

When an invalidation request is needed we currently override the context
.send and .handle_result helpers. This is wrong as under high load other
requests can already be queued and overriding the context helpers will
make them execute the wrong .send and .handle_result functions.

This commit fixes this by adding a needs_inv flag in the request to
choose the action to perform when sending requests or handling their
results. This flag will be set when needed (i.e. when the context flag
will be set).

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Ofer Heifetz 
[Antoine: commit message, and removed non related changes from the
original commit]
Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - remove null check before kfree

2017-09-22T09:43:25+00:00

Kfree on NULL pointer is a no-op and therefore checking is redundant.

Signed-off-by: Himanshu Jha 
Signed-off-by: Herbert Xu

crypto: inside-secure - fix gcc-4.9 warnings

2017-09-20T09:42:41+00:00

All older compiler versions up to gcc-4.9 produce these
harmless warnings:

drivers/crypto/inside-secure/safexcel_cipher.c:389:9: warning: missing braces around initializer [-Wmissing-braces]
drivers/crypto/inside-secure/safexcel_cipher.c:389:9: warning: (near initialization for ‘result.completion’) [-Wmissing-braces]
drivers/crypto/inside-secure/safexcel_hash.c:422:9: warning: missing braces around initializer [-Wmissing-braces]
drivers/crypto/inside-secure/safexcel_hash.c:422:9: warning: (near initialization for ‘result.completion’) [-Wmissing-braces]

This changes the syntax to something that works on all versions
without warnings.

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Arnd Bergmann 
Acked-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - fix an error handling path in safexcel_probe()

2017-08-22T06:54:55+00:00

'ret' is known to be 0 at this point.
If 'safexcel_request_ring_irq()' fails, it returns an error code.
Return this value instead of 0 which means success.

Signed-off-by: Christophe JAILLET 
Signed-off-by: Herbert Xu