linux-stable.git/drivers/crypto/ccree, branch v5.3.8

crypto: ccree - use the full crypt length value

2019-10-11T16:36:05+00:00

commit 7a4be6c113c1f721818d1e3722a9015fe393295c upstream.

In case of AEAD decryption verifcation error we were using the
wrong value to zero out the plaintext buffer leaving the end of
the buffer with the false plaintext.

Signed-off-by: Gilad Ben-Yossef 
Fixes: ff27e85a85bb ("crypto: ccree - add AEAD support")
CC: stable@vger.kernel.org # v4.17+
Signed-off-by: Herbert Xu 
Signed-off-by: Greg Kroah-Hartman

crypto: ccree - account for TEE not ready to report

2019-10-11T16:36:04+00:00

commit 76a95bd8f9e10cade9c4c8df93b5c20ff45dc0f5 upstream.

When ccree driver runs it checks the state of the Trusted Execution
Environment CryptoCell driver before proceeding. We did not account
for cases where the TEE side is not ready or not available at all.
Fix it by only considering TEE error state after sync with the TEE
side driver.

Signed-off-by: Gilad Ben-Yossef 
Fixes: ab8ec9658f5a ("crypto: ccree - add FIPS support")
CC: stable@vger.kernel.org # v4.17+
Signed-off-by: Herbert Xu 
Signed-off-by: Greg Kroah-Hartman

crypto: ccree - add HW engine config check

2019-06-27T06:28:00+00:00

Add check to verify the stated device tree HW configuration
matches the HW.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Herbert Xu

crypto: ccree - prevent isr handling in case driver is suspended

2019-06-27T06:28:00+00:00

ccree irq may be shared with other devices, in order to prevent ccree isr
handling while device maybe suspended we added a check to verify that the
device is not suspended.

Signed-off-by: Ofir Drang 
Signed-off-by: Herbert Xu

crypto: ccree - check that cryptocell reset completed

2019-06-27T06:28:00+00:00

In case of driver probe and pm resume we need to check that the cryptocell
hardware reset cycle is completed. during the reset cycle that Cryptocell
provide read only access to the APB interface which allows to verify
through the CC registers that the reset is completed. Until reset
completion we assume that any write/crypto operation is blocked.

Signed-off-by: Ofir Drang 
Signed-off-by: Herbert Xu

crypto: ccree - Relocate driver irq registration after clk init

2019-06-27T06:28:00+00:00

Signed-off-by: Ofir Drang 
Signed-off-by: Herbert Xu

crypto: ccree - use a proper le32 type for le32 val

2019-05-03T06:03:30+00:00

We build an explicit little endian value from the IDR register
values. Use a proper le32 type to mark the var as such to
satisfy Sparse.

Signed-off-by: Gilad Ben-Yossef 
Reported-by: kbuild test robot 
Fixes: dcf6285d18ea1 ("crypto: ccree - add CID and PID support")
Signed-off-by: Herbert Xu

crypto: ccree - remove set but not used variable 'du_size'

2019-05-03T06:03:30+00:00

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/crypto/ccree/cc_cipher.c: In function cc_setup_key_desc:
drivers/crypto/ccree/cc_cipher.c:645:15: warning: variable du_size set but not used [-Wunused-but-set-variable]

It is never used since introduction in
commit dd8486c75085 ("crypto: ccree - move key load desc. before flow desc.")

Signed-off-by: YueHaibing 
Signed-off-by: Herbert Xu

crypto: ccree - Make cc_sec_disable static

2019-05-03T06:03:30+00:00

Fix sparse warning:

drivers/crypto/ccree/cc_driver.c:37:6: warning:
 symbol 'cc_sec_disable' was not declared. Should it be static?

Signed-off-by: YueHaibing 
Signed-off-by: Herbert Xu

crypto: ccree - fix spelling mistake "protedcted" -> "protected"

2019-05-03T06:03:30+00:00

There is a spelling mistake in a dev_dbg message, fix it.

Signed-off-by: Colin Ian King 
Acked-By: Gilad Ben-Yossef 
Signed-off-by: Herbert Xu