linux-stable.git/drivers/crypto/ccree/cc_cipher.c, branch linux-5.7.y

crypto: ccree - fix resource leak on error path

2020-08-19T06:23:27+00:00

[ Upstream commit 9bc6165d608d676f05d8bf156a2c9923ee38d05b ]

Fix a small resource leak on the error path of cipher processing.

Signed-off-by: Gilad Ben-Yossef 
Fixes: 63ee04c8b491e ("crypto: ccree - add skcipher support")
Cc: Markus Elfring 
Signed-off-by: Herbert Xu 
Signed-off-by: Sasha Levin

crypto: ccree - remove ancient TODO remarks

2020-03-12T12:00:16+00:00

Remove left over ancient and now misleading TODO remarks.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Herbert Xu

crypto: ccree - use devm_k[mz]alloc() for cipher data

2020-02-22T01:25:46+00:00

As the lifetime of the cipher data matches the lifetime of the driver,
cipher data can be allocated using the managed allocators.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - use devm_k[mz]alloc() for AEAD data

2020-02-22T01:25:46+00:00

As the lifetime of the AEAD data matches the lifetime of the driver,
AEAD data can be allocated using the managed allocators.
While at it, simplify cc_aead_free() by removing an unneeded cast, and
an unneeded check (aead_handle is always valid here).

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - remove struct cc_cipher_handle

2020-02-22T01:25:45+00:00

The cc_cipher_handle structure contains only a single member, and only
one instance exists.  Simplify the code and reduce memory consumption by
moving this member to struct cc_drvdata.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - use u32 for SRAM addresses

2020-02-22T01:25:44+00:00

SRAM addresses are small integer offsets into local SRAM.  Currently
they are stored using a mixture of cc_sram_addr_t (u64), u32, and
dma_addr_t types.

Settle on u32, and remove the cc_sram_addr_t typedefs.
This allows to drop several casts.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - remove unneeded casts

2020-02-22T01:25:43+00:00

Unneeded casts prevent the compiler from performing valuable checks.
This is especially true for function pointers.

Remove these casts, to prevent silently introducing bugs when a
variable's type might be changed in the future.

No change in generated code.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Herbert Xu

crypto: ccree - remove set but not used variable 'du_size'

2020-02-13T09:05:25+00:00

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/crypto/ccree/cc_cipher.c: In function 'cc_setup_state_desc':
drivers/crypto/ccree/cc_cipher.c:536:15: warning:
 variable 'du_size' set but not used [-Wunused-but-set-variable]

commit 5c83e8ec4d51 ("crypto: ccree - fix FDE descriptor sequence")
involved this unused variable, so remove it.

Reported-by: Hulk Robot 
Signed-off-by: YueHaibing 
Signed-off-by: Herbert Xu

crypto: ccree - fix some reported cipher block sizes

2020-02-13T09:05:24+00:00

OFB and CTR modes block sizes were wrongfully reported as
the underlying block sizes. Fix it to 1 bytes as they
turn the block ciphers into stream ciphers.

Also document why our XTS differes from the generic
implementation.

Signed-off-by: Gilad Ben-Yossef 
Signed-off-by: Herbert Xu

crypto: ccree - fix FDE descriptor sequence

2020-01-22T08:21:10+00:00

In FDE mode (xts, essiv and bitlocker) the cryptocell hardware requires
that the the XEX key will be loaded after Key1.

Signed-off-by: Ofir Drang 
Cc: stable@vger.kernel.org
Signed-off-by: Herbert Xu