linux-stable.git/drivers/crypto/ccp, branch v6.7.2

crypto: ccp - fix memleak in ccp_init_dm_workarea

2024-01-25T23:44:41+00:00

[ Upstream commit a1c95dd5bc1d6a5d7a75a376c2107421b7d6240d ]

When dma_map_single() fails, wa->address is supposed to be freed
by the callers of ccp_init_dm_workarea() through ccp_dm_free().
However, many of the call spots don't expect to have to call
ccp_dm_free() on failure of ccp_init_dm_workarea(), which may
lead to a memleak. Let's free wa->address in ccp_init_dm_workarea()
when dma_map_single() fails.

Fixes: 63b945091a07 ("crypto: ccp - CCP device driver and interface support")
Signed-off-by: Dinghao Liu 
Acked-by: Tom Lendacky 
Signed-off-by: Herbert Xu 
Signed-off-by: Sasha Levin

crypto: ccp/sp - Convert to platform remove callback returning void

2023-10-27T10:04:26+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Acked-by: Tom Lendacky 
Signed-off-by: Herbert Xu

crypto: ccp - Dump SEV command buffer registers on SEV command error

2023-10-20T05:39:26+00:00

PSP firmware may report additional error information in the SEV command
buffer registers in situations where an error occurs as the result of an
SEV command.  In this case, check if the command buffer registers have been
modified and if so, dump the contents.

Signed-off-by: John Allen 
Reviewed-by: Mario Limonciello 
Reviewed-by: Tom Lendacky 
Signed-off-by: Herbert Xu

crypto: ccp - Add support for DBC over PSP mailbox

2023-09-15T10:29:46+00:00

On some SOCs DBC is supported through the PSP mailbox instead of
the platform mailbox. This capability is advertised in the PSP
capabilities register. Allow using this communication path if
supported.

Signed-off-by: Mario Limonciello 
Signed-off-by: Herbert Xu

crypto: ccp - Add a macro to check capabilities register

2023-09-15T10:29:46+00:00

Offsets are checked by the capabilities register in multiple places.
To make the code more readable add a macro.

Signed-off-by: Mario Limonciello 
Signed-off-by: Herbert Xu

crypto: ccp - Add a communication path abstraction for DBC

2023-09-15T10:29:45+00:00

DBC is currently accessed only from the platform access mailbox and
a lot of that implementation's communication path is intertwined
with DBC. Add an abstraction layer for pointers into the mailbox.

No intended functional changes.

Signed-off-by: Mario Limonciello 
Signed-off-by: Herbert Xu

crypto: ccp - Add support for extended PSP mailbox commands

2023-09-15T10:29:45+00:00

The PSP mailbox supports a number of extended sub-commands.  These
subcommands are placed in the header of the buffer sent to the mailbox.

Signed-off-by: Mario Limonciello 
Signed-off-by: Herbert Xu

crypto: ccp - Move direct access to some PSP registers out of TEE

2023-09-15T10:29:45+00:00

With the PSP mailbox registers supporting more than just TEE, access to
them must be maintained and serialized by the PSP device support. Remove
TEE support direct access and create an interface in the PSP support
where the register access can be controlled/serialized.

Signed-off-by: Tom Lendacky 
Signed-off-by: Mario Limonciello 
Reviewed-by: Rijo Thomas 
Tested-by: Rijo Thomas 
Signed-off-by: Herbert Xu

crypto: ccp - Get a free page to use while fetching initial nonce

2023-09-15T10:29:45+00:00

dbc_dev_init() gets a free page from `GFP_KERNEL`, but if that page has
any data in it the first nonce request will fail.
This prevents dynamic boost control from probing. To fix this, explicitly
request a zeroed page with `__GFP_ZERO` to ensure first nonce fetch works.

Fixes: c04cf9e14f10 ("crypto: ccp - Add support for fetching a nonce for dynamic boost control")
Signed-off-by: Mario Limonciello 
Signed-off-by: Herbert Xu

crypto: ccp - Add support for getting and setting DBC parameters

2023-07-20T10:14:21+00:00

After software has authenticated a dynamic boost control request,
it can fetch and set supported parameters using a selection of messages.

Add support for these messages and export the ability to do this to
userspace.

Acked-by: Tom Lendacky 
Signed-off-by: Mario Limonciello 
Signed-off-by: Herbert Xu