linux-stable.git/drivers/crypto/ccp, branch linux-5.17.y

crypto: ccp - Fix the INIT_EX data file open failure

2022-06-09T08:26:04+00:00

[ Upstream commit 05def5cacfa0bd5ba380116046747da07ff5bd78 ]

There are 2 common cases when INIT_EX data file might not be
opened successfully and fail the sev initialization:

1. In user namespaces, normal user tasks (e.g. VMM) can change their
   current->fs->root to point to arbitrary directories. While
   init_ex_path is provided as a module param related to root file
   system. Solution: use the root directory of init_task to avoid
   accessing the wrong file.

2. Normal user tasks (e.g. VMM) don't have the privilege to access
   the INIT_EX data file. Solution: open the file as root and
   restore permissions immediately.

Fixes: 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")
Signed-off-by: Jacky Li 
Reviewed-by: Peter Gonda 
Acked-by: Tom Lendacky 
Signed-off-by: Herbert Xu 
Signed-off-by: Sasha Levin

crypto: ccp - ccp_dmaengine_unregister release dma channels

2022-04-08T11:57:37+00:00

[ Upstream commit 54cce8ecb9254f971b40a72911c6da403720a2d2 ]

ccp_dmaengine_register adds dma_chan->device_node to dma_dev->channels list
but ccp_dmaengine_unregister didn't remove them.
That can cause crashes in various dmaengine methods that tries to use dma_dev->channels

Fixes: 58ea8abf4904 ("crypto: ccp - Register the CCP as a DMA...")
Signed-off-by: Dāvis Mosāns 
Acked-by: John Allen 
Signed-off-by: Herbert Xu 
Signed-off-by: Sasha Levin

crypto: ccp - Ensure psp_ret is always init'd in __sev_platform_init_locked()

2022-04-08T11:57:32+00:00

[ Upstream commit 1e1ec11d3ec3134e05d4710f4dee5f9bd05e828d ]

Initialize psp_ret inside of __sev_platform_init_locked() because there
are many failure paths with PSP initialization that do not set
__sev_do_cmd_locked().

Fixes: e423b9d75e77: ("crypto: ccp - Move SEV_INIT retry for corrupted data")

Signed-off-by: Peter Gonda 
Reported-by: Dan Carpenter 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Herbert Xu 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu 
Signed-off-by: Sasha Levin

crypto: ccp - remove unneeded semicolon

2021-12-31T07:10:55+00:00

Eliminate the following coccicheck warning:
./drivers/crypto/ccp/sev-dev.c:263:2-3: Unneeded semicolon

Reported-by: Abaci Robot 
Signed-off-by: Yang Li 
Signed-off-by: Herbert Xu

crypto: ccp - Add SEV_INIT_EX support

2021-12-17T05:59:47+00:00

Add new module parameter to allow users to use SEV_INIT_EX instead of
SEV_INIT. This helps users who lock their SPI bus to use the PSP for SEV
functionality. The 'init_ex_path' parameter defaults to NULL which means
the kernel will use SEV_INIT, if a path is specified SEV_INIT_EX will be
used with the data found at the path. On certain PSP commands this
file is written to as the PSP updates the NV memory region. Depending on
file system initialization this file open may fail during module init
but the CCP driver for SEV already has sufficient retries for platform
initialization. During normal operation of PSP system and SEV commands
if the PSP has not been initialized it is at run time. If the file at
'init_ex_path' does not exist the PSP will not be initialized. The user
must create the file prior to use with 32Kb of 0xFFs per spec.

Signed-off-by: David Rientjes 
Co-developed-by: Peter Gonda 
Signed-off-by: Peter Gonda 
Reviewed-by: Marc Orr 
Reported-by: kernel test robot 
Acked-by: Brijesh Singh 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Joerg Roedel 
Cc: Herbert Xu 
Cc: David Rientjes 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: Paolo Bonzini 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: ccp - Add psp_init_on_probe module parameter

2021-12-17T05:59:47+00:00

Add psp_init_on_probe module parameter that allows for skipping the
PSP's SEV platform initialization during module init. User may decouple
module init from PSP init due to use of the INIT_EX support in upcoming
patch which allows for users to save PSP's internal state to file. The
file may be unavailable at module init.

Also moves the PSP ABI version log message to after successful PSP init
instead of module init in case this new parameter is used.

Signed-off-by: Peter Gonda 
Acked-by: Brijesh Singh 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Joerg Roedel 
Cc: Herbert Xu 
Cc: David Rientjes 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: Paolo Bonzini 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: ccp - Refactor out sev_fw_alloc()

2021-12-17T05:59:47+00:00

Create a helper function sev_fw_alloc() which can be used to allocate
aligned memory regions for use by the PSP firmware. Currently only used
for the SEV-ES TMR region but will be used for the SEV_INIT_EX NV memory
region.

Signed-off-by: Peter Gonda 
Reviewed-by: Marc Orr 
Acked-by: David Rientjes 
Acked-by: Brijesh Singh 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Joerg Roedel 
Cc: Herbert Xu 
Cc: David Rientjes 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: Paolo Bonzini 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: ccp - Move SEV_INIT retry for corrupted data

2021-12-17T05:59:46+00:00

Move the data corrupted retry of SEV_INIT into the
__sev_platform_init_locked() function. This is for upcoming INIT_EX
support as well as helping direct callers of
__sev_platform_init_locked() which currently do not support the
retry.

Signed-off-by: Peter Gonda 
Reviewed-by: Marc Orr 
Acked-by: David Rientjes 
Acked-by: Tom Lendacky 
Acked-by: Brijesh Singh 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Joerg Roedel 
Cc: Herbert Xu 
Cc: David Rientjes 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: Paolo Bonzini 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: ccp - Add SEV_INIT rc error logging on init

2021-12-17T05:59:46+00:00

Currently only the firmware error code is printed. This is incomplete
and also incorrect as error cases exists where the firmware is never
called and therefore does not set an error code.

Signed-off-by: Peter Gonda 
Reviewed-by: Marc Orr 
Acked-by: David Rientjes 
Acked-by: Tom Lendacky 
Acked-by: Brijesh Singh 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Joerg Roedel 
Cc: Herbert Xu 
Cc: David Rientjes 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: Paolo Bonzini 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: ccp - no need to initialise statics to 0

2021-11-20T04:06:38+00:00

Static variables do not need to be initialized to 0.

Signed-off-by: Jason Wang 
Signed-off-by: Herbert Xu