linux-stable.git/drivers/crypto/caam, branch v6.4

crypto: caam - OP-TEE firmware support

2023-04-14T10:59:34+00:00

caam driver needs to be aware of OP-TEE f/w presence, since some things
are done differently:

1. there is no access to controller's register page (note however that
some registers are aliased in job rings' register pages)

2 Due to this, MCFGR[PS] cannot be read and driver assumes
MCFGR[PS] = b'0 - engine using 32-bit address pointers.

This is in sync with the fact that:
-all i.MX SoCs currently use MCFGR[PS] = b'0
-only i.MX OP-TEE use cases don't allow access to controller register page

Signed-off-by: Horia GeantA 
Signed-off-by: Meenakshi Aggarwal 
Reviewed-by: Gaurav Jain 
Signed-off-by: Herbert Xu

crypto: caam - reduce page 0 regs access to minimum

2023-04-14T10:59:34+00:00

Use job ring register map, in place of controller register map
to access page 0 registers, as access to the controller register
map is not permitted.

Signed-off-by: Horia GeantA 
Signed-off-by: Gaurav Jain 
Signed-off-by: Meenakshi Aggarwal 
Reviewed-by: Varun Sethi 
Reviewed-by: Gaurav Jain 
Signed-off-by: Herbert Xu

crypto: caam - Clear some memory in instantiate_rng

2023-03-31T09:50:09+00:00

According to the comment at the end of the 'for' loop just a few lines
below, it looks needed to clear 'desc'.

So it should also be cleared for the first iteration.

Move the memset() to the beginning of the loop to be safe.

Fixes: 281922a1d4f5 ("crypto: caam - add support for SEC v5.x RNG4")
Signed-off-by: Christophe JAILLET 
Reviewed-by: Gaurav Jain 
Signed-off-by: Herbert Xu

crypto: caam - remove unnecessary (void*) conversions

2023-03-24T10:22:29+00:00

Pointer variables of void * type do not require type cast.

Signed-off-by: Yu Zhe 
Reviewed-by: Gaurav Jain 
Signed-off-by: Herbert Xu

crypto: caam/jr - add .shutdown hook

2023-03-24T10:22:28+00:00

add .shutdown hook in caam_jr driver to support kexec boot

Signed-off-by: Gaurav Jain 
Tested-by: Vijay Balakrishna 
Reviewed-by: Pankaj Gupta 
Signed-off-by: Herbert Xu

drivers: crypto: caam/jr - Allow quiesce when quiesced

2023-03-14T09:06:45+00:00

Issues:
- Job ring device is busy when do kexec reboot
- Failed to flush job ring when do system suspend-resume

Fix:
Flush the job ring to stop the running jobs.

Signed-off-by: Horia Geanta 
Signed-off-by: Franck LENORMAND 
Reviewed-by: Pankaj Gupta 
Signed-off-by: Herbert Xu

crypto: caam - Fix edesc/iv ordering mixup

2023-02-28T08:30:58+00:00

The attempt to add DMA alignment padding by moving IV to the front
of edesc was completely broken as it didn't change the places where
edesc was freed.

It's also wrong as the IV may still share a cache-line with the
edesc.

Fix this by restoring the original layout and simply reserving
enough memmory so that the IV is on a DMA cache-line by itself.

Reported-by: Meenakshi Aggarwal 
Fixes: 199354d7fb6e ("crypto: caam - Remove GFP_DMA and add DMA alignment padding")
Signed-off-by: Herbert Xu

crypto: caam - Use ahash_request_complete

2023-01-27T10:58:09+00:00

Instead of calling the base completion function directly, use the
correct ahash helper which is ahash_request_complete.

Signed-off-by: Herbert Xu 
Reviewed-by: Gaurav Jain 
Signed-off-by: Herbert Xu

crypto: caam - Remove GFP_DMA and add DMA alignment padding

2023-01-06T09:15:47+00:00

GFP_DMA does not guarantee that the returned memory is aligned
for DMA.  It should be removed where it is superfluous.

However, kmalloc may start returning DMA-unaligned memory in future
so fix this by adding the alignment by hand.

Signed-off-by: Herbert Xu

crypto: caam - Avoid GCC memset bug warning

2023-01-06T09:15:46+00:00

Certain versions of gcc don't like the memcpy with a NULL dst
(which only happens with a zero length).  This only happens
when debugging is enabled so add an if clause to work around
these warnings.

A similar warning used to be generated by sparse but that was
fixed years ago.

Link: https://lore.kernel.org/lkml/202210290446.qBayTfzl-lkp@intel.com
Reported-by: kernel test robot 
Reported-by: Kees Cook 
Reported-by: Uwe Kleine-König 
Tested-by: Uwe Kleine-König 
Signed-off-by: Herbert Xu