linux-stable.git/drivers/crypto/caam, branch v3.16.2

crypto: caam - fix memleak in caam_jr module

2014-07-10T08:59:13+00:00

This patch fixes a memory leak that appears when caam_jr module is unloaded.

Cc:  # 3.13+
Signed-off-by: Cristian Stoica 
Signed-off-by: Herbert Xu

crypto: caam - reinitialize keys_fit_inline for decrypt and givencrypt

2014-05-13T11:43:46+00:00

Re-initialize keys_fit_inline to avoid using its stale encrypt() shared
descriptor value prior to building descriptors for the decrypt() and
givencrypt() cases.

Signed-off-by: Vakul Garg 
[reworded commit text, enhanced code readability]
Signed-off-by: Kim Phillips 
Signed-off-by: Herbert Xu

crypto: caam - Fix the 'quoted string split across lines'

2014-05-08T13:58:11+00:00

Fix the checkpatch warnings that the strings were split across
multiple lines. Checkpatch now complains about lines over 80,
but this is better, since we can actually grep the source code
for these strings now.

Signed-off-by: Marek Vasut 
Cc: Herbert Xu 
Cc: Horia Geanta 
Signed-off-by: Herbert Xu

crypto: caam - Sweep the remnants

2014-05-08T13:58:11+00:00

Clean up the remnants from the rework. Constify function arguments.

Note that checkpatch again complains about this space before newline,
but this is the original code behavior, so I'm keeping it.

Signed-off-by: Marek Vasut 
Cc: Herbert Xu 
Cc: Horia Geanta 
Signed-off-by: Herbert Xu

crypto: caam - Kill SPRINTFCAT() with fire

2014-05-08T13:58:10+00:00

This macro is just like an encyclopedia of string handling done wrong.
This must die. This is so wrong on so many levels.

Signed-off-by: Marek Vasut 
Cc: Herbert Xu 
Cc: Horia Geanta 
Signed-off-by: Herbert Xu

crypto: caam - Clean up report_deco_status()

2014-05-08T13:58:10+00:00

Clean this function up and rework it into sensible shape. This function
now contains one single dev_err() instead of the previous insanity full
of memory allocation, chaotic string handling and use of SPRINTFCAT().

Signed-off-by: Marek Vasut 
Cc: Herbert Xu 
Cc: Horia Geanta 
Signed-off-by: Herbert Xu

crypto: caam - Clean up report_ccb_status()

2014-05-08T13:58:09+00:00

Clean this function up and rework it into sensible shape. This function
now contains one single dev_err() instead of the previous insanity full
of memory allocation, possible stack overwriting, chaotic string handling
and use of SPRINTFCAT().

Signed-off-by: Marek Vasut 
Cc: Herbert Xu 
Cc: Horia Geanta 
Signed-off-by: Herbert Xu

crypto: caam - Dissolve report_jump_idx()

2014-05-08T13:58:09+00:00

Just dissolve this function so it's not in the way of applying
further white magic cleanup down the line.

Signed-off-by: Marek Vasut 
Cc: Herbert Xu 
Cc: Horia Geanta 
Signed-off-by: Herbert Xu

crypto: caam - Kill the easy targets

2014-05-08T13:58:08+00:00

Fix the functions which can be obviously done right with a simple
dev_err() now. While at it, further press the on-stack allocation
of buffer for sprintf() voodoo down into the abominated functions.

This patch cleans up most of the functions and leaves just two
remaining functions, report_ccb_status() and report_deco_status()
ugly and unhappy.

Signed-off-by: Marek Vasut 
Cc: Herbert Xu 
Cc: Horia Geanta 
Signed-off-by: Herbert Xu

crypto: caam - Pass error type into the functions

2014-05-08T13:58:08+00:00

Pass the error type string into the functions, so they can handle
the printing of the string. This is now still using the very unsafe
sprintf(), but we will fix that.

While at this, pass the device pointer too, so we can dev_err()
functions readily when we start fixing this proper.

Signed-off-by: Marek Vasut 
Cc: Herbert Xu 
Cc: Horia Geanta 
Signed-off-by: Herbert Xu