linux-stable.git/drivers/crypto/caam/ctrl.c, branch linux-5.17.y

crypto: caam - fix i.MX6SX entropy delay value

2022-06-06T06:47:53+00:00

commit 4ee4cdad368a26de3967f2975806a9ee2fa245df upstream.

Since commit 358ba762d9f1 ("crypto: caam - enable prediction resistance
in HRWNG") the following CAAM errors can be seen on i.MX6SX:

caam_jr 2101000.jr: 20003c5b: CCB: desc idx 60: RNG: Hardware error
hwrng: no data available

This error is due to an incorrect entropy delay for i.MX6SX.

Fix it by increasing the minimum entropy delay for i.MX6SX
as done in U-Boot:
https://patchwork.ozlabs.org/project/uboot/patch/20220415111049.2565744-1-gaurav.jain@nxp.com/

As explained in the U-Boot patch:

"RNG self tests are run to determine the correct entropy delay.
Such tests are executed with different voltages and temperatures to identify
the worst case value for the entropy delay. For i.MX6SX, it was determined
that after adding a margin value of 1000 the minimum entropy delay should be
at least 12000."

Cc: 
Fixes: 358ba762d9f1 ("crypto: caam - enable prediction resistance in HRWNG")
Signed-off-by: Fabio Estevam 
Reviewed-by: Horia Geantă 
Reviewed-by: Vabhav Sharma 
Reviewed-by: Gaurav Jain 
Signed-off-by: Herbert Xu 
Signed-off-by: Greg Kroah-Hartman

crypto: caam - Fix kerneldoc

2020-09-18T07:20:12+00:00

Fix kerneldoc warnings like:

  drivers/crypto/caam/caamalg_qi2.c:73: warning: cannot understand function prototype: 'struct caam_ctx'
  drivers/crypto/caam/caamalg_qi2.c:2962: warning: cannot understand function prototype: 'struct caam_hash_ctx'
  drivers/crypto/caam/ctrl.c:449: warning: Function parameter or member 'ctrl' not described in 'caam_get_era'

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Iuliana Prodan 
Signed-off-by: Herbert Xu

crypto: caam - use traditional error check pattern

2020-09-11T04:39:14+00:00

Use traditional error check pattern
	ret = ...;
	if (ret)
		return ret;
	...
instead of checking error code to be 0.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Iuliana Prodan 
Signed-off-by: Herbert Xu

crypto: caam - Move debugfs fops into standalone file

2020-08-21T04:47:49+00:00

Currently the debugfs fops are defined in caam/intern.h.  This causes
problems because it creates identical static functions and variables
in multiple files.  It also creates warnings when those files don't
use the fops.

This patch moves them into a standalone file, debugfs.c.

It also removes unnecessary uses of ifdefs on CONFIG_DEBUG_FS.

Signed-off-by: Herbert Xu 
[Moved most of debugfs-related operations into debugfs.c.]
Signed-off-by: Horia Geantă 
Signed-off-by: Herbert Xu

crypto: caam - Fix argument type in handle_imx6_err005766

2020-06-18T07:26:43+00:00

The function handle_imx6_err005766 needs to take an __iomem argument
as otherwise sparse will generate two warnings.

Fixes: 33d69455e402 ("crypto: caam - limit AXI pipeline to a...")
Signed-off-by: Herbert Xu 
Reviewed-by: Iuliana Prodan 
Signed-off-by: Herbert Xu

crypto: caam - add clock info for VFxxx SoCs

2020-06-18T07:19:45+00:00

Add a small bit of plumbing necessary to use CAAM on VFxxx SoCs.

Signed-off-by: Andrey Smirnov 
Cc: Chris Healy 
Cc: Fabio Estevam 
Cc: linux-imx@nxp.com
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Horia Geantă 
Signed-off-by: Herbert Xu

crypto: caam - fix typos

2020-06-15T07:38:54+00:00

Fix CAAM related typos.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Horia Geantă 
Signed-off-by: Herbert Xu

crypto: caam - enable prediction resistance in HRWNG

2020-03-30T00:50:50+00:00

Instantiate CAAM RNG with prediction resistance enabled to improve its
quality (with PR on DRNG is forced to reseed from TRNG every time
random data is generated).

Management Complex firmware with version lower than 10.20.0
doesn't provide prediction resistance support. Consider this
and only instantiate rng when mc f/w version is lower.

Signed-off-by: Andrey Smirnov 
Signed-off-by: Andrei Botila 
Cc: Chris Healy 
Cc: Lucas Stach 
Cc: Horia Geantă 
Cc: Herbert Xu 
Cc: Iuliana Prodan 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-imx@nxp.com
Reviewed-by: Horia Geantă 
Signed-off-by: Herbert Xu

crypto: caam - invalidate entropy register during RNG initialization

2020-03-30T00:50:49+00:00

In order to make sure that we always use non-stale entropy data, change
the code to invalidate entropy register during RNG initialization.

Signed-off-by: Aymen Sghaier 
Signed-off-by: Vipul Kumar 
[andrew.smirnov@gmail.com ported to upstream kernel, rewrote commit msg]
Signed-off-by: Andrey Smirnov 
Reviewed-by: Horia Geantă 
Cc: Chris Healy 
Cc: Lucas Stach 
Cc: Horia Geantă 
Cc: Herbert Xu 
Cc: Iuliana Prodan 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-imx@nxp.com
Signed-off-by: Herbert Xu

crypto: caam - allocate RNG instantiation descriptor with GFP_DMA

2020-03-30T00:50:48+00:00

Be consistent with the rest of the codebase and use GFP_DMA when
allocating memory for a CAAM JR descriptor.

Signed-off-by: Andrey Smirnov 
Reviewed-by: Horia Geantă 
Cc: Chris Healy 
Cc: Lucas Stach 
Cc: Horia Geantă 
Cc: Herbert Xu 
Cc: Iuliana Prodan 
Cc: linux-imx@nxp.com
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu