linux-stable.git/drivers/crypto/bcm, branch v5.8

crypto: bcm - Use the defined variable to clean code

2020-05-08T05:30:40+00:00

Use the defined variable "dev" to make the code cleaner.

Signed-off-by: Zhang Shengju 
Signed-off-by: Tang Bin 
Signed-off-by: Herbert Xu

crypto: bcm - Fix unused assignment

2020-04-30T05:19:34+00:00

Delete unused initialized value in cipher.c file.

Signed-off-by: Zhang Shengju 
Signed-off-by: Tang Bin 
Signed-off-by: Herbert Xu

crypto: bcm - Remove the unnecessary cast for PTR_ERR().

2020-04-30T05:19:34+00:00

It's not necessary to specify 'int' casting for PTR_ERR().

Signed-off-by: Zhang Shengju 
Signed-off-by: Tang Bin 
Signed-off-by: Herbert Xu

crypto: bcm - Delete redundant variable definition

2020-04-24T07:42:17+00:00

The variable "i" is redundant to be assigned a value
of zero,because it's assigned in the for loop, so remove
redundant one here.

Signed-off-by: Shengju Zhang 
Signed-off-by: Tang Bin 
Signed-off-by: Herbert Xu

crypto: bcm - Use scnprintf() for avoiding potential buffer overflow

2020-03-20T03:36:51+00:00

Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit.  Fix it by replacing with scnprintf().

Signed-off-by: Takashi Iwai 
Signed-off-by: Herbert Xu

crypto: remove propagation of CRYPTO_TFM_RES_* flags

2020-01-09T03:30:53+00:00

The CRYPTO_TFM_RES_* flags were apparently meant as a way to make the
->setkey() functions provide more information about errors.  But these
flags weren't actually being used or tested, and in many cases they
weren't being set correctly anyway.  So they've now been removed.

Also, if someone ever actually needs to start better distinguishing
->setkey() errors (which is somewhat unlikely, as this has been unneeded
for a long time), we'd be much better off just defining different return
values, like -EINVAL if the key is invalid for the algorithm vs.
-EKEYREJECTED if the key was rejected by a policy like "no weak keys".
That would be much simpler, less error-prone, and easier to test.

So just remove CRYPTO_TFM_RES_MASK and all the unneeded logic that
propagates these flags around.

Signed-off-by: Eric Biggers 
Signed-off-by: Herbert Xu

crypto: remove CRYPTO_TFM_RES_BAD_KEY_LEN

2020-01-09T03:30:53+00:00

The CRYPTO_TFM_RES_BAD_KEY_LEN flag was apparently meant as a way to
make the ->setkey() functions provide more information about errors.

However, no one actually checks for this flag, which makes it pointless.

Also, many algorithms fail to set this flag when given a bad length key.
Reviewing just the generic implementations, this is the case for
aes-fixed-time, cbcmac, echainiv, nhpoly1305, pcrypt, rfc3686, rfc4309,
rfc7539, rfc7539esp, salsa20, seqiv, and xcbc.  But there are probably
many more in arch/*/crypto/ and drivers/crypto/.

Some algorithms can even set this flag when the key is the correct
length.  For example, authenc and authencesn set it when the key payload
is malformed in any way (not just a bad length), the atmel-sha and ccree
drivers can set it if a memory allocation fails, and the chelsio driver
sets it for bad auth tag lengths, not just bad key lengths.

So even if someone actually wanted to start checking this flag (which
seems unlikely, since it's been unused for a long time), there would be
a lot of work needed to get it working correctly.  But it would probably
be much better to go back to the drawing board and just define different
return values, like -EINVAL if the key is invalid for the algorithm vs.
-EKEYREJECTED if the key was rejected by a policy like "no weak keys".
That would be much simpler, less error-prone, and easier to test.

So just remove this flag.

Signed-off-by: Eric Biggers 
Reviewed-by: Horia Geantă 
Signed-off-by: Herbert Xu

crypto: bcm-spu - switch to skcipher API

2019-11-17T01:02:46+00:00

Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface")
dated 20 august 2015 introduced the new skcipher API which is supposed to
replace both blkcipher and ablkcipher. While all consumers of the API have
been converted long ago, some producers of the ablkcipher remain, forcing
us to keep the ablkcipher support routines alive, along with the matching
code to expose [a]blkciphers via the skcipher API.

So switch this driver to the skcipher API, allowing us to finally drop the
ablkcipher code in the near future.

Signed-off-by: Ard Biesheuvel 
Signed-off-by: Herbert Xu

crypto: bcm/des - switch to new verification routines

2019-08-22T04:39:38+00:00

Signed-off-by: Ard Biesheuvel 
Signed-off-by: Herbert Xu

crypto: bcm - check assoclen for rfc4543/rfc4106

2019-07-27T11:08:37+00:00

Validated assoclen for RFC4543 which expects an assoclen
of 16 or 20, the same as RFC4106.
Based on seqiv, IPsec ESP and RFC4543/RFC4106 the assoclen is sizeof
IP Header (spi, seq_no, extended seq_no) and IV len. This can be 16 or
20 bytes.

Signed-off-by: Iuliana Prodan 
Signed-off-by: Herbert Xu