linux-stable.git/drivers/cpuidle, branch v5.5

cpuidle: teo: Fix intervals[] array indexing bug

2020-01-13T10:14:58+00:00

Fix a simple bug in rotating array index.

Fixes: b26bf6ab716f ("cpuidle: New timer events oriented governor for tickless systems")
Signed-off-by: Ikjoon Jang 
Cc: 5.1+  # 5.1+
Signed-off-by: Rafael J. Wysocki

cpuidle: Drop unnecessary type cast in cpuidle_poll_time()

2019-12-12T16:56:08+00:00

The data type of the target_residency_ns field in struct cpuidle_state
is u64, so it does not need to be cast into u64.

Get rid of the unnecessary type cast.

Signed-off-by: Rafael J. Wysocki 
Acked-by: Daniel Lezcano 
Signed-off-by: Rafael J. Wysocki

cpuidle: Fix cpuidle_driver_state_disabled()

2019-12-10T22:41:20+00:00

It turns out that cpuidle_driver_state_disabled() can be called
before registering the cpufreq driver on some platforms, which
was not expected when it was introduced and which leads to a NULL
pointer dereference when trying to walk the CPUs associated with
the given cpuidle driver.

Fix the problem by making cpuidle_driver_state_disabled() check if
the driver's mask of CPUs associated with it is present and to set
CPUIDLE_FLAG_UNUSABLE for the given idle state in the driver's states
list if that is not the case to cause __cpuidle_register_device() to
set CPUIDLE_STATE_DISABLED_BY_DRIVER for that state for all cpuidle
devices registered by it later.

Fixes: cbda56d5fefc ("cpuidle: Introduce cpuidle_driver_state_disabled() for driver quirks")
Reported-by: Daniel Lezcano 
Tested-by: Daniel Lezcano 
Signed-off-by: Rafael J. Wysocki

cpuidle: use first valid target residency as poll time

2019-12-09T09:37:16+00:00

Commit 259231a04561 ("cpuidle: add poll_limit_ns to cpuidle_device
structure") changed, by mistake, the target residency from the first
available sleep state to the last available sleep state (which should
be longer).

This might cause excessive polling.

Fixes: 259231a04561 ("cpuidle: add poll_limit_ns to cpuidle_device structure")
Signed-off-by: Marcelo Tosatti 
Cc: 5.4+  # 5.4+
Signed-off-by: Rafael J. Wysocki

cpuidle: minor Kconfig help text fixes

2019-11-29T10:49:32+00:00

End sentences in help text with a period (aka full stop).

Signed-off-by: Randy Dunlap 
Signed-off-by: Rafael J. Wysocki

cpuidle: Drop disabled field from struct cpuidle_state

2019-11-29T10:48:39+00:00

After recent cpuidle updates the "disabled" field in struct
cpuidle_state is only used by two drivers (intel_idle and shmobile
cpuidle) for marking unusable idle states, but that may as well be
achieved with the help of a state flag, so define an "unusable" idle
state flag, CPUIDLE_FLAG_UNUSABLE, make the drivers in question use
it instead of the "disabled" field and make the core set
CPUIDLE_STATE_DISABLED_BY_DRIVER for the idle states with that flag
set.

After the above changes, the "disabled" field in struct cpuidle_state
is not used any more, so drop it.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki

cpuidle: Fix Kconfig indentation

2019-11-29T10:47:35+00:00

Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
	$ sed -e 's/^        /\t/' -i */Kconfig

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Rafael J. Wysocki

cpuidle: Pass exit latency limit to cpuidle_use_deepest_state()

2019-11-20T10:46:18+00:00

Modify cpuidle_use_deepest_state() to take an additional exit latency
limit argument to be passed to find_deepest_idle_state() and make
cpuidle_idle_call() pass dev->forced_idle_latency_limit_ns to it for
forced idle.

Suggested-by: Rafael J. Wysocki 
Signed-off-by: Daniel Lezcano 
[ rjw: Rebase and rearrange code, subject & changelog ]
Signed-off-by: Rafael J. Wysocki

cpuidle: Allow idle injection to apply exit latency limit

2019-11-20T10:32:55+00:00

In some cases it may be useful to specify an exit latency limit for
the idle state to be used during CPU idle time injection.

Instead of duplicating the information in struct cpuidle_device
or propagating the latency limit in the call stack, replace the
use_deepest_state field with forced_latency_limit_ns to represent
that limit, so that the deepest idle state with exit latency within
that limit is forced (i.e. no governors) when it is set.

A zero exit latency limit for forced idle means to use governors in
the usual way (analogous to use_deepest_state equal to "false" before
this change).

Additionally, add play_idle_precise() taking two arguments, the
duration of forced idle and the idle state exit latency limit, both
in nanoseconds, and redefine play_idle() as a wrapper around that
new function.

This change is preparatory, no functional impact is expected.

Suggested-by: Rafael J. Wysocki 
Signed-off-by: Daniel Lezcano 
[ rjw: Subject, changelog, cpuidle_use_deepest_state() kerneldoc, whitespace ]
Signed-off-by: Rafael J. Wysocki

cpuidle: Introduce cpuidle_driver_state_disabled() for driver quirks

2019-11-19T09:35:13+00:00

Commit 99e98d3fb100 ("cpuidle: Consolidate disabled state checks")
overlooked the fact that the imx6q and tegra20 cpuidle drivers use
the "disabled" field in struct cpuidle_state for quirks which trigger
after the initialization of cpuidle, so reading the initial value of
that field is not sufficient for those drivers.

In order to allow them to implement the quirks without using the
"disabled" field in struct cpuidle_state, introduce a new helper
function and modify them to use it.

Fixes: 99e98d3fb100 ("cpuidle: Consolidate disabled state checks")
Reported-by: Len Brown 
Signed-off-by: Rafael J. Wysocki