linux-stable.git/drivers/cpuidle, branch linux-3.13.y

ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function

2013-12-30T10:55:20+00:00

Commit 60a66e370007e8535b7a561353b07b37deaf35ba changed the Calxeda
cpuidle driver to a platform driver, copying the __init tag from the
_init() to the newly used _probe() function. However, "probe should
not be __init." (Rob said ;-)
Remove the __init tag to fix a section mismatch in the Calxeda
cpuidle driver.

Signed-off-by: Andre Przywara 
Signed-off-by: Daniel Lezcano

cpuidle: Check for dev before deregistering it.

2013-12-03T21:05:22+00:00

If not, we could end up in the unfortunate situation where
we dereference a NULL pointer b/c we have cpuidle disabled.

This is the case when booting under Xen (which uses the
ACPI P/C states but disables the CPU idle driver) - and can
be easily reproduced when booting with cpuidle.off=1.

BUG: unable to handle kernel NULL pointer dereference at           (null)
IP: [] cpuidle_unregister_device+0x2a/0x90
.. snip..
Call Trace:
 [] acpi_processor_power_exit+0x3c/0x5c
 [] acpi_processor_stop+0x61/0xb6
 [] __device_release_driver+0fffff81421653>] device_release_driver+0x23/0x30
 [] bus_remove_device+0x108/0x180
 [] device_del+0x129/0x1c0
 [] ? unregister_xenbus_watch+0x1f0/0x1f0
 [] device_unregister+0x1e/0x60
 [] unregister_cpu+0x39/0x60
 [] arch_unregister_cpu+0x23/0x30
 [] handle_vcpu_hotplug_event+0xc1/0xe0
 [] xenwatch_thread+0x45/0x120
 [] ? abort_exclusive_wait+0xb0/0xb0
 [] kthread+0xd2/0xf0
 [] ? kthread_create_on_node+0x180/0x180
 [] ret_from_fork+0x7c/0xb0
 [] ? kthread_create_on_node+0x180/0x180

This problem also appears in 3.12 and could be a candidate for backport.

Signed-off-by: Konrad Rzeszutek Wilk 
Cc: All applicable 
Signed-off-by: Rafael J. Wysocki

Merge tag 'pm+acpi-3.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm

2013-11-14T04:41:48+00:00

Pull ACPI and power management updates from Rafael J Wysocki:

- New power capping framework and the the Intel Running Average Power
Limit (RAPL) driver using it from Srinivas Pandruvada and Jacob Pan.

- Addition of the in-kernel switching feature to the arm_big_little
cpufreq driver from Viresh Kumar and Nicolas Pitre.

- cpufreq support for iMac G5 from Aaro Koskinen.

- Baytrail processors support for intel_pstate from Dirk Brandewie.

- cpufreq support for Midway/ECX-2000 from Mark Langsdorf.

- ARM vexpress/TC2 cpufreq support from Sudeep KarkadaNagesha.

- ACPI power management support for the I2C and SPI bus types from Mika
Westerberg and Lv Zheng.

- cpufreq core fixes and cleanups from Viresh Kumar, Srivatsa S Bhat,
Stratos Karafotis, Xiaoguang Chen, Lan Tianyu.

- cpufreq drivers updates (mostly fixes and cleanups) from Viresh
Kumar, Aaro Koskinen, Jungseok Lee, Sudeep KarkadaNagesha, Lukasz
Majewski, Manish Badarkhe, Hans-Christian Egtvedt, Evgeny Kapaev.

- intel_pstate updates from Dirk Brandewie and Adrian Huang.

- ACPICA update to version 20130927 includig fixes and cleanups and
some reduction of divergences between the ACPICA code in the kernel
and ACPICA upstream in order to improve the automatic ACPICA patch
generation process. From Bob Moore, Lv Zheng, Tomasz Nowicki, Naresh
Bhat, Bjorn Helgaas, David E Box.

- ACPI IPMI driver fixes and cleanups from Lv Zheng.

- ACPI hotplug fixes and cleanups from Bjorn Helgaas, Toshi Kani, Zhang
Yanfei, Rafael J Wysocki.

- Conversion of the ACPI AC driver to the platform bus type and
multiple driver fixes and cleanups related to ACPI from Zhang Rui.

- ACPI processor driver fixes and cleanups from Hanjun Guo, Jiang Liu,
Bartlomiej Zolnierkiewicz, Mathieu Rhéaume, Rafael J Wysocki.

- Fixes and cleanups and new blacklist entries related to the ACPI
video support from Aaron Lu, Felipe Contreras, Lennart Poettering,
Kirill Tkhai.

- cpuidle core cleanups from Viresh Kumar and Lorenzo Pieralisi.

- cpuidle drivers fixes and cleanups from Daniel Lezcano, Jingoo Han,
Bartlomiej Zolnierkiewicz, Prarit Bhargava.

- devfreq updates from Sachin Kamat, Dan Carpenter, Manish Badarkhe.

- Operation Performance Points (OPP) core updates from Nishanth Menon.

- Runtime power management core fix from Rafael J Wysocki and update
from Ulf Hansson.

- Hibernation fixes from Aaron Lu and Rafael J Wysocki.

- Device suspend/resume lockup detection mechanism from Benoit Goby.

- Removal of unused proc directories created for various ACPI drivers
from Lan Tianyu.

- ACPI LPSS driver fix and new device IDs for the ACPI platform scan
handler from Heikki Krogerus and Jarkko Nikula.

- New ACPI _OSI blacklist entry for Toshiba NB100 from Levente Kurusa.

- Assorted fixes and cleanups related to ACPI from Andy Shevchenko, Al
Stone, Bartlomiej Zolnierkiewicz, Colin Ian King, Dan Carpenter,
Felipe Contreras, Jianguo Wu, Lan Tianyu, Yinghai Lu, Mathias Krause,
Liu Chuansheng.

- Assorted PM fixes and cleanups from Andy Shevchenko, Thierry Reding,
Jean-Christophe Plagniol-Villard.

* tag 'pm+acpi-3.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm: (386 commits)
cpufreq: conservative: fix requested_freq reduction issue
ACPI / hotplug: Consolidate deferred execution of ACPI hotplug routines
PM / runtime: Use pm_runtime_put_sync() in __device_release_driver()
ACPI / event: remove unneeded NULL pointer check
Revert "ACPI / video: Ignore BIOS initial backlight value for HP 250 G1"
ACPI / video: Quirk initial backlight level 0
ACPI / video: Fix initial level validity test
intel_pstate: skip the driver if ACPI has power mgmt option
PM / hibernate: Avoid overflow in hibernate_preallocate_memory()
ACPI / hotplug: Do not execute "insert in progress" _OST
ACPI / hotplug: Carry out PCI root eject directly
ACPI / hotplug: Merge device hot-removal routines
ACPI / hotplug: Make acpi_bus_hot_remove_device() internal
ACPI / hotplug: Simplify device ejection routines
ACPI / hotplug: Fix handle_root_bridge_removal()
ACPI / hotplug: Refuse to hot-remove all objects with disabled hotplug
ACPI / scan: Start matching drivers after trying scan handlers
ACPI: Remove acpi_pci_slot_init() headers from internal.h
ACPI / blacklist: fix name of ThinkPad Edge E530
PowerCap: Fix build error with option -Werror=format-security
...

Conflicts:
arch/arm/mach-omap2/opp.c
drivers/Kconfig
drivers/spi/spi.c

cpuidle: remove cpuidle_unregister_governor()

2013-10-30T00:21:24+00:00

cpuidle_unregister_governor() and cpuidle_replace_governor() aren't
used anymore and can be removed. They were used by cpufreq governors
earlier, but since the governors can't be compiled as modules any
more, these two functions aren't necessary.

Suggested-by: Daniel Lezcano 
Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

cpuidle: don't call poll_idle_init() for every cpu

2013-10-30T00:21:23+00:00

poll_idle_init() just initializes drv->states[0] and so that is
required to be done only once for each driver.  Currently, it is
called from cpuidle_enable_device() which is called for every CPU
that the driver supports.  That is not required, so move it to a
better place and call it from __cpuidle_register_driver() so that
the initialization is carried out only once.

Acked-by: Daniel Lezcano 
Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

cpuidle: use drv instead of cpuidle_driver in show_current_driver()

2013-10-30T00:21:23+00:00

Instances of "struct cpuidle_driver *" are consistently named as "drv"
in the cpuidle core except in show_current_driver().

Make that function use variable naming consistent with the rest of the
code.

[rjw: Changelog]
Acked-by: Daniel Lezcano 
Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

cpuidle: call cpuidle_get_driver() from after taking cpuidle_driver_lock

2013-10-30T00:21:23+00:00

There are a few cpuidle_get_driver() calls that aren't made under
cpuidle_driver_lock which is incorrect.

Fix them by calling cpuidle_get_driver() after taking cpuidle_driver_lock.

Acked-by: Daniel Lezcano 
Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

cpuidle: replace multiline statements with single line in cpuidle_idle_call()

2013-10-30T00:21:23+00:00

Few statements in cpuidle_idle_call() are broken into multiple lines,
although that isn't really necessary. Convert those to single line.

Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

cpuidle: reduce code duplication inside cpuidle_idle_call()

2013-10-30T00:21:22+00:00

We are doing this twice in cpuidle_idle_call() routine:
	drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP

Would be better if we actually store this in a local variable and
use that. That reduces code duplication and likely makes this piece
of code run faster (in case the compiler wasn't able to optimize it
earlier)

[rjw: Cast the result of bitwise AND to bool explicitly using !!]
Acked-by: Daniel Lezcano 
Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki

cpuidle: merge two if() statements for checking error cases

2013-10-30T00:21:22+00:00

Two checks cpuidle_idle_call() cause the same error code to be
returned if they fail, so merge them for clarity.

[rjw: Changelog]
Acked-by: Daniel Lezcano 
Signed-off-by: Viresh Kumar 
Signed-off-by: Rafael J. Wysocki