linux-stable.git/drivers/cpufreq, branch linux-6.10.y

cpufreq: intel_pstate: Make hwp_notify_lock a raw spinlock

2024-10-10T10:01:08+00:00

commit 8b4865cd904650cbed7f2407e653934c621b8127 upstream.

notify_hwp_interrupt() is called via sysvec_thermal() ->
smp_thermal_vector() -> intel_thermal_interrupt() in hard irq context.
For this reason it must not use a simple spin_lock that sleeps with
PREEMPT_RT enabled. So convert it to a raw spinlock.

Reported-by: xiao sheng wen 
Link: https://bugs.debian.org/1076483
Signed-off-by: Uwe Kleine-König 
Acked-by: Srinivas Pandruvada 
Acked-by: Sebastian Andrzej Siewior 
Tested-by: xiao sheng wen 
Link: https://patch.msgid.link/20240919081121.10784-2-ukleinek@debian.org
Cc: All applicable 
Signed-off-by: Rafael J. Wysocki 
[ukleinek: Backport to v6.10.y]
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Sasha Levin

cpufreq: ti-cpufreq: Introduce quirks to handle syscon fails appropriately

2024-10-04T14:32:25+00:00

[ Upstream commit abc00ffda43bd4ba85896713464c7510c39f8165 ]

Commit b4bc9f9e27ed ("cpufreq: ti-cpufreq: add support for omap34xx
and omap36xx") introduced special handling for OMAP3 class devices
where syscon node may not be present. However, this also creates a bug
where the syscon node is present, however the offset used to read
is beyond the syscon defined range.

Fix this by providing a quirk option that is populated when such
special handling is required. This allows proper failure for all other
platforms when the syscon node and efuse offsets are mismatched.

Fixes: b4bc9f9e27ed ("cpufreq: ti-cpufreq: add support for omap34xx and omap36xx")
Signed-off-by: Nishanth Menon 
Tested-by: Dhruva Gole 
Reviewed-by: Kevin Hilman 
Signed-off-by: Viresh Kumar 
Signed-off-by: Sasha Levin

cpufreq: scmi: Avoid overflow of target_freq in fast switch

2024-09-08T05:56:31+00:00

[ Upstream commit 074cffb5020ddcaa5fafcc55655e5da6ebe8c831 ]

Conversion of target_freq to HZ in scmi_cpufreq_fast_switch()
can lead to overflow if the multiplied result is greater than
UINT_MAX, since type of target_freq is unsigned int. Avoid this
overflow by assigning target_freq to unsigned long variable for
converting it to HZ.

Signed-off-by: Jagadeesh Kona 
Signed-off-by: Viresh Kumar 
Signed-off-by: Sasha Levin

cpufreq/amd-pstate-ut: Don't check for highest perf matching on prefcore

2024-09-04T11:30:08+00:00

[ Upstream commit 9983a9cd4d429dc9ca01770083c4c1f366214b65 ]

If a system is using preferred cores the highest perf will be inconsistent
as it can change from system events.

Skip the checks for it.

Fixes: e571a5e2068e ("cpufreq: amd-pstate: Update amd-pstate preferred core ranking dynamically")
Reviewed-by: Gautham R. Shenoy 
Signed-off-by: Mario Limonciello 
Signed-off-by: Sasha Levin

cpufreq/amd-pstate: Use topology_logical_package_id() instead of logical_die_id()

2024-09-04T11:30:06+00:00

commit 0d8584d288a9b4132e945d76bcc04395d158b2e7 upstream.

After the commit 63edbaa48a57 ("x86/cpu/topology: Add support for the
AMD 0x80000026 leaf"), the topolgy_logical_die_id() function returns
the logical Core Chiplet Die (CCD) ID instead of the logical socket
ID.

Since this is currently used to set MSR_AMD_CPPC_ENABLE, which needs
to be set on any one of the threads of the socket, it is prudent to
use topology_logical_package_id() in place of
topology_logical_die_id().

Fixes: 63edbaa48a57 ("x86/cpu/topology: Add support for the AMD 0x80000026 leaf")
cc: stable@vger.kernel.org # 6.10
Signed-off-by: Gautham R. Shenoy 
Tested-by: Dhananjay Ugwekar 
Link: https://lore.kernel.org/lkml/20240801124509.3650-1-Dhananjay.Ugwekar@amd.com/
Signed-off-by: Dhananjay Ugwekar 
Signed-off-by: Mario Limonciello 
Signed-off-by: Greg Kroah-Hartman

cpufreq: amd-pstate: auto-load pstate driver by default

2024-08-14T13:34:07+00:00

[ Upstream commit 4e4f600ee750facedf6a5dc97e8ae0b627ab4573 ]

If the `amd-pstate` driver is not loaded automatically by default,
it is because the kernel command line parameter has not been added.
To resolve this issue, it is necessary to call the `amd_pstate_set_driver()`
function to enable the desired mode (passive/active/guided) before registering
the driver instance.

This ensures that the driver is loaded correctly without relying on the kernel
command line parameter.

When there is no parameter added to command line, Kernel config will
provide the default mode to load.

Meanwhile, user can add driver mode in command line which will override
the kernel config default option.

Reported-by: Andrei Amuraritei 
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218705
Signed-off-by: Perry Yuan 
Reviewed-by: Mario Limonciello 
Link: https://lore.kernel.org/r/83301c4cea4f92fb19e14b23f2bac7facfd8bdbb.1718811234.git.perry.yuan@amd.com
Signed-off-by: Mario Limonciello 
Signed-off-by: Sasha Levin

cpufreq: amd-pstate: Allow users to write 'default' EPP string

2024-08-14T13:34:07+00:00

[ Upstream commit fc6e0837264a8b2504b6160e63ec92eb012540f3 ]

The EPP string for 'default' represents what the firmware had configured
as the default EPP value but once a user changes EPP to another string
they can't reset it back to 'default'.

Cache the firmware EPP value and allow the user to write 'default' using
this value.

Reported-by: Artem S. Tashkinov 
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217931#c61
Reviewed-by: Perry Yuan 
Signed-off-by: Mario Limonciello 
Signed-off-by: Sasha Levin

cpufreq: qcom-nvmem: fix memory leaks in probe error paths

2024-08-03T07:00:38+00:00

commit d01c84b97f19f1137211e90b0a910289a560019e upstream.

The code refactoring added new error paths between the np device node
allocation and the call to of_node_put(), which leads to memory leaks if
any of those errors occur.

Add the missing of_node_put() in the error paths that require it.

Cc: stable@vger.kernel.org
Fixes: 57f2f8b4aa0c ("cpufreq: qcom: Refactor the driver to make it easier to extend")
Signed-off-by: Javier Carrasco 
Signed-off-by: Viresh Kumar 
Signed-off-by: Greg Kroah-Hartman

cpufreq/amd-pstate: Fix the scaling_max_freq setting on shared memory CPPC systems

2024-08-03T06:59:30+00:00

[ Upstream commit 738d7d03571c7e38565bd245c0815a2c74665018 ]

On shared memory CPPC systems, with amd_pstate=active mode, the change
in scaling_max_freq doesn't get written to the shared memory
region. Due to this, the writes to the scaling_max_freq sysfs file
don't take effect. Fix this by propagating the scaling_max_freq
changes to the shared memory region.

Fixes: ffa5096a7c33 ("cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors")
Reported-by: David Arcari 
Signed-off-by: Dhananjay Ugwekar 
Reviewed-by: Mario Limonciello 
Link: https://lore.kernel.org/r/20240702081413.5688-3-Dhananjay.Ugwekar@amd.com
Signed-off-by: Mario Limonciello 
Signed-off-by: Sasha Levin

cpufreq/amd-pstate-ut: Convert nominal_freq to khz during comparisons

2024-08-03T06:59:29+00:00

[ Upstream commit f21ab5ed4e8758b06230900f44b9dcbcfdc0c3ae ]

cpudata->nominal_freq being in MHz whereas other frequencies being in
KHz breaks the amd-pstate-ut frequency sanity check. This fixes it.

Fixes: e4731baaf294 ("cpufreq: amd-pstate: Fix the inconsistency in max frequency units")
Reported-by: David Arcari 
Signed-off-by: Dhananjay Ugwekar 
Reviewed-by: Mario Limonciello 
Reviewed-by: Gautham R. Shenoy 
Link: https://lore.kernel.org/r/20240702081413.5688-2-Dhananjay.Ugwekar@amd.com
Signed-off-by: Mario Limonciello 
Signed-off-by: Sasha Levin