linux-stable.git/drivers/counter, branch linux-5.17.y

counter: Stop using dev_get_drvdata() to get the counter device

2022-03-15T18:24:13+00:00

dev_get_drvdata() returns NULL since commit b56346ddbd82 ("counter: Use
container_of instead of drvdata to track counter_device") which wrongly
claimed there were no users of drvdata. Convert to container_of() to
fix a null pointer dereference.

Reported-by: Oleksij Rempel 
Fixes: b56346ddbd82 ("counter: Use container_of instead of drvdata to track counter_device")
Signed-off-by: Uwe Kleine-König 
Tested-by: Jarkko Nikula 
Link: https://lore.kernel.org/all/20220204082556.370348-1-u.kleine-koenig@pengutronix.de/
Signed-off-by: William Breathitt Gray 
Link: https://lore.kernel.org/r/4a14311a3b935b62b33e665a97ecaaf2f078228a.1646957732.git.vilhelm.gray@gmail.com
Signed-off-by: Greg Kroah-Hartman

counter: fix an IS_ERR() vs NULL bug

2022-01-26T18:40:33+00:00

There are 8 callers for devm_counter_alloc() and they all check for NULL
instead of error pointers.  I think NULL is the better thing to return
for allocation functions so update counter_alloc() and devm_counter_alloc()
to return NULL instead of error pointers.

Fixes: c18e2760308e ("counter: Provide alternative counter registration functions")
Acked-by: Uwe Kleine-König 
Acked-by: William Breathitt Gray 
Signed-off-by: Dan Carpenter 
Link: https://lore.kernel.org/r/20220111173243.GA2192@kili
Signed-off-by: Greg Kroah-Hartman

counter: 104-quad-8: Fix use-after-free by quad8_irq_handler

2022-01-06T14:51:13+00:00

On unbind an irq might be pending which results in quad8_irq_handler()
calling counter_push_event() for a counter that is already unregistered.
This patch fixes that situation by passing the struct counter_device dev
to devm_request_irq() rather than the parent's so that the irq handler
is cleaned before the counter is unregistered.

Fixes: 7aa2ba0df651 ("counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8")
Cc: Syed Nayyar Waris 
Reported-by: Uwe Kleine-König 
Signed-off-by: William Breathitt Gray 
Link: https://lore.kernel.org/r/20220105093052.258791-1-vilhelm.gray@gmail.com
Signed-off-by: Greg Kroah-Hartman

counter: remove old and now unused registration API

2021-12-30T16:44:07+00:00

Usage of counter_register() yields issues in device lifetime tracking. All
drivers were converted to the new API, so the old one can go away.

Reviewed-by: Jonathan Cameron 
Acked-by: William Breathitt Gray 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20211230150300.72196-24-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

counter: ti-eqep: Convert to new counter registration

2021-12-30T16:44:07+00:00

This fixes device lifetime issues where it was possible to free a live
struct device.

Fixes: f213729f6796 ("counter: new TI eQEP driver")
Reviewed-by: Jonathan Cameron 
Acked-by: William Breathitt Gray 
Acked-by: David Lechner 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20211230150300.72196-23-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

counter: stm32-lptimer-cnt: Convert to new counter registration

2021-12-30T16:44:07+00:00

This fixes device lifetime issues where it was possible to free a live
struct device.

Fixes: 597f55e3f36c ("counter: stm32-lptimer: add counter device")
Reviewed-by: Jonathan Cameron 
Acked-by: William Breathitt Gray 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20211230150300.72196-22-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

counter: stm32-timer-cnt: Convert to new counter registration

2021-12-30T16:44:07+00:00

This fixes device lifetime issues where it was possible to free a live
struct device.

Fixes: ad29937e206f ("counter: Add STM32 Timer quadrature encoder")
Reviewed-by: Jonathan Cameron 
Acked-by: William Breathitt Gray 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20211230150300.72196-21-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

counter: microchip-tcb-capture: Convert to new counter registration

2021-12-30T16:44:07+00:00

This fixes device lifetime issues where it was possible to free a live
struct device.

Fixes: 106b104137fd ("counter: Add microchip TCB capture counter")
Reviewed-by: Jonathan Cameron 
Acked-by: William Breathitt Gray 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20211230150300.72196-20-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

counter: ftm-quaddec: Convert to new counter registration

2021-12-30T16:44:07+00:00

This fixes device lifetime issues where it was possible to free a live
struct device.

Fixes: a3b9a99980d9 ("counter: add FlexTimer Module Quadrature decoder counter driver")
Reviewed-by: Jonathan Cameron 
Acked-by: William Breathitt Gray 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20211230150300.72196-19-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

counter: intel-qep: Convert to new counter registration

2021-12-30T16:44:07+00:00

This fixes device lifetime issues where it was possible to free a live
struct device.

Fixes: b711f687a1c1 ("counter: Add support for Intel Quadrature Encoder Peripheral")
Tested-by: Jarkko Nikula 
Reviewed-by: Jonathan Cameron 
Acked-by: William Breathitt Gray 
Acked-by: Jarkko Nikula 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20211230150300.72196-18-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman