linux-stable.git/drivers/connector, branch linux-2.6.28.y

CONNECTOR: add a proc entry to list connectors

2008-06-28T03:03:24+00:00

I got a problem when I wanted to check if the kernel supports process
event connector, and It seems there's no way to do this check.

At best I can check if the kernel supports connector or not, by looking
into /proc/net/netlink, or maybe checking the return value of bind() to
see if it's ENOENT.

So it would be useful to add /proc/net/connector to list all supported
connectors:
 # cat /proc/net/connector
 Name            ID
 connector       4294967295:4294967295
 cn_proc         1:1
 w1              3:1

Changelog:
- fix memory leak: s/seq_release/single_release
- use spin_lock_bh instead of spin_lock_irqsave

Signed-off-by: Li Zefan 
Acked-by: Evgeniy Polyakov 
Signed-off-by: David S. Miller

connector: convert to single-threaded workqueue

2008-03-24T04:51:12+00:00

From: Evgeniy Polyakov 

We don't need one cqueue thread for each CPU.  cqueue is used for
receiving userspace datagrams, which are very rare and thus will
happily live with a single queue.

Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

CONNECTOR: make cn_already_initialized static

2008-02-27T02:42:44+00:00

It is used in connector.c only, so make it static.

Signed-off-by: Li Zefan 
Signed-off-by: David S. Miller

[NETNS]: Consolidate kernel netlink socket destruction.

2008-01-28T23:08:07+00:00

Create a specific helper for netlink kernel socket disposal. This just
let the code look better and provides a ground for proper disposal
inside a namespace.

Signed-off-by: Denis V. Lunev 
Tested-by: Alexey Dobriyan 
Signed-off-by: David S. Miller

[CONNECTOR]: Cleanup struct cn_callback_entry

2008-01-28T23:00:40+00:00

- 'cb' is a fake struct member. In a previous patch struct cn_callback
was renamed to cn_callback_id, so 'cb' should have been deleted at that
time.

- 'nls' isn't used and is redundant, we can retrieve this data through
cn_callback_entry.pdev->nls.

- 'seq' and 'group' should be u32, as they are declared to be u32 in
other places.

Signed-off-by: Li Zefan 
Signed-off-by: David S. Miller

[CONNECTOR]: Cleanup struct cn_queue_dev

2008-01-28T23:00:39+00:00

Struct member netlink_groups is never used, and I don't see how it can
be useful.

Signed-off-by: Li Zefan 
Signed-off-by: David S. Miller

[CONNECTOR]: clean up {,__}cn_rx_skb()

2008-01-28T23:00:38+00:00

- __cn_rx_skb() does nothing but calls cn_call_callback(), it doesn't
check skb and msg sizes as the comment suggests, but cn_rx_skb() checks
those sizes.

- In cn_rx_skb() Local variable 'len' is not used. 'len' is probably
intended to be passed to skb_pull(), but here skb_pull() is not needed,
instead skb_free() is called.

Signed-off-by: Li Zefan 
Signed-off-by: David S. Miller

[CONNECTOR]: add a missing break in cn_netlink_send()

2008-01-28T23:00:37+00:00

Each entry in the list has a unique id, so just break out of the
loop if the matched id is found.

Signed-off-by: Li Zefan 
Signed-off-by: David S. Miller

[CONNECTOR]: Don't touch queue dev after decrement of ref count.

2008-01-09T07:44:44+00:00

cn_queue_free_callback() will touch 'dev'(i.e. cbq->pdev), so it
should be called before atomic_dec(&dev->refcnt).

Signed-off-by: Li Zefan 
Signed-off-by: David S. Miller

[CONNECTOR]: Return proper error code in cn_call_callback()

2008-01-04T11:55:37+00:00

Error code should be set to EINVAL instead of ENODEV if !queue_work().
There's another call of queue_work() which may set err to EINVAL.

Signed-off-by: Li Zefan 
Signed-off-by: David S. Miller