linux-stable.git/drivers/clocksource/timer-ti-dm.c, branch linux-5.0.y

Merge branch 'pwm-dmtimer-fixes' into omap-for-v5.0/fixes-v2

2019-01-29T15:53:47+00:00

bus: ti-sysc: Fix timer handling with drop pm_runtime_irq_safe()

2019-01-29T15:41:15+00:00

Commit 84badc5ec5fc ("ARM: dts: omap4: Move l4 child devices to probe
them with ti-sysc") started producing a warning for pwm-omap-dmtimer:

WARNING: CPU: 0 PID: 77 at drivers/bus/omap_l3_noc.c:147
l3_interrupt_handler+0x2f8/0x388
44000000.ocp:L3 Custom Error: MASTER MPU TARGET L4PER2 (Idle):
Data Access in Supervisor mode during Functional access
...
__pm_runtime_idle
omap_dm_timer_disable
pwm_omap_dmtimer_start
pwm_omap_dmtimer_enable
pwm_apply_state
pwm_vibrator_start
pwm_vibrator_play_work

This is because the timer that pwm-omap-dmtimer is using is now being
probed with ti-sysc interconnect target module instead of omap_device
and the ti-sysc quirk for SYSC_QUIRK_LEGACY_IDLE is not fully
compatible with what omap_device has been doing.

We could fix this by reverting the timer changes and have the timer
probe again with omap_device. Or we could add more quirk handling to
ti-sysc driver. But as these options don't work nicely as longer term
solutions, let's just make timers probe with ti-sysc without any
quirks.

To do this, all we need to do is remove quirks for timers for ti-sysc,
and drop the bogus pm_runtime_irq_safe() flag for timer-ti-dm.

We should not use pm_runtime_irq_safe() anyways for drivers as it will
take a permanent use count on the parent device blocking the parent
devices from idling and has been forcing ti-sysc driver to use a
quirk flag.

Note that we will move the timer data to DEBUG section later on in
clean-up patches.

Fixes: 84badc5ec5fc ("ARM: dts: omap4: Move l4 child devices to probe them with ti-sysc")
Cc: Andy Shevchenko 
Cc: Bartosz Golaszewski 
Cc: Daniel Lezcano 
Cc: H. Nikolaus Schaller 
Cc: Keerthy 
Cc: Ladislav Michl 
Cc: Pavel Machek 
Cc: Sebastian Reichel 
Cc: Tero Kristo 
Cc: Thierry Reding 
Cc: Thomas Gleixner 
Reported-by: H. Nikolaus Schaller 
Tested-By: Andreas Kemnade 
Tested-By: H. Nikolaus Schaller 
Signed-off-by: Tony Lindgren

clocksource: timer-ti-dm: Fix pwm dmtimer usage of fck reparenting

2019-01-22T17:03:08+00:00

Commit 84badc5ec5fc ("ARM: dts: omap4: Move l4 child devices to probe
them with ti-sysc") moved some omap4 timers to probe with ti-sysc
interconnect target module. Turns out this broke pwm-omap-dmtimer
where we now try to reparent the clock to itself with the following:

omap_dm_timer_of_set_source: failed to set parent

With ti-sysc, we can now configure the clock sources in the dts
with assigned-clocks and assigned-clock-parents. So we should be able
to remove omap_dm_timer_of_set_source with clean-up patches later on.
But for now, let's just fix it first by checking if parent and fck
are the same and bail out of so.

Fixes: 84badc5ec5fc ("ARM: dts: omap4: Move l4 child devices to probe them with ti-sysc")
Cc: Bartosz Golaszewski 
Cc: Daniel Lezcano 
Cc: H. Nikolaus Schaller 
Cc: Keerthy 
Cc: Ladislav Michl 
Cc: Pavel Machek 
Cc: Sebastian Reichel 
Cc: Tero Kristo 
Cc: Thierry Reding 
Cc: Thomas Gleixner 
Reported-by: H. Nikolaus Schaller 
Tested-By: Andreas Kemnade 
Tested-By: H. Nikolaus Schaller 
Signed-off-by: Tony Lindgren

clocksource/drivers/timer-ti-dm: Remove the early platform driver registration

2018-12-18T21:22:23+00:00

This driver is no longer used as an early platform driver. Remove the
registration macro.

Signed-off-by: Bartosz Golaszewski 
Signed-off-by: Daniel Lezcano

clocksource: timer-ti-dm: Check prescaler value

2018-02-28T21:41:30+00:00

Invalid value silently disables use of the prescaler.
Use -1 explicitely for that purpose and error out on
invalid value.

Signed-off-by: Ladislav Michl 
Signed-off-by: Tony Lindgren

clocksource: timer-ti-dm: Consolidate set source

2018-02-28T21:41:20+00:00

Reorder omap_dm_timer_set_source internals to get
source verification more straightforward.

Signed-off-by: Ladislav Michl 
Signed-off-by: Tony Lindgren

clocksource: timer-ti-dm: Make unexported functions static

2018-02-28T21:38:10+00:00

As dmtimer no longer exports functions, make those previously
exported static (this requires few functions to be moved around
as their prototypes were deleted).

Signed-off-by: Ladislav Michl 
Signed-off-by: Tony Lindgren

clocksource: timer-ti-dm: Hook device platform data if not already assigned

2018-02-22T18:54:14+00:00

In the case of device tree boot the device platform data is usually
NULL so hook the platform data obtained from the match.
As part of un-constify the platform_data pointer.

Signed-off-by: Ladislav Michl 
Signed-off-by: Keerthy 
Reviewed-by: Sebastian Reichel 
Signed-off-by: Tony Lindgren

clocksource: timer-ti-dm: Populate the timer ops to the pdata

2018-02-22T18:54:07+00:00

Add the timer ops to the platform data

Signed-off-by: Keerthy 
Reviewed-by: Sebastian Reichel 
Tested-by: Ladislav Michl 
Signed-off-by: Tony Lindgren

ARM: OMAP: Move dmtimer driver out of plat-omap to drivers under clocksource

2018-02-22T18:53:52+00:00

Move the dmtimer driver out of plat-omap to clocksource.
So that non-omap devices also could use this.

No Code changes done to the driver file only renamed to timer-ti-dm.c.
Also removed the config dependencies for OMAP_DM_TIMER.

Signed-off-by: Keerthy 
Reviewed-by: Sebastian Reichel 
Tested-by: Ladislav Michl 
[tony@atomide.com: add select omap_dm_timer for omap16xx]
Signed-off-by: Tony Lindgren