linux-stable.git/drivers/char, branch v5.18.3

Revert "random: use static branch for crng_ready()"

2022-06-09T08:30:55+00:00

This reverts upstream commit f5bda35fba615ace70a656d4700423fa6c9bebee
from stable. It's not essential and will take some time during 5.19 to
work out properly.

Signed-off-by: Jason A. Donenfeld

ipmi:ipmb: Fix refcount leak in ipmi_ipmb_probe

2022-06-09T08:30:41+00:00

commit a508e33956b538e034ed5df619a73ec7c15bda72 upstream.

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: 00d93611f002 ("ipmi:ipmb: Add the ability to have a separate slave and master device")
Signed-off-by: Miaoqian Lin 
Message-Id: <20220512044445.3102-1-linmq006@gmail.com>
Cc: stable@vger.kernel.org # v5.17+
Signed-off-by: Corey Minyard 
Signed-off-by: Greg Kroah-Hartman

hwrng: omap3-rom - fix using wrong clk_disable() in omap_rom_rng_runtime_resume()

2022-06-09T08:30:31+00:00

[ Upstream commit e4e62bbc6aba49a5edb3156ec65f6698ff37d228 ]

'ddata->clk' is enabled by clk_prepare_enable(), it should be disabled
by clk_disable_unprepare().

Fixes: 8d9d4bdc495f ("hwrng: omap3-rom - Use runtime PM instead of custom functions")
Signed-off-by: Yang Yingliang 
Signed-off-by: Herbert Xu 
Signed-off-by: Sasha Levin

hwrng: cn10k - Make check_rng_health() return an error code

2022-06-09T08:30:25+00:00

[ Upstream commit 32547a6aedda132907fcd15cdc8271429609f216 ]

Currently check_rng_health() returns zero unconditionally.
Make it to output an error code and return it.

Fixes: 38e9791a0209 ("hwrng: cn10k - Add random number generator support")
Signed-off-by: Vladis Dronov 
Signed-off-by: Herbert Xu 
Signed-off-by: Sasha Levin

hwrng: cn10k - Optimize cn10k_rng_read()

2022-06-09T08:30:25+00:00

[ Upstream commit 753d6770879894de10d74b437ab99ea380f1cad7 ]

This function assumes that sizeof(void) is 1 and arithmetic works for
void pointers. This is a GNU C extention and may not work with other
compilers. Change this by using an u8 pointer.

Also move cn10k_read_trng() out of a loop thus saving some cycles.

Fixes: 38e9791a0209 ("hwrng: cn10k - Add random number generator support")
Signed-off-by: Vladis Dronov 
Signed-off-by: Herbert Xu 
Signed-off-by: Sasha Levin

char: tpm: cr50_i2c: Suppress duplicated error message in .remove()

2022-06-09T08:29:47+00:00

[ Upstream commit e0687fe958f763f1790f22ed5483025b7624e744 ]

Returning an error value in an i2c remove callback results in an error
message being emitted by the i2c core, but otherwise it doesn't make a
difference. The device goes away anyhow and the devm cleanups are
called.

As tpm_cr50_i2c_remove() emits an error message already and the
additional error message by the i2c core doesn't add any useful
information, change the return value to zero to suppress this error
message.

Note that if i2c_clientdata is NULL, there is something really fishy.
Assuming no memory corruption happened (then all bets are lost anyhow),
tpm_cr50_i2c_remove() is only called after tpm_cr50_i2c_probe() returned
successfully. So there was a tpm chip registered before and after
tpm_cr50_i2c_remove() its privdata is freed but the associated character
device isn't removed. If after that happened userspace accesses the
character device it's likely that the freed memory is accessed. For that
reason the warning message is made a bit more frightening.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Jarkko Sakkinen 
Signed-off-by: Sasha Levin

ipmi: Fix pr_fmt to avoid compilation issues

2022-06-09T08:29:42+00:00

[ Upstream commit 2ebaf18a0b7fb764bba6c806af99fe868cee93de ]

The was it was wouldn't work in some situations, simplify it.  What was
there was unnecessary complexity.

Reported-by: kernel test robot 
Signed-off-by: Corey Minyard 
Signed-off-by: Sasha Levin

ipmi: Add an intializer for ipmi_smi_msg struct

2022-06-09T08:29:42+00:00

[ Upstream commit 9824117dd964ecebf5d81990dbf21dfb56445049 ]

There was a "type" element added to this structure, but some static
values were missed.  The default value will be zero, which is correct,
but create an initializer for the type and initialize the type properly
in the initializer to avoid future issues.

Reported-by: Joe Wiese 
Signed-off-by: Corey Minyard 
Signed-off-by: Sasha Levin

ipmi:ssif: Check for NULL msg when handling events and messages

2022-06-09T08:29:42+00:00

[ Upstream commit 7602b957e2404e5f98d9a40b68f1fd27f0028712 ]

Even though it's not possible to get into the SSIF_GETTING_MESSAGES and
SSIF_GETTING_EVENTS states without a valid message in the msg field,
it's probably best to be defensive here and check and print a log, since
that means something else went wrong.

Also add a default clause to that switch statement to release the lock
and print a log, in case the state variable gets messed up somehow.

Reported-by: Haowen Bai 
Signed-off-by: Corey Minyard 
Signed-off-by: Sasha Levin

tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe()

2022-06-06T06:48:59+00:00

commit d0dc1a7100f19121f6e7450f9cdda11926aa3838 upstream.

Currently it returns zero when CRQ response timed out, it should return
an error code instead.

Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
Signed-off-by: Xiu Jianfeng 
Reviewed-by: Stefan Berger 
Acked-by: Jarkko Sakkinen 
Signed-off-by: Jarkko Sakkinen 
Signed-off-by: Greg Kroah-Hartman