linux-stable.git/drivers/char/misc.c, branch v4.13

drivers: char: misc: Replace printk with pr_err.

2017-04-08T15:53:06+00:00

Replace printk with pr_err to fix the checkpatch issue.

Signed-off-by: Varsha Rao 
Signed-off-by: Greg Kroah-Hartman

drivers: char: misc: Add blank line after declaration.

2017-04-08T15:53:06+00:00

Add a blank line after declaration, to fix the checkpatch issue.

Signed-off-by: Varsha Rao 
Signed-off-by: Greg Kroah-Hartman

drivers: char: misc: Add space after ','.

2017-04-08T15:53:06+00:00

Add space which is required after ',' to follow linux coding style. This
patch fixes the checkpatch issue.

Signed-off-by: Varsha Rao 
Signed-off-by: Greg Kroah-Hartman

drivers: char: misc: Replace "foo * bar" with "foo *bar".

2017-04-08T15:53:06+00:00

Remove space after * in pointer type, to follow linux coding style. This
patch fixes the following checkpatch issue:

ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Varsha Rao 
Signed-off-by: Greg Kroah-Hartman

char: make misc_deregister a void function

2015-08-05T17:35:49+00:00

With well over 200+ users of this api, there are a mere 12 users that
actually checked the return value of this function.  And all of them
really didn't do anything with that information as the system or module
was shutting down no matter what.

So stop pretending like it matters, and just return void from
misc_deregister().  If something goes wrong in the call, you will get a
WARNING splat in the syslog so you know how to fix up your driver.
Other than that, there's nothing that can go wrong.

Cc: Alasdair Kergon 
Cc: Neil Brown 
Cc: Oleg Drokin 
Cc: Andreas Dilger 
Cc: "Michael S. Tsirkin" 
Cc: Wim Van Sebroeck 
Cc: Christine Caulfield 
Cc: David Teigland 
Cc: Mark Fasheh 
Acked-by: Joel Becker 
Acked-by: Alexandre Belloni 
Acked-by: Alessandro Zummo 
Acked-by: Mike Snitzer 
Signed-off-by: Greg Kroah-Hartman

char: misc: fix error path

2015-07-27T17:30:47+00:00

Lets call remove_proc_entry() in the error path only if we have
successfully created "misc" in procfs.

Signed-off-by: Sudip Mukherjee 
Signed-off-by: Greg Kroah-Hartman

char: misc: remove redundant ifdef

2015-07-27T17:30:47+00:00

The check for CONFIG_PROC_FS is not required as the check is being done
in proc_fs.h and incase CONFIG_PROC_FS is not defined then proc_create()
is defined as NULL.

Signed-off-by: Sudip Mukherjee 
Signed-off-by: Greg Kroah-Hartman

char: misc: restore MISC_DYNAMIC_MINOR on device_create() failure

2015-05-31T21:38:21+00:00

On attempt to register a dynamic minor misc device its minor number is
updated to a virtual minor number prior to device_create() call,
however on error path misc->minor == MISC_DYNAMIC_MINOR is not
restored.

Following the rule of thumb that a function returning an error must
not change the state of the caller, assign MISC_DYNAMIC_MINOR back.

The problem is met in a sutuation, when subsys_initcall(misc_init) is
not yet called and misc_class is not created, but misc_register()
modifies statically defined ".minor = MISC_DYNAMIC_MINOR", therefore
implicitly changing the client's logic on next attempt (e.g. retrying
from deferred list) to register a misc device, whose minor number is
converted from dynamic to some unknown static one.

Signed-off-by: Vladimir Zapolskiy 
Signed-off-by: Greg Kroah-Hartman

drivers: char: misc.c: remove trailing whitespace

2015-05-24T19:11:55+00:00

Remove trailing whitespace from several lines in drivers/char/misc.c
This was done using scripts/cleanfile

Signed-off-by: Tal Shorer 
Signed-off-by: Greg Kroah-Hartman

misc: pass miscdevice through file's private_data

2015-04-03T14:15:30+00:00

Make the miscdevice accessible through the file's private_data.

Previously, this was done only when an open() file operation had been
registered. If no custom open() file operation was defined,
private_data was set to NULL.

This subtle quirk was confusing, to the point where kernel code
registered *empty* file open operations to have private_data point to
the misc device structure and avoid duplicating that logic.

And it could easily lead to bugs, where the addition or removal of a
custom open() file operation surprisingly changes the initial value of
a file's private_data structure.

To resolve this, we now place the miscdevice in the file's private_data
member unconditionally when open() is called.

Signed-off-by: Tom Van Braeckel 
Signed-off-by: Greg Kroah-Hartman